Skip to contentSkip to conversation

arm: mvebu: Add SPI1 pinctrl defines for Armada XP

PATCH New Stefan Roese 3 participants 4 messages Feb 29, 2016 – Jul 13, 2016 Device tree bindings

lore
Share & tools
lore

Stefan Roese

author
#0 lore raw

PATCH 1/1 arm: mvebu: Add SPI1 pinctrl defines for Armada XP

This patch defines and uses common Armada XP pinctrl settings in armada-xp.dtsi for the SPI1 interface (MPP13,14,16,17).

Signed-off-by Stefan Roese <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Gregory CLEMENT <[email protected]>
---
 arch/arm/boot/dts/armada-xp.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
arch/arm/boot/dts/armada-xp.dtsi +8 -0
index be23196..c779e31 100644
@@ -94,6 +94,8 @@
 			spi1: spi at 10680 {
 				compatible = "marvell,armada-xp-spi",
 						"marvell,orion-spi";
+				pinctrl-0 = <&spi1_pins>;
+				pinctrl-names = "default";
 			};
 
 

@@ -343,6 +345,12 @@
 		marvell,function = "spi0";
 	};
 
+	spi1_pins: spi1-pins {
+		marvell,pins = "mpp13", "mpp14",
+			       "mpp16", "mpp17";
+		marvell,function = "spi1";
+	};
+
 	uart2_pins: uart2-pins {
 		marvell,pins = "mpp42", "mpp43";
 		marvell,function = "uart2";
Signature · 1 line
2.7.2
#1 lore raw

PATCH 1/1 arm: mvebu: Add SPI1 pinctrl defines for Armada XP

Dear Stefan Roese,

Quoted 9 lines · Stefan Roese

This patch defines and uses common Armada XP pinctrl settings in armada-xp.dtsi for the SPI1 interface (MPP13,14,16,17).

Signed-off-by Stefan Roese <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Gregory CLEMENT <[email protected]>
---
 arch/arm/boot/dts/armada-xp.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)
Reviewed-by Thomas Petazzoni <[email protected]>

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 arm: mvebu: Add SPI1 pinctrl defines for Armada XP

Hi Gregory,

Quoted 4 lines · Thomas Petazzoni
Quoted 3 lines · Stefan Roese

This patch defines and uses common Armada XP pinctrl settings in armada-xp.dtsi for the SPI1 interface (MPP13,14,16,17).

Quoted 8 lines
Quoted 6 lines
Signed-off-by Stefan Roese <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Gregory CLEMENT <[email protected]>
---
  arch/arm/boot/dts/armada-xp.dtsi | 8 ++++++++
  1 file changed, 8 insertions(+)
Reviewed-by Thomas Petazzoni <[email protected]>

I'm currently rebasing my SPI dts patches and noticed that this patch is not in mailine yet. Should I perhaps send it again with the SPI dts move patches?

Thanks,
Stefan

#3 lore raw

PATCH 1/1 arm: mvebu: Add SPI1 pinctrl defines for Armada XP

Hi Stefan,

Quoted 14 lines · Stefan Roese

Hi Gregory,

Quoted 11 lines · Thomas Petazzoni
Quoted 9 lines · Stefan Roese

This patch defines and uses common Armada XP pinctrl settings in armada-xp.dtsi for the SPI1 interface (MPP13,14,16,17).

Signed-off-by Stefan Roese <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Gregory CLEMENT <[email protected]>
---
  arch/arm/boot/dts/armada-xp.dtsi | 8 ++++++++
  1 file changed, 8 insertions(+)
Quoted 5 lines
Quoted 1 line
Reviewed-by Thomas Petazzoni <[email protected]>

I'm currently rebasing my SPI dts patches and noticed that this patch is not in mailine yet. Should I perhaps send it again with the SPI dts move patches?

Yes sure, there was no reason to not having merging it at this time, I think I've just missed it.

Gregory

Quoted 3 lines

Thanks,
Stefan

Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com