perf, tools: Refactor and support interval and CSV metrics
[v5: Fix mainly bisect problems. No regressions introduced by one patch and fixed again later. Some minor fixes in addition]
[v6: Fix running/noise printing patch.]
[v7: Reorder and merge two patches to avoid a bisect hole where unsupported was printed as 0]
[v8: Minor fixes for review feedback. See changelog in patches.] [v9: Fix newline bug. Add support for -A for --metric-only]
[v10: Remove extra "noise" printing (Jiri)
Fix fields in documentation (Jiri)]
[v11: Fix manpage again. Avoid extra metric output in CSV mode.] [v12: Move CSV metrics fields to after running/enabled/variance.
Minor fixes.]
[v13: Address review comments. Now probe for stalled events
in advance to avoid empty columns or lines. Fix -A shadowing. Various minor changes. Drop merged patches.]
Currently perf stat does not support printing computed metrics for interval (-I xxx) or CSV (-x,) mode. For example IPC or TSX metrics over time are quite useful to know.
This patch implements them. The main obstacle was that the
metrics printing was all open coded all over the metrics computation code. The second patch refactors the metrics printing to work through call backs that can be more easily changed. This also cleans up the metrics printing significantly. The indentation is now handled through printf, no more need to manually count spaces.
Then based on that it implements metrics printing for CSV and interval mode, and finally a --metric-only mode.
Example output:
% perf stat -I1000 -a sleep 1
# time counts unit events metric multiplex
1.001301370 12020.049593 task-clock (msec) (100.00%)
1.001301370 3,952 context-switches # 0.329 K/sec (100.00%)
1.001301370 69 cpu-migrations # 0.006 K/sec (100.00%)
1.001301370 76 page-faults # 0.006 K/sec
1.001301370 386,582,789 cycles # 0.032 GHz (100.00%)
1.001301370 716,441,544 stalled-cycles-frontend # 185.33% frontend cycles idle (100.00%)
1.001301370 <not supported> stalled-cycles-backend
1.001301370 101,751,678 instructions # 0.26 insn per cycle
1.001301370 # 7.04 stalled cycles per insn (100.00%)
1.001301370 20,914,692 branches # 1.740 M/sec (100.00%)
1.001301370 1,943,630 branch-misses # 9.29% of all branches CSV mode:
% perf stat -x, -I1000 -a sleep 1
1.000982778,12006.549977,,task-clock,12006547787,100.00,,,,
1.000982778,12822,,context-switches,12007100604,100.00,0.001,M/sec
1.000982778,175,,cpu-migrations,12007180306,100.00,0.015,K/sec
1.000982778,3404,,page-faults,12007185482,100.00,0.284,K/sec
1.000982778,1930307489,,cycles,12007018233,100.00,0.161,GHz
1.000982778,6971803638,,stalled-cycles-frontend,12006902870,100.00,361.18,frontend cycles idle
1.000982778,464493941,,instructions,12006873327,100.00,0.24,insn per cycle
1.000982778,,,,,,15.01,stalled cycles per insn
1.000982778,86548409,,branches,12006758420,100.00,7.208,M/sec
1.000982778,4933638,,branch-misses,12006648104,100.00,5.70,of all branchesNow includes metrics
Metric only mode:
Concicse information if you only care about computed metrics, not raw values
% perf stat --metric-only -a -I 1000
1.001452803 frontend cycles idle insn per cycle stalled cycles per insn branch-misses of all branches
1.001452803 158.91% 0.66 2.39 2.92%
2.002192321 180.63% 0.76 2.08 2.96%
3.003088282 150.59% 0.62 2.57 2.84%
4.004369835 196.20% 0.98 1.62 3.79%
5.005227314 231.98% 0.84 1.90 4.71%Metric only mode in CSV (flat format, easy to plot and analyze in statistical tools like JMP, R, pandas, gnuplot):
% perf stat -x, --metric-only -a -I 1000
1.001381652,frontend cycles idle,insn per cycle,stalled cycles per insn,branch-misses of all branches,
1.001381652,173.32,0.83,2.09,1.73,
2.002073343,199.47,1.07,1.60,2.14,
3.002875524,109.52,0.22,7.83,1.63,
4.003970059,132.10,0.17,10.85,1.51,
5.004818754,181.60,0.22,8.87,2.22,Available ingit://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc-2.6 perf/stat-metrics-17
PATCH 1/6 perf, tools, stat: Check existence of frontend/backed stalled cycles
From: Andi Kleen <[email protected]>
Only put the frontend/backend stalled cycles into the default perf stat events when the CPU actually supports them.
This avoids empty columns with --metric-only on newer Intel CPUs.
--- tools/perf/builtin-stat.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)
tools/perf/builtin-stat.c +20 -2
@@ -1441,7 +1441,7 @@ static int perf_stat_init_aggr_mode_file(struct perf_stat *st)*/ static int add_default_attributes (void ) { -struct perf_event_attr default_attrs[] = { +struct perf_event_attr default_attrs0[] = { { .type =PERF_TYPE_SOFTWARE , .config =PERF_COUNT_SW_TASK_CLOCK }, { .type =PERF_TYPE_SOFTWARE , .config =PERF_COUNT_SW_CONTEXT_SWITCHES },
@@ -1449,8 +1449,14 @@ static int add_default_attributes(void) { .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_PAGE_FAULTS }, { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_CPU_CYCLES }, +}; +struct perf_event_attr frontend_attrs[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_STALLED_CYCLES_FRONTEND }, +}; +struct perf_event_attr backend_attrs[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_STALLED_CYCLES_BACKEND }, +}; +struct perf_event_attr default_attrs1[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_INSTRUCTIONS }, { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_BRANCH_INSTRUCTIONS }, { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_BRANCH_MISSES },
@@ -1567,7 +1573,19 @@ static int add_default_attributes(void) }if (!evsel_list->nr_entries) { -if (perf_evlist__add_default_attrs (evsel_list, default_attrs) <0 ) +if (perf_evlist__add_default_attrs (evsel_list, default_attrs0) <0 ) +return -1 ; +if (pmu_have_event ("cpu" ,"stalled-cycles-frontend" )) { +if (perf_evlist__add_default_attrs (evsel_list, + frontend_attrs) <0 ) +return -1 ; + } +if (pmu_have_event ("cpu" ,"stalled-cycles-backend" )) { +if (perf_evlist__add_default_attrs (evsel_list, + backend_attrs) <0 ) +return -1 ; + } +if (perf_evlist__add_default_attrs (evsel_list, default_attrs1) <0 )return -1 ; }
Signature · 1 line
2.5.0
Re: [PATCH 1/6] perf, tools, stat: Check existence of frontend/backed stalled cycles
Quoted 8 lines · Andi Kleen
From: Andi Kleen <[email protected]>
Only put the frontend/backend stalled cycles into the default perf stat events when the CPU actually supports them.
This avoids empty columns with --metric-only on newer Intel CPUs.
Signed-off-by Andi Kleen <[email protected]>
thanks,
jirka
Quoted 56 lines
--- tools/perf/builtin-stat.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)tools/perf/builtin-stat.c +20
-2@@ -1441,7 +1441,7 @@ static int perf_stat_init_aggr_mode_file(struct perf_stat *st)*/ static int add_default_attributes (void ) { -struct perf_event_attr default_attrs[] = { +struct perf_event_attr default_attrs0[] = { { .type =PERF_TYPE_SOFTWARE , .config =PERF_COUNT_SW_TASK_CLOCK }, { .type =PERF_TYPE_SOFTWARE , .config =PERF_COUNT_SW_CONTEXT_SWITCHES },@@ -1449,8 +1449,14 @@ static int add_default_attributes(void) { .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_PAGE_FAULTS }, { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_CPU_CYCLES }, +}; +struct perf_event_attr frontend_attrs[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_STALLED_CYCLES_FRONTEND }, +}; +struct perf_event_attr backend_attrs[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_STALLED_CYCLES_BACKEND }, +}; +struct perf_event_attr default_attrs1[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_INSTRUCTIONS }, { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_BRANCH_INSTRUCTIONS }, { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_BRANCH_MISSES },@@ -1567,7 +1573,19 @@ static int add_default_attributes(void) }if (!evsel_list->nr_entries) { -if (perf_evlist__add_default_attrs (evsel_list, default_attrs) <0 ) +if (perf_evlist__add_default_attrs (evsel_list, default_attrs0) <0 ) +return -1 ; +if (pmu_have_event ("cpu" ,"stalled-cycles-frontend" )) { +if (perf_evlist__add_default_attrs (evsel_list, + frontend_attrs) <0 ) +return -1 ; + } +if (pmu_have_event ("cpu" ,"stalled-cycles-backend" )) { +if (perf_evlist__add_default_attrs (evsel_list, + backend_attrs) <0 ) +return -1 ; + } +if (perf_evlist__add_default_attrs (evsel_list, default_attrs1) <0 )return -1 ; }Signature · 1 line
2.5.0
Arnaldo Carvalho de Melo
maintainerRe: [PATCH 1/6] perf, tools, stat: Check existence of frontend/backed stalled cycles
Em Mon, Feb 29, 2016 at 11:10:35AM +0100, Jiri Olsa escreveu:
Quoted 11 lines · Andi Kleen
Quoted 8 lines
From: Andi Kleen <[email protected]>
Only put the frontend/backend stalled cycles into the default perf stat events when the CPU actually supports them.
This avoids empty columns with --metric-only on newer Intel CPUs.
Signed-off-by Andi Kleen <[email protected]>Acked-by Jiri Olsa <[email protected]>
Applied and tested, thanks!
- Arnaldo
tip-bot for Andi Kleen
merge bot[tip:perf/core] perf stat: Check existence of frontend/backed stalled cycles
In reply to Andi Kleenperf stat: Check existence of frontend/backed stalled cycles
Commit-ID: 9dec4473abe7967c204fe700baf5344ade34e9c8 Gitweb: http://git.kernel.org/tip/9dec4473abe7967c204fe700baf5344ade34e9c8 Author: Andi Kleen <[email protected]> AuthorDate: Fri, 26 Feb 2016 16:27:56 -0800 Committer: Arnaldo Carvalho de Melo <[email protected]> CommitDate: Thu, 3 Mar 2016 11:06:43 -0300
perf stat: Check existence of frontend/backed stalled cycles
Only put the frontend/backend stalled cycles into the default perf stat events when the CPU actually supports them.
This avoids empty columns with --metric-only on newer Intel CPUs.
Committer note:
Before:
$ perf stat ls
Performance counter stats for 'ls':
1.080893 task-clock (msec) # 0.619 CPUs utilized
0 context-switches # 0.000 K/sec
0 cpu-migrations # 0.000 K/sec
97 page-faults # 0.090 M/sec
3,327,741 cycles # 3.079 GHz
<not supported> stalled-cycles-frontend
<not supported> stalled-cycles-backend
1,609,544 instructions # 0.48 insn per cycle
319,117 branches # 295.235 M/sec
12,246 branch-misses # 3.84% of all branches0.001746508 seconds time elapsed
$
After:
$ perf stat ls
Performance counter stats for 'ls':
0.693948 task-clock (msec) # 0.662 CPUs utilized
0 context-switches # 0.000 K/sec
0 cpu-migrations # 0.000 K/sec
95 page-faults # 0.137 M/sec
1,792,509 cycles # 2.583 GHz
1,599,047 instructions # 0.89 insn per cycle
316,328 branches # 455.838 M/sec
12,453 branch-misses # 3.94% of all branches
0.001048987 seconds time elapsed
$
--- tools/perf/builtin-stat.c | 22 ++++++++++++++++++++-- 1 file changed, 20 insertions(+), 2 deletions(-)
tools/perf/builtin-stat.c +20 -2
@@ -1441,7 +1441,7 @@ static int perf_stat_init_aggr_mode_file(struct perf_stat *st)*/ static int add_default_attributes (void ) { -struct perf_event_attr default_attrs[] = { +struct perf_event_attr default_attrs0[] = { { .type =PERF_TYPE_SOFTWARE , .config =PERF_COUNT_SW_TASK_CLOCK }, { .type =PERF_TYPE_SOFTWARE , .config =PERF_COUNT_SW_CONTEXT_SWITCHES },
@@ -1449,8 +1449,14 @@ static int add_default_attributes(void) { .type = PERF_TYPE_SOFTWARE, .config = PERF_COUNT_SW_PAGE_FAULTS }, { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_CPU_CYCLES }, +}; +struct perf_event_attr frontend_attrs[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_STALLED_CYCLES_FRONTEND }, +}; +struct perf_event_attr backend_attrs[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_STALLED_CYCLES_BACKEND }, +}; +struct perf_event_attr default_attrs1[] = { { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_INSTRUCTIONS }, { .type =PERF_TYPE_HARDWARE , .config =PERF_COUNT_HW_BRANCH_INSTRUCTIONS }, { .type = PERF_TYPE_HARDWARE, .config = PERF_COUNT_HW_BRANCH_MISSES },
@@ -1567,7 +1573,19 @@ static int add_default_attributes(void) }if (!evsel_list->nr_entries) { -if (perf_evlist__add_default_attrs (evsel_list, default_attrs) <0 ) +if (perf_evlist__add_default_attrs (evsel_list, default_attrs0) <0 ) +return -1 ; +if (pmu_have_event ("cpu" ,"stalled-cycles-frontend" )) { +if (perf_evlist__add_default_attrs (evsel_list, + frontend_attrs) <0 ) +return -1 ; + } +if (pmu_have_event ("cpu" ,"stalled-cycles-backend" )) { +if (perf_evlist__add_default_attrs (evsel_list, + backend_attrs) <0 ) +return -1 ; + } +if (perf_evlist__add_default_attrs (evsel_list, default_attrs1) <0 )return -1 ; }
PATCH 2/6 perf, tools, stat: Implement CSV metrics output
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Now support CSV output for metrics. With the new output callbacks this is relatively straight forward by creating new callbacks.
This allows to easily plot metrics from CSV files.
The new line callback needs to know the number of fields to skip them correctly
Example output before:
% perf stat -x, true
0.200687,,task-clock,200687,100.00
0,,context-switches,200687,100.00
0,,cpu-migrations,200687,100.00
40,,page-faults,200687,100.00
730871,,cycles,203601,100.00
551056,,stalled-cycles-frontend,203601,100.00
<not supported>,,stalled-cycles-backend,0,100.00
385523,,instructions,203601,100.00
78028,,branches,203601,100.00
3946,,branch-misses,203601,100.00
After:
% perf stat -x, true .502457,,task-clock,502457,100.00,0.485,CPUs utilized 0,,context-switches,502457,100.00,0.000,K/sec 0,,cpu-migrations,502457,100.00,0.000,K/sec 45,,page-faults,502457,100.00,0.090,M/sec 644692,,cycles,509102,100.00,1.283,GHz 423470,,stalled-cycles-frontend,509102,100.00,65.69,frontend cycles idle <not supported>,,stalled-cycles-backend,0,100.00,,,, 492701,,instructions,509102,100.00,0.76,insn per cycle ,,,,,0.86,stalled cycles per insn 97767,,branches,509102,100.00,194.578,M/sec 4788,,branch-misses,509102,100.00,4.90,of all branches
or easier readable
perf stat -x, -o x.csv true
[ak@tassilo hle]$ column -s, -t x.csv
0.490635 task-clock 490635 100.00 0.489 CPUs utilized
0 context-switches 490635 100.00 0.000 K/sec
0 cpu-migrations 490635 100.00 0.000 K/sec
45 page-faults 490635 100.00 0.092 M/sec
629080 cycles 497698 100.00 1.282 GHz
409498 stalled-cycles-frontend 497698 100.00 65.09 frontend cycles idle
<not supported> stalled-cycles-backend 0 100.00
491424 instructions 497698 100.00 0.78 insn per cycle
0.83 stalled cycles per insn
97278 branches 497698 100.00 198.270 M/sec
4569 branch-misses 497698 100.00 4.70 of all branchesTwo new fields are added: metric value and metric name.
v2: Split out function argument changes
v3: Reenable metrics for real.
v4: Fix wrong hunk from refactoring.
v5: Remove extra "noise" printing (Jiri), but add it to the not counted case. Print empty metrics for not counted.
v6: Avoid outputting metric on empty format.
v7: Print metric at the end
v8: Remove extra run, ena fields
--- tools/perf/builtin-stat.c | 73 ++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 69 insertions(+), 4 deletions(-)
tools/perf/builtin-stat.c +69 -4
@@ -739,6 +739,7 @@ struct outstate {FILE *fh;bool newline;const char *prefix; +int nfields; };#define METRIC_LEN 35
@@ -789,6 +790,43 @@ static void print_metric_std(void *ctx, const char *color, const char *fmt,fprintf (out," %-*s" ,METRIC_LEN - n -1 , unit); } +static void new_line_csv (void *ctx) +{ +struct outstate *os = ctx; +int i; + +fputc ('\n' , os->fh); +if (os->prefix) +fprintf (os->fh,"%s%s" , os->prefix, csv_sep); +for (i =0 ; i < os->nfields; i++) +fputs (csv_sep, os->fh); +} + +static void print_metric_csv (void *ctx, +const char *color__maybe_unused , +const char *fmt,const char *unit,double val) +{ +struct outstate *os = ctx; +FILE *out = os->fh; +char buf[64 ], *vals, *ends; + +if (unit ==NULL || fmt ==NULL ) { +fprintf (out,"%s%s%s%s" , csv_sep, csv_sep, csv_sep, csv_sep); +return ; + } +snprintf (buf,sizeof (buf), fmt, val); + vals = buf; +while (isspace (*vals)) + vals++; + ends = vals; +while (isdigit (*ends) || *ends =='.' ) + ends++; + *ends =0 ; +while (isspace (*unit)) + unit++; +fprintf (out,"%s%s%s%s" , csv_sep, vals, csv_sep, unit); +} +static void nsec_printout (int id,int nr,struct perf_evsel *evsel,double avg) {FILE *output = stat_config.output;
@@ -860,6 +898,22 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval, nl = new_line_std; +if (csv_output) { +static int aggr_fields[] = { + [AGGR_GLOBAL ] =0 , + [AGGR_THREAD ] =1 , + [AGGR_NONE ] =1 , + [AGGR_SOCKET ] =2 , + [AGGR_CORE ] =2 , + }; + + pm = print_metric_csv; + nl = new_line_csv; + os.nfields =3 ; + os.nfields += aggr_fields[stat_config.aggr_mode]; +if (counter->cgrp) + os.nfields++; + }if (run ==0 || ena ==0 || counter->counts->scaled ==-1 ) {aggr_printout (counter, id, nr);
@@ -880,7 +934,12 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,fprintf (stat_config.output,"%s%s" , csv_sep, counter->cgrp->name); +if (!csv_output) +pm (&os,NULL ,NULL ,"" ,0 ); +print_noise (counter, noise);print_running (run, ena); +if (csv_output) +pm (&os,NULL ,NULL ,"" ,0 );return ; }
@@ -893,14 +952,20 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval, out.new_line = nl; out.ctx = &os; -if (!csv_output) -perf_stat__print_shadow_stats (counter, uval, +if (csv_output) { +print_noise (counter, noise); +print_running (run, ena); + } + +perf_stat__print_shadow_stats (counter, uval, stat_config.aggr_mode ==AGGR_GLOBAL ?0 :cpu_map__id_to_cpu (id), &out); -print_noise (counter, noise); -print_running (run, ena); +if (!csv_output) { +print_noise (counter, noise); +print_running (run, ena); + } }static void print_aggr (char *prefix)
Signature · 1 line
2.5.0
Re: [PATCH 2/6] perf, tools, stat: Implement CSV metrics output
Quoted 55 lines · Andi Kleen
From: Andi Kleen <[email protected]>
Now support CSV output for metrics. With the new output callbacks this is relatively straight forward by creating new callbacks.
This allows to easily plot metrics from CSV files.
The new line callback needs to know the number of fields to skip them correctly
Example output before:
% perf stat -x, true
0.200687,,task-clock,200687,100.00
0,,context-switches,200687,100.00
0,,cpu-migrations,200687,100.00
40,,page-faults,200687,100.00
730871,,cycles,203601,100.00
551056,,stalled-cycles-frontend,203601,100.00
<not supported>,,stalled-cycles-backend,0,100.00
385523,,instructions,203601,100.00
78028,,branches,203601,100.00
3946,,branch-misses,203601,100.00After:
% perf stat -x, true .502457,,task-clock,502457,100.00,0.485,CPUs utilized 0,,context-switches,502457,100.00,0.000,K/sec 0,,cpu-migrations,502457,100.00,0.000,K/sec 45,,page-faults,502457,100.00,0.090,M/sec 644692,,cycles,509102,100.00,1.283,GHz 423470,,stalled-cycles-frontend,509102,100.00,65.69,frontend cycles idle <not supported>,,stalled-cycles-backend,0,100.00,,,, 492701,,instructions,509102,100.00,0.76,insn per cycle ,,,,,0.86,stalled cycles per insn 97767,,branches,509102,100.00,194.578,M/sec 4788,,branch-misses,509102,100.00,4.90,of all branches
or easier readable
perf stat -x, -o x.csv true
[ak@tassilo hle]$ column -s, -t x.csv0.490635 task-clock 490635 100.00 0.489 CPUs utilized 0 context-switches 490635 100.00 0.000 K/sec 0 cpu-migrations 490635 100.00 0.000 K/sec 45 page-faults 490635 100.00 0.092 M/sec 629080 cycles 497698 100.00 1.282 GHz 409498 stalled-cycles-frontend 497698 100.00 65.09 frontend cycles idle <not supported> stalled-cycles-backend 0 100.00 491424 instructions 497698 100.00 0.78 insn per cycle 0.83 stalled cycles per insn 97278 branches 497698 100.00 198.270 M/sec 4569 branch-misses 497698 100.00 4.70 of all branches
Quoted 1 line
Two new fields are added: metric value and metric name.
I'm still getting the empty line:
[jolsa@krava perf]$ ./perf stat -x, true 0.389590,,task-clock,389590,100.00,0.479,CPUs utilized 0,,context-switches,389590,100.00,0.000,K/sec 0,,cpu-migrations,389590,100.00,0.000,K/sec 43,,page-faults,389590,100.00,0.110,M/sec 536038,,cycles,393283,100.00,1.376,GHz 429548,,instructions,393283,100.00,0.80,insn per cycle ,,,,,,,, 85012,,branches,393283,100.00,218.209,M/sec 3600,,branch-misses,393283,100.00,4.23,of all branches
it's not enough just not to include stalled cycles events in case they are not supported, like you do in patch 1
perf_stat__print_shadow_stats prints stalled cycles data within instruction event case, so you need to check for stalled cycles in evlist in there
we have pointer to the evlist in each evsel, so it should be easy
thanks,
jirka
Arnaldo Carvalho de Melo
maintainerRe: [PATCH 2/6] perf, tools, stat: Implement CSV metrics output
Em Mon, Feb 29, 2016 at 11:20:48AM +0100, Jiri Olsa escreveu:
Quoted 40 lines · Andi Kleen
Quoted 39 lines
From: Andi Kleen <[email protected]>
Now support CSV output for metrics. With the new output callbacks this is relatively straight forward by creating new callbacks.
This allows to easily plot metrics from CSV files.
The new line callback needs to know the number of fields to skip them correctly
Example output before:
% perf stat -x, true
0.200687,,task-clock,200687,100.00
0,,context-switches,200687,100.00
0,,cpu-migrations,200687,100.00
40,,page-faults,200687,100.00
730871,,cycles,203601,100.00
551056,,stalled-cycles-frontend,203601,100.00
<not supported>,,stalled-cycles-backend,0,100.00
385523,,instructions,203601,100.00
78028,,branches,203601,100.00
3946,,branch-misses,203601,100.00After:
% perf stat -x, true .502457,,task-clock,502457,100.00,0.485,CPUs utilized 0,,context-switches,502457,100.00,0.000,K/sec 0,,cpu-migrations,502457,100.00,0.000,K/sec 45,,page-faults,502457,100.00,0.090,M/sec 644692,,cycles,509102,100.00,1.283,GHz 423470,,stalled-cycles-frontend,509102,100.00,65.69,frontend cycles idle <not supported>,,stalled-cycles-backend,0,100.00,,,, 492701,,instructions,509102,100.00,0.76,insn per cycle ,,,,,0.86,stalled cycles per insn 97767,,branches,509102,100.00,194.578,M/sec 4788,,branch-misses,509102,100.00,4.90,of all branches
Quoted 3 lines
Quoted 1 line
Two new fields are added: metric value and metric name.
I'm still getting the empty line:
Ditto here.
Quoted 22 lines
[jolsa@krava perf]$ ./perf stat -x, true 0.389590,,task-clock,389590,100.00,0.479,CPUs utilized 0,,context-switches,389590,100.00,0.000,K/sec 0,,cpu-migrations,389590,100.00,0.000,K/sec 43,,page-faults,389590,100.00,0.110,M/sec 536038,,cycles,393283,100.00,1.376,GHz 429548,,instructions,393283,100.00,0.80,insn per cycle ,,,,,,,, 85012,,branches,393283,100.00,218.209,M/sec 3600,,branch-misses,393283,100.00,4.23,of all branchesit's not enough just not to include stalled cycles events in case they are not supported, like you do in patch 1
perf_stat__print_shadow_statsprints stalled cycles data within instruction event case, so you need to check for stalled cycles in evlist in therewe have pointer to the evlist in each evsel, so it should be easy
thanks,
jirka
PATCH 3/6 perf, tools, stat: Support metrics in --per-core/socket mode
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Enable metrics printing in --per-core / --per-socket mode. We need to save the shadow metrics in a unique place. Always use the first CPU in the aggregation. Then use the same CPU to retrieve the shadow value later.
Example output:
% perf stat --per-core -a ./BC1s
Performance counter stats for 'system wide':
S0-C0 2 2966.020381 task-clock (msec) # 2.004 CPUs utilized (100.00%) S0-C0 2 49 context-switches # 0.017 K/sec (100.00%) S0-C0 2 4 cpu-migrations # 0.001 K/sec (100.00%) S0-C0 2 467 page-faults # 0.157 K/sec S0-C0 2 4,599,061,773 cycles # 1.551 GHz (100.00%) S0-C0 2 9,755,886,883 instructions # 2.12 insn per cycle (100.00%) S0-C0 2 1,906,272,125 branches # 642.704 M/sec (100.00%) S0-C0 2 81,180,867 branch-misses # 4.26% of all branches S0-C1 2 2965.995373 task-clock (msec) # 2.003 CPUs utilized (100.00%) S0-C1 2 62 context-switches # 0.021 K/sec (100.00%) S0-C1 2 8 cpu-migrations # 0.003 K/sec (100.00%) S0-C1 2 281 page-faults # 0.095 K/sec S0-C1 2 6,347,290 cycles # 0.002 GHz (100.00%) S0-C1 2 4,654,156 instructions # 0.73 insn per cycle (100.00%) S0-C1 2 947,121 branches # 0.319 M/sec (100.00%) S0-C1 2 37,322 branch-misses # 3.94% of all branches
1.480409747 seconds time elapsed
v2: Rebase to older patches
v3: Document shadow cpus. Fix aggr_get_id argument. Fix -A shadows (Jiri)
--- tools/perf/builtin-stat.c | 61 +++++++++++++++++++++++++++++++++++++------ tools/perf/util/stat-shadow.c | 7 +++++ 2 files changed, 60 insertions(+), 8 deletions(-)
tools/perf/builtin-stat.c +53 -8
@@ -740,6 +740,8 @@ struct outstate {bool newline;const char *prefix;int nfields; +int id, nr; +struct perf_evsel *evsel; };#define METRIC_LEN 35
@@ -755,12 +757,9 @@ static void do_new_line_std(struct outstate *os) {fputc ('\n' , os->fh);fputs (os->prefix, os->fh); +aggr_printout (os->evsel, os->id, os->nr);if (stat_config.aggr_mode ==AGGR_NONE )fprintf (os->fh," " ); -if (stat_config.aggr_mode ==AGGR_CORE ) -fprintf (os->fh," " ); -if (stat_config.aggr_mode ==AGGR_SOCKET ) -fprintf (os->fh," " );fprintf (os->fh," " ); }
@@ -798,6 +797,7 @@ static void new_line_csv(void *ctx)fputc ('\n' , os->fh);if (os->prefix)fprintf (os->fh,"%s%s" , os->prefix, csv_sep); +aggr_printout (os->evsel, os->id, os->nr);for (i =0 ; i < os->nfields; i++)fputs (csv_sep, os->fh); }
@@ -855,6 +855,25 @@ static void nsec_printout(int id, int nr, struct perf_evsel *evsel, double avg)fprintf (output,"%s%s" , csv_sep, evsel->cgrp->name); } +static int first_shadow_cpu (struct perf_evsel *evsel,int id) +{ +int i; + +if (stat_config.aggr_mode ==AGGR_NONE ) +return id; + +if (stat_config.aggr_mode ==AGGR_GLOBAL ) +return 0 ; + +for (i =0 ; i <perf_evsel__nr_cpus (evsel); i++) { +int cpu2 =perf_evsel__cpus (evsel)->map[i]; + +if (aggr_get_id (evsel_list->cpus, cpu2) == id) +return cpu2; + } +return 0 ; +} +static void abs_printout (int id,int nr,struct perf_evsel *evsel,double avg) {FILE *output = stat_config.output;
@@ -891,7 +910,10 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval,struct perf_stat_output_ctx out;struct outstate os = { .fh = stat_config.output, - .prefix = prefix ? prefix :"" + .prefix = prefix ? prefix :"" , + .id = id, + .nr = nr, + .evsel = counter, };print_metric_t pm = print_metric_std;void (*nl)(void *);
@@ -958,16 +980,37 @@ static void printout(int id, int nr, struct perf_evsel *counter, double uval, }perf_stat__print_shadow_stats (counter, uval, - stat_config.aggr_mode ==AGGR_GLOBAL ?0 : -cpu_map__id_to_cpu (id), +first_shadow_cpu (counter, id), &out); -if (!csv_output) {print_noise (counter, noise);print_running (run, ena); } } +static void aggr_update_shadow (void ) +{ +int cpu, s2, id, s; +u64 val; +struct perf_evsel *counter; + +for (s =0 ; s < aggr_map->nr; s++) { + id = aggr_map->map[s]; +evlist__for_each (evsel_list, counter) { + val =0 ; +for (cpu =0 ; cpu <perf_evsel__nr_cpus (counter); cpu++) { + s2 =aggr_get_id (evsel_list->cpus, cpu); +if (s2 != id) +continue ; + val +=perf_counts (counter->counts, cpu,0 )->val; + } + val = val * counter->scale; +perf_stat__update_shadow_stats (counter, &val, +first_shadow_cpu (counter, id)); + } + } +} +static void print_aggr (char *prefix) {FILE *output = stat_config.output;
@@ -979,6 +1022,8 @@ static void print_aggr(char *prefix)if (!(aggr_map || aggr_get_id))return ; +aggr_update_shadow (); +for (s =0 ; s < aggr_map->nr; s++) { id = aggr_map->map[s];evlist__for_each (evsel_list, counter) {
tools/perf/util/stat-shadow.c +7 -0
@@ -14,6 +14,13 @@ enum {#define NUM_CTX CTX_BIT_MAX +/* +* AGGR_GLOBAL: Use CPU 0 +* AGGR_SOCKET: Use first CPU of socket +* AGGR_CORE: Use first CPU of core +* AGGR_NONE: Use matching CPU +* AGGR_THREAD: Not supported? +*/ static struct stats runtime_nsecs_stats[MAX_NR_CPUS ];static struct stats runtime_cycles_stats[NUM_CTX ][MAX_NR_CPUS ];static struct stats runtime_stalled_cycles_front_stats[NUM_CTX ][MAX_NR_CPUS ];
Signature · 1 line
2.5.0
PATCH 4/6 perf, tools, stat: Document CSV format in manpage
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
With all the recently added fields in the perf stat CSV output we should finally document them in the man page. Do this here.
v2: Fix fields in documentation (Jiri)
v3: fix order of fields again (Jiri)
v4: Change order again.
--- tools/perf/Documentation/perf-stat.txt | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)
tools/perf/Documentation/perf-stat.txt +21 -0
@@ -211,6 +211,27 @@ $ perf stat -- make -j Wall-clock time elapsed: 719.554352 msecs +CSV FORMAT +---------- + +With -x, perf stat is able to output a not-quite-CSV format output +Commas in the output are not put into "". To make it easy to parse +it is recommended to use a different character like -x \; + +The fields are in this order: + + - optional usec time stamp in fractions of second (with -I xxx) + - counter value + - unit of the counter value or empty + - event name + - run time of counter + - percentage of measurement time the counter was running + - optional variance if multiple values are collected with -r + - optional metric value + - optional unit of metric + +Additional metrics may be printed with all earlier fields being empty. + SEE ALSO -------- linkperf:perf-top[1], linkperf:perf-list[1]
Signature · 1 line
2.5.0
PATCH 5/6 perf, tools, stat: Implement --metric-only mode
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Add a new mode to only print metrics. Sometimes we don't care about the raw values, just want the computed metrics. This allows more compact printing, so with -I each sample is only a single line. This also allows easier plotting and processing with other tools.
The main target is with using --topdown, but it also works with -T and standard perf stat. A few metrics are not supported.
To avoiding having to hardcode all the metrics in the code it uses a two pass approach: first compute dummy metrics and only print the headers in the print_metric callback. Then use the callback to print the actual values.
There are some additional changes
in the stat printout code to handle all metrics being on a single line.
One issue is that the column code doesn't know in advance what events are not supported by the CPU, and it would be hard to find out as this could change based on dynamic conditions. That causes empty columns in some cases.
The output can be fairly wide, often you may need more than 80 columns.
Example:
% perf stat -a -I 1000 --metric-only
1.001452803 frontend cycles idle insn per cycle stalled cycles per insn branch-misses of all branches
1.001452803 158.91% 0.66 2.39 2.92%
2.002192321 180.63% 0.76 2.08 2.96%
3.003088282 150.59% 0.62 2.57 2.84%
4.004369835 196.20% 0.98 1.62 3.79%
5.005227314 231.98% 0.84 1.90 4.71%v2: Lots of updates.
v3: Use slightly narrower columns
--- tools/perf/Documentation/perf-stat.txt | 4 + tools/perf/builtin-stat.c | 207 +++++++++++++++++++++++++++++++-- 2 files changed, 201 insertions(+), 10 deletions(-)
tools/perf/Documentation/perf-stat.txt +4 -0
@@ -139,6 +139,10 @@ Print count deltas every N milliseconds (minimum: 10ms) The overhead percentage could be high in some cases, for instance with small, sub 100ms intervals. Use with caution. example: 'perf stat -I 1000 -e cycles -a sleep 5' +--metric-only:: +Only print computed metrics. Print them in a single line. +Don't show any raw values. Not supported with -A or --per-thread. + --per-socket:: Aggregate counts per processor socket for system-wide mode measurements. This is a useful mode to detect imbalance between sockets. To enable this mode,
tools/perf/builtin-stat.c +197 -10
320 lines not on this page · raw message
Signature · 1 line
2.5.0
PATCH 6/6 perf, tools, stat: Add --metric-only support for -A
In reply to Andi KleenFrom: Andi Kleen <[email protected]>
Add metric only support for -A too. This requires a new print function that prints the metrics in the right order.
v2: Fix manpage
--- tools/perf/Documentation/perf-stat.txt | 2 +- tools/perf/builtin-stat.c | 48 ++++++++++++++++++++++++++++------ 2 files changed, 41 insertions(+), 9 deletions(-)
tools/perf/Documentation/perf-stat.txt +1 -1
@@ -141,7 +141,7 @@ The overhead percentage could be high in some cases, for instance with small, su --metric-only:: Only print computed metrics. Print them in a single line. -Don't show any raw values. Not supported with -A or --per-thread. +Don't show any raw values. Not supported with --per-thread. --per-socket:: Aggregate counts per processor socket for system-wide mode measurements. This
tools/perf/builtin-stat.c +40 -8
69 lines not on this page · raw message
Signature · 1 line
2.5.0