drm/crtc: Use drm_mode_object_put() in __drm_framebuffer_unregister()
Subsystems (2)
PATCH 1/1 drm/crtc: Use drm_mode_object_put() in __drm_framebuffer_unregister()
The function __drm_framebuffer_unregister() has boilerplate code to drop idr reference. Let's replace it with drm_mode_object_put() to simplify the code.
Signed-off-by Liu Ying <[email protected]>
--- drivers/gpu/drm/drm_crtc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/gpu/drm/drm_crtc.c +1 -3
@@ -430,9 +430,7 @@ EXPORT_SYMBOL(drm_framebuffer_init);static void __drm_framebuffer_unregister (struct drm_device *dev,struct drm_framebuffer *fb) { -mutex_lock (&dev->mode_config.idr_mutex); -idr_remove (&dev->mode_config.crtc_idr, fb->base.id); -mutex_unlock (&dev->mode_config.idr_mutex); +drm_mode_object_put (dev, &fb->base); fb->base.id =0 ; }
Signature · 6 lines
2.5.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Daniel Vetter
AppliedQuoted 4 lines · Liu Ying
The function
__drm_framebuffer_unregister()has boilerplate code to drop idr reference. Let's replace it withdrm_mode_object_put()to simplify the code.Signed-off-by Liu Ying <[email protected]>
Applied to drm-misc, thanks for the patch.
-Daniel
Quoted 26 lines
--- drivers/gpu/drm/drm_crtc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/gpu/drm/drm_crtc.c +1
-3@@ -430,9 +430,7 @@ EXPORT_SYMBOL(drm_framebuffer_init);static void __drm_framebuffer_unregister (struct drm_device *dev,struct drm_framebuffer *fb) { -mutex_lock (&dev->mode_config.idr_mutex); -idr_remove (&dev->mode_config.crtc_idr, fb->base.id); -mutex_unlock (&dev->mode_config.idr_mutex); +drm_mode_object_put (dev, &fb->base); fb->base.id =0 ; }Signature · 6 lines
2.5.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel