iommu/mediatek: checking for IS_ERR() instead of NULL

PATCH Applied Dan Carpenter 2 participants 2 messages Mar 2, 2016

Subsystems (4)

Kernel janitors Arm MediaTek IOMMU MediaTek IOMMU driver

lore

Share & tools

lore

Dan Carpenter

author

2016-03-02 10:10 UTC #0 lore raw

PATCH 2/2 iommu/mediatek: checking for IS_ERR() instead of NULL

of_platform_device_create() returns NULL on error, it never returns error pointers.

Fixes 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')

Signed-off-by Dan Carpenter <[email protected]>

drivers/iommu/mtk_iommu.c +3 -3

index 1a4022c..4682da4 100644
@@ -628,7 +628,7 @@ static int mtk_iommu_probe(struct platform_device *pdev)
 			plarbdev = of_platform_device_create(
 						larbnode, NULL,
 						platform_bus_type.dev_root);
-			if (IS_ERR(plarbdev))
+			if (!plarbdev)
 				return -EPROBE_DEFER;
 		}
 		data->smi_imu.larb_imu[i].dev = &plarbdev->dev;

@@ -721,8 +721,8 @@ static int mtk_iommu_init_fn(struct device_node *np)
 	struct platform_device *pdev;
 
 	pdev = of_platform_device_create(np, NULL, platform_bus_type.dev_root);
-	if (IS_ERR(pdev))
-		return PTR_ERR(pdev);
+	if (!pdev)
+		return -ENOMEM;
 
 	ret = platform_driver_register(&mtk_iommu_driver);
 	if (ret) {

Joerg Roedel

maintainer Applied

2016-03-02 14:49 UTC #1 lore raw

Quoted 5 lines · Dan Carpenter

of_platform_device_create() returns NULL on error, it never returns error pointers.
Fixes 0df4fabe208d ('iommu/mediatek: Add mt8173 IOMMU driver')
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks.