staging: mt29f_spinand: Replacing pr_info with dev_info after the call to devm_kzalloc
Subsystems (2)
PATCH 1/1 staging: mt29f_spinand: Replacing pr_info with dev_info after the call to devm_kzalloc
The function devm_kzalloc has a first argument of type struct device *. This is the type of argument required by printing functions such as dev_info, dev_err, etc. Thus, functions like pr_info should not normally be used after a call to devm_kzalloc. Thus, all pr_info occurances are replaced with dev_info function calls.
This was done using Coccinelle, the patch being:
@@
expression E1,E2;
expression list args;
@@
E1 = devm_kzalloc(E2, ...);
<...
- pr_info(
+ dev_info(E2,
args);
...>
--- drivers/staging/mt29f_spinand/mt29f_spinand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/mt29f_spinand/mt29f_spinand.c +2 -1
@@ -893,7 +893,8 @@ static int spinand_probe(struct spi_device *spi_nand)#else chip->ecc.mode =NAND_ECC_SOFT ;if (spinand_disable_ecc (spi_nand) <0 ) -pr_info ("%s: disable ecc failed!\n" , __func__); +dev_info (&spi_nand->dev,"%s: disable ecc failed!\n" , + __func__);#endif nand_set_flash_node (chip, spi_nand->dev.of_node);
Signature · 1 line
2.1.4
Quoted 47 lines · pooja.shamili
The function
devm_kzallochas a first argument of type struct device *. This is the type of argument required by printing functions such asdev_info,dev_err, etc. Thus, functions likepr_infoshould not normally be used after a call todevm_kzalloc. Thus, allpr_infooccurances are replaced withdev_infofunction calls.This was done using Coccinelle, the patch being:
@@
expression E1,E2;
expression list args;
@@E1 =
devm_kzalloc(E2, ...);
<...
- pr_info(
+ dev_info(E2,
args);
...>Signed-off-by pooja.shamili <[email protected]>--- drivers/staging/mt29f_spinand/mt29f_spinand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/mt29f_spinand/mt29f_spinand.c +2
-1@@ -893,7 +893,8 @@ static int spinand_probe(struct spi_device *spi_nand)#else chip->ecc.mode =NAND_ECC_SOFT ;if (spinand_disable_ecc (spi_nand) <0 ) -pr_info ("%s: disable ecc failed!\n" , __func__); +dev_info (&spi_nand->dev,"%s: disable ecc failed!\n" , + __func__);#endif nand_set_flash_node (chip, spi_nand->dev.of_node);Signature · 8 lines
2.1.4 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160303170735.GA3773%40localhost. For more options, visit https://groups.google.com/d/optout.
Hello Pooja,
I'm also working on the semantic patch you presented here but I'm aiming for the "extended" one. I'm using this driver to test my patch -- other than what you have changed, I suggest you also convert the other pr_ calls on this driver even if it's by hand and add that to your commit message. I think there are only 2 left, for consistency purposes.
Eva
Quoted 51 lines · Eva Rachel Retuya
Quoted 41 lines · pooja.shamili
The function
devm_kzallochas a first argument of type struct device *. This is the type of argument required by printing functions such asdev_info,dev_err, etc. Thus, functions likepr_infoshould not normally be used after a call todevm_kzalloc. Thus, allpr_infooccurances are replaced withdev_infofunction calls.This was done using Coccinelle, the patch being:
@@
expression E1,E2;
expression list args;
@@E1 =
devm_kzalloc(E2, ...);
<...
- pr_info(
+ dev_info(E2,
args);
...>Signed-off-by pooja.shamili <[email protected]>--- drivers/staging/mt29f_spinand/mt29f_spinand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/mt29f_spinand/mt29f_spinand.c +2
-2@@ -893,7 +893,8 @@ static int spinand_probe(struct spi_device *spi_nand)#else chip->ecc.mode =NAND_ECC_SOFT ;if (spinand_disable_ecc (spi_nand) <0 ) -pr_info ("%s: disable ecc failed!\n" , __func__); +dev_info (&spi_nand->dev,"%s: disable ecc failed!\n" , + __func__);#endif nand_set_flash_node (chip, spi_nand->dev.of_node); --2.1.4
Quoted 6 lines
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160303170735.GA3773%40localhost.
For more options, visit https://groups.google.com/d/optout.Hello Pooja,
Quoted 5 lines
I'm also working on the semantic patch you presented here but I'm aiming for the "extended" one. I'm using this driver to test my patch -- other than what you have changed, I suggest you also convert the other
pr_calls on this driver even if it's by hand and add that to your commit message. I think there are only 2 left, for consistency purposes.
If you do something partly by hand and partly with Coccinelle, please carefully indicate everything that you do by hand so that the reviewer will know to look for more than what is described by the semantic patch.
julia
Quoted 10 lines
Eva
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160305080019.GA28126%40Socrates-Mint.
For more options, visit https://groups.google.com/d/optout.