Skip to contentSkip to conversation

Staging: dgnc: Add block comments /* and */ on a separate line in dgnc_tty.c.

PATCH In review Sandhya Bankar 2 participants 2 messages Mar 6, 2016 – Mar 11, 2016 Staging

lore
Share & tools
lore

Sandhya Bankar

author
#0 lore raw

PATCH v2 1/1 Staging: dgnc: Add block comments /* and */ on a separate line in dgnc_tty.c.

Add block comments /* and */ on a separate line. The warning is reported by checkpatch.pl.

The preferred style for long (multi-line) comments is:
/*
*
*
*/

Signed-off-by Sandhya Bankar <[email protected]>

---
Changes in v2:
* No change.
*Compile this patch to check nothing is broken.

 drivers/staging/dgnc/dgnc_tty.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)
drivers/staging/dgnc/dgnc_tty.c +8 -4
index 0c0a26f..c90a458 100644
@@ -443,7 +443,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
 	brd->PrintDriver.termios = NULL;
 }
 
-/*=======================================================================
+/*
+ *=======================================================================
  *
  *	dgnc_wmove - Write data to transmit queue.
  *

@@ -451,7 +452,8 @@ void dgnc_tty_uninit(struct dgnc_board *brd)
  *		buf	- Pointer to characters to be moved.
  *		n	- Number of characters to move.
  *
- *=======================================================================*/
+ *=======================================================================
+ */
 static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)
 {
 	int	remain;

@@ -489,13 +491,15 @@ static void dgnc_wmove(struct channel_t *ch, char *buf, uint n)
 	ch->ch_w_head = head;
 }
 
-/*=======================================================================
+/*
+ *=======================================================================
  *
  *      dgnc_input - Process received data.
  *
  *	      ch      - Pointer to channel structure.
  *
- *=======================================================================*/
+ *=======================================================================
+ */
 void dgnc_input(struct channel_t *ch)
 {
 	struct dgnc_board *bd;
Signature · 1 line
1.8.3.4
maintainer
#1 lore raw
Quoted 9 lines · Sandhya Bankar

Add block comments /* and */ on a separate line. The warning is reported by checkpatch.pl.

The preferred style for long (multi-line) comments is:
/*
*
*
*/

Quoted 8 lines
Signed-off-by Sandhya Bankar <[email protected]>

---
Changes in v2:
* No change.
*Compile this patch to check nothing is broken.

 drivers/staging/dgnc/dgnc_tty.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

Doesn't apply to my tree :(