Skip to contentSkip to conversation

Staging: gs_fpgaboot: Fix multiple coding style issues.

PATCH In review Sandhya Bankar 2 participants 2 messages Mar 6, 2016 – Mar 11, 2016 Staging

lore
Share & tools
lore

Sandhya Bankar

author
#0 lore raw

PATCH 1/1 Staging: gs_fpgaboot: Fix multiple coding style issues.

Fix below coding style issues.
- Fix alignment to match open parenthesis.
- Use space around '+'.
- Remove unnecessary blank lines.

Signed-off-by Sandhya Bankar <[email protected]>
---
 drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
drivers/staging/gs_fpgaboot/gs_fpgaboot.c +3 -5
index fe3a6bc..96432c5 100644
@@ -93,7 +93,6 @@ static int readlength_bitstream(char *bitdata, int *lendata, int *offset)
 	return 0;
 }
 
-
 /*
  * read first 13 bytes to check bitstream magic number
  */

@@ -201,7 +200,7 @@ static int gs_download_image(struct fpgaimage *fimage, enum wbus bus_bytes)
 #endif /* DEBUG_FPGA */
 	if (!xl_supported_prog_bus_width(bus_bytes)) {
 		pr_err("unsupported program bus width %d\n",
-				bus_bytes);
+		       bus_bytes);
 		return -1;
 	}
 

@@ -222,7 +221,7 @@ static int gs_download_image(struct fpgaimage *fimage, enum wbus bus_bytes)
 	pr_info("device init done\n");
 
 	for (i = 0; i < size; i += bus_bytes)
-		xl_shift_bytes_out(bus_bytes, bitdata+i);
+		xl_shift_bytes_out(bus_bytes, bitdata + i);
 
 	pr_info("program done\n");
 

@@ -277,7 +276,7 @@ static int gs_set_download_method(struct fpgaimage *fimage)
 static int init_driver(void)
 {
 	firmware_pdev = platform_device_register_simple("fpgaboot", -1,
-							 NULL, 0);
+							NULL, 0);
 	return PTR_ERR_OR_ZERO(firmware_pdev);
 }
 

@@ -336,7 +335,6 @@ err_out1:
 	kfree(fimage);
 
 	return -1;
-
 }
 
 static int __init gs_fpgaboot_init(void)
Signature · 1 line
1.8.3.4
maintainer
#1 lore raw
Quoted 4 lines · Sandhya Bankar

Fix below coding style issues.
- Fix alignment to match open parenthesis.
- Use space around '+'.
- Remove unnecessary blank lines.

This should be 3 different patches.

Also you have trailing whitespace in your changelog comments :(