Skip to contentSkip to conversation

xhci:Remove unused marco definitions from the file xhci-hub.c

PATCH RESEND Greg KH 1 participant 1 message Mar 7, 2016 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author
#1 lore raw
Quoted 35 lines · Nicholas Krause

This removes the unneeded marco definitions for the marcos
of XHCI_PORT_RW1S, XHCI_PORT_RW1C, XHCI_PORT_RW and
XHCI_PORT_RZ due to no uses of these marcos in the file xhci-hub.c or any other related kernel source code file related to supporting xhci host controllers.

---
 drivers/usb/host/xhci-hub.c | 23 -----------------------
 1 file changed, 23 deletions(-)
drivers/usb/host/xhci-hub.c +0 -16
index e75c565..fd430de 100644
@@ -196,29 +196,6 @@ static unsigned int xhci_port_speed(unsigned int port_status)
  * link state, port power, port indicator state, "wake on" enable state
  */
 #define XHCI_PORT_RWS	((0xf<<5) | (1<<9) | (0x3<<14) | (0x7<<25))
-/*
- * These bits are RW; writing a 1 sets the bit, writing a 0 has no effect:
- * bit 4 (port reset)
- */
-#define	XHCI_PORT_RW1S	((1<<4))
-/*
- * These bits are RW; writing a 1 clears the bit, writing a 0 has no effect:
- * bits 1, 17, 18, 19, 20, 21, 22, 23
- * port enable/disable, and
- * change bits: connect, PED, warm port reset changed (reserved zero for USB 2.0 ports),
- * over-current, reset, link state, and L1 change
- */
-#define XHCI_PORT_RW1CS	((1<<1) | (0x7f<<17))
-/*
- * Bit 16 is RW, and writing a '1' to it causes the link state control to be
- * latched in

drivers/usb/host/xhci-hub.c static unsigned int xhci_port_speed(unsigned int port_status) · line 201

Quoted 10 lines
drivers/usb/host/xhci-hub.c +0 -7
- */
-#define	XHCI_PORT_RW	((1<<16))
-/*
- * These bits are Reserved Zero (RsvdZ) and zero should be written to them:
- * bits 2, 24, 28:31
- */
-#define	XHCI_PORT_RZ	((1<<2) | (1<<24) | (0xf<<28))
 
 /*
  * Given a port state, this function returns a value that would result in the

As I have stated numerous times in the past, please do not send any future Linux kernel changes, I will not be accepting them.

Mathias, please ignore.

greg k-h