HID: i2c-hid: Add hid-over-i2c name to i2c id table
PATCH 1/1 HID: i2c-hid: Add hid-over-i2c name to i2c id table
When using the device tree binding OF compatible = "hid-over-i2c" the i2c id table also needs to have that name in order to auto load this driver, since i2c core reports module alias as i2c:<string> where <string> is compatible string of OF binding stripped of manufacturer's prefix.
--- drivers/hid/i2c-hid/i2c-hid.c | 1 + 1 file changed, 1 insertion(+)
drivers/hid/i2c-hid/i2c-hid.c +1 -0
@@ -1191,6 +1191,7 @@ static const struct dev_pm_ops i2c_hid_pm = {static const struct i2c_device_id i2c_hid_id_table[] = { {"hid" ,0 }, + {"hid-over-i2c" ,0 }, { }, };MODULE_DEVICE_TABLE (i2c, i2c_hid_id_table);
Signature · 5 lines
2.7.0.rc3.207.g0ac5344 -- Dmitry
Quoted 8 lines · Dmitry Torokhov
When using the device tree binding OF compatible = "hid-over-i2c" the i2c id table also needs to have that name in order to auto load this driver, since i2c core reports module alias as i2c:<string> where <string> is compatible string of OF binding stripped of manufacturer's prefix.
Signed-off-by Benson Leung <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>
Quoted 26 lines
--- drivers/hid/i2c-hid/i2c-hid.c | 1 + 1 file changed, 1 insertion(+)drivers/hid/i2c-hid/i2c-hid.c +1
-1@@ -1191,6 +1191,7 @@ static const struct dev_pm_ops i2c_hid_pm = {static const struct i2c_device_id i2c_hid_id_table[] = { {"hid" ,0 }, + {"hid-over-i2c" ,0 }, { }, };MODULE_DEVICE_TABLE (i2c, i2c_hid_id_table); --2.7.0.rc3.207.g0ac5344
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines · Dmitry Torokhov
When using the device tree binding OF compatible = "hid-over-i2c" the i2c id table also needs to have that name in order to auto load this driver, since i2c core reports module alias as i2c:<string> where <string> is compatible string of OF binding stripped of manufacturer's prefix.
OK, so the story here is during the first submissions, I had something similar (i2c-hid or so). I was then told that it was not necessary to use "i2c" in the name given that it was an I2C driver already. But it looks like when I created the device tree binding, I forgot about it and messed around a little bit, again.
My apologies, and:
Would it make sense to remove the other name ("hid") which should have less compatibility issues (all the users *should* be in the kernel tree).
Cheers,
Benjamin
Quoted 25 lines
Signed-off-by Benson Leung <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>--- drivers/hid/i2c-hid/i2c-hid.c | 1 + 1 file changed, 1 insertion(+)drivers/hid/i2c-hid/i2c-hid.c +1
-0@@ -1191,6 +1191,7 @@ static const struct dev_pm_ops i2c_hid_pm = {static const struct i2c_device_id i2c_hid_id_table[] = { {"hid" ,0 }, + {"hid-over-i2c" ,0 }, { }, };MODULE_DEVICE_TABLE (i2c, i2c_hid_id_table);Signature · 5 lines
2.7.0.rc3.207.g0ac5344 -- Dmitry
Quoted 8 lines · Dmitry Torokhov
When using the device tree binding OF compatible = "hid-over-i2c" the i2c id table also needs to have that name in order to auto load this driver, since i2c core reports module alias as i2c:<string> where <string> is compatible string of OF binding stripped of manufacturer's prefix.
Signed-off-by Benson Leung <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs
Quoted 8 lines · Jiri Kosina
Quoted 6 lines · Dmitry Torokhov
When using the device tree binding OF compatible = "hid-over-i2c" the i2c id table also needs to have that name in order to auto load this driver, since i2c core reports module alias as i2c:<string> where <string> is compatible string of OF binding stripped of manufacturer's prefix.
Quoted 4 lines
Quoted 2 lines
Signed-off-by Benson Leung <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>Applied, thanks.
Crap, can you change author on this to "Benson Leung <[email protected]>" and on "HID: i2c-hid: Fix suspend/resume when already runtime suspended" to "Doug Anderson <[email protected]>"?
I need to fix my script...
Thanks.
Signature · 1 line
Dmitry
Jiri Kosina
maintainerQuoted 9 lines · Dmitry Torokhov
Quoted 9 lines
Quoted 8 lines
When using the device tree binding OF compatible = "hid-over-i2c" the i2c id table also needs to have that name in order to auto load this driver, since i2c core reports module alias as i2c:<string> where <string> is compatible string of OF binding stripped of manufacturer's prefix.
Signed-off-by Benson Leung <[email protected]>Signed-off-by Dmitry Torokhov <[email protected]>
Quoted 7 lines
Quoted 1 line
Applied, thanks.
Crap, can you change author on this to "Benson Leung <[email protected]>" and on "HID: i2c-hid: Fix suspend/resume when already runtime suspended" to "Doug Anderson <[email protected]>"?
I need to fix my script...
Alright, this is one of the rare ocasions where I believe that rebase of a public git tree is justifiable. I've just fixed the commits and pushed out the new branches.
Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs