Skip to contentSkip to conversation

drm/i915/bxt: add missing DSI power domain to power well 1

PATCH In review Jani Nikula 3 participants 4 messages Mar 8, 2016 – Mar 9, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/bxt: add missing DSI power domain to power well 1

The DSI power domain was missing from BXT power well 1 definitions, failing to get the power well for DSI transcoders. As pipe A is in the same power well as DSI transcoders, the problem should only occur with pipes B and C.

Cc Ramalingam C <[email protected]>
Cc Deepak M <[email protected]>

---

This should superseed [1], but a change will be required in haswell_get_pipe_config() or [2] to check the DSI power domain.

[1] http://patchwork.freedesktop.org/patch/msgid/[email protected]
[2] http://patchwork.freedesktop.org/patch/msgid/[email protected]

---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -0
index 5adf4b337de3..2e88a5e06884 100644
@@ -421,6 +421,7 @@ static void hsw_set_power_well(struct drm_i915_private *dev_priv,
 	BIT(POWER_DOMAIN_TRANSCODER_EDP) |		\
 	BIT(POWER_DOMAIN_PIPE_A_PANEL_FITTER) |		\
 	BIT(POWER_DOMAIN_PORT_DDI_A_LANES) |		\
+	BIT(POWER_DOMAIN_PORT_DSI) |			\
 	BIT(POWER_DOMAIN_AUX_A) |			\
 	BIT(POWER_DOMAIN_PLLS) |			\
 	BIT(POWER_DOMAIN_INIT))
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 1/1
#1 lore raw
Quoted 25 lines · Jani Nikula

The DSI power domain was missing from BXT power well 1 definitions, failing to get the power well for DSI transcoders. As pipe A is in the same power well as DSI transcoders, the problem should only occur with pipes B and C.

Cc Ramalingam C <[email protected]>
Cc Deepak M <[email protected]>

---

This should superseed [1], but a change will be required in haswell_get_pipe_config() or [2] to check the DSI power domain.

[1] http://patchwork.freedesktop.org/patch/msgid/[email protected]
[2] http://patchwork.freedesktop.org/patch/msgid/[email protected]

---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_runtime_pm.c +0 -0
index 5adf4b337de3..2e88a5e06884 100644

drivers/gpu/drm/i915/intel_runtime_pm.c static void hsw_set_power_well(struct drm_i915_private *dev_priv, · line 424

Quoted 4 lines
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -0
@@ -421,6 +421,7 @@ static void hsw_set_power_well(struct drm_i915_private *dev_priv,
 	BIT(POWER_DOMAIN_TRANSCODER_EDP) |		\
 	BIT(POWER_DOMAIN_PIPE_A_PANEL_FITTER) |		\
 	BIT(POWER_DOMAIN_PORT_DDI_A_LANES) |		\
+	BIT(POWER_DOMAIN_PORT_DSI) |			\

This is basically a nop since pw1 is under dmc control. But given that we still have this stuff defined here, it's clearly correct to include DSI here.

Quoted 5 lines
drivers/gpu/drm/i915/intel_runtime_pm.c +0 -0
 	BIT(POWER_DOMAIN_AUX_A) |			\
 	BIT(POWER_DOMAIN_PLLS) |			\
 	BIT(POWER_DOMAIN_INIT))
Signature · 1 line
2.1.4
Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
author Applied
#2 lore raw
Quoted 35 lines · Ville Syrjälä
Quoted 25 lines · Jani Nikula

The DSI power domain was missing from BXT power well 1 definitions, failing to get the power well for DSI transcoders. As pipe A is in the same power well as DSI transcoders, the problem should only occur with pipes B and C.

Cc Ramalingam C <[email protected]>
Cc Deepak M <[email protected]>

---

This should superseed [1], but a change will be required in haswell_get_pipe_config() or [2] to check the DSI power domain.

[1] http://patchwork.freedesktop.org/patch/msgid/[email protected]
[2] http://patchwork.freedesktop.org/patch/msgid/[email protected]

---
 drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_runtime_pm.c +0 -0
index 5adf4b337de3..2e88a5e06884 100644

drivers/gpu/drm/i915/intel_runtime_pm.c static void hsw_set_power_well(struct drm_i915_private *dev_priv, · line 424

Quoted 4 lines
drivers/gpu/drm/i915/intel_runtime_pm.c +1 -0
@@ -421,6 +421,7 @@ static void hsw_set_power_well(struct drm_i915_private *dev_priv,
 	BIT(POWER_DOMAIN_TRANSCODER_EDP) |		\
 	BIT(POWER_DOMAIN_PIPE_A_PANEL_FITTER) |		\
 	BIT(POWER_DOMAIN_PORT_DDI_A_LANES) |		\
+	BIT(POWER_DOMAIN_PORT_DSI) |			\

This is basically a nop since pw1 is under dmc control. But given that we still have this stuff defined here, it's clearly correct to include DSI here.

Quoted 1 line

Pushed to drm-intel-next-queued, thanks for the review.

None of the CI fails have anything to do with this.

BR,
Jani.

Quoted 6 lines
Quoted 6 lines
drivers/gpu/drm/i915/intel_runtime_pm.c +0 -0
 	BIT(POWER_DOMAIN_AUX_A) |			\
 	BIT(POWER_DOMAIN_PLLS) |			\
 	BIT(POWER_DOMAIN_INIT))
Signature · 1 line
2.1.4
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

✗ Fi.CI.BAT: failure for drm/i915/bxt: add missing DSI power domain to power well 1

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/bxt: add missing DSI power domain to power well 1
URL : https://patchwork.freedesktop.org/series/4223/
State : failure

== Summary ==

Series 4223v1 drm/i915/bxt: add missing DSI power domain to power well 1
http://patchwork.freedesktop.org/api/1.0/series/4223/revisions/1/mbox/

Test kms_flip:

        Subgroup basic-flip-vs-dpms:
                dmesg-warn -> PASS       (bdw-ultra)
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (hsw-brixbox)
Test kms_force_connector_basic:
        Subgroup force-edid:
                pass       -> SKIP       (ilk-hp8440p)
Test pm_rpm:
        Subgroup basic-rte:
                dmesg-warn -> PASS       (bsw-nuc-2)
bdw-nuci7        total:186  pass:174  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:186  pass:167  dwarn:0   dfail:0   fail:0   skip:19 
bsw-nuc-2        total:186  pass:151  dwarn:0   dfail:0   fail:0   skip:35 
byt-nuc          total:186  pass:154  dwarn:0   dfail:0   fail:0   skip:32 
hsw-brixbox      total:186  pass:165  dwarn:0   dfail:0   fail:1   skip:20 
ilk-hp8440p      total:186  pass:126  dwarn:0   dfail:0   fail:0   skip:60 
ivb-t430s        total:186  pass:164  dwarn:0   dfail:0   fail:0   skip:22 
skl-i5k-2        total:186  pass:165  dwarn:0   dfail:0   fail:0   skip:21 
skl-i7k-2        total:186  pass:165  dwarn:0   dfail:0   fail:0   skip:21 
snb-dellxps      total:186  pass:155  dwarn:1   dfail:0   fail:0   skip:30 

Results at /archive/results/CI_IGT_test/Patchwork_1544/

b519bbd9633eca6bc8e8e80588b48bcee447c330 drm-intel-nightly: 2016y-03m-08d-13h-00m-35s UTC integration manifest 5e8ff1d78ce62335b2709b3adec92015291b6ed6 drm/i915/bxt: add missing DSI power domain to power well 1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx