Skip to contentSkip to conversation

Set PGROOT dir owner to be "postgres".

PATCH New Alan Yaniger 4 participants 10 messages Mar 6, 2016 – May 23, 2016

lore
Share & tools
lore

Alan Yaniger

author
#0 lore raw

PATCH 1/2 Set PGROOT dir owner to be "postgres".

Without setting the owner of /var/lib/pgsql to the user "postgres", the postgres server fails to start on boot.

Signed-off-by Alan Yaniger <[email protected]>
---
 package/postgresql/postgresql.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/postgresql/postgresql.mk +4 -0
index 444c1b1..5906ce9 100644
@@ -17,6 +17,10 @@ POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \
 POSTGRESQL_AUTORECONF = YES
 POSTGRESQL_CONF_OPTS = --disable-rpath
 
+define POSTGRESQL_PERMISSIONS
+	/var/lib/pgsql d 755 postgres postgres - - - - -
+endef
+
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 # PostgreSQL does not build against uClibc with locales
 # enabled, due to an uClibc bug, see
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/2 Set PGROOT dir owner to be "postgres".

Without this
change, the postgres server fails to start on boot.

Signed-off-by Alan Yaniger <[email protected]>
---
 package/postgresql/postgresql.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/postgresql/postgresql.mk +4 -0
index 444c1b1..5906ce9 100644
@@ -17,6 +17,10 @@ POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \
 POSTGRESQL_AUTORECONF = YES
 POSTGRESQL_CONF_OPTS = --disable-rpath
 
+define POSTGRESQL_PERMISSIONS
+	/var/lib/pgsql d 755 postgres postgres - - - - -
+endef
+
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 # PostgreSQL does not build against uClibc with locales
 # enabled, due to an uClibc bug, see
Signature · 1 line
1.9.1
author
#2 lore raw

PATCH 2/2 docs: Fixed syntax error in makedev-syntax example.

In reply to Alan Yaniger

In the makedev syntax documentation, one of the examples lacks the "mode" value. This patch fixes that example.

Signed-off-by Alan Yaniger <[email protected]>
---
 docs/manual/makedev-syntax.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/manual/makedev-syntax.txt +1 -1
index 0bbc16e..e4dffc9 100644
@@ -44,7 +44,7 @@ this syntax, you will need to write:
 ----
 /usr/bin/foo f 755 0 0 - - - - -
 /usr/bin/bar f 755 root root - - - - -
-/data/buz f buz-user buz-group - - - - -
+/data/buz f 644 buz-user buz-group - - - - -
 ----
 
 Alternatively, if you want to change owner/permission of a directory
Signature · 1 line
1.9.1
#3 lore raw

PATCH 2/2 docs: Fixed syntax error in makedev-syntax example.

Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alan" == Alan Yaniger <[email protected]> writes:

In the makedev syntax documentation, one of the examples lacks the "mode" value. This patch fixes that example.

Signed-off-by Alan Yaniger <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
author
#4 lore raw

PATCH 2/2 docs: Fixed syntax error in makedev-syntax example. In the makedev syntax documentation, one of the examples lacks the "mode" value.

In reply to Alan Yaniger
Signed-off-by Alan Yaniger <[email protected]>
---
 docs/manual/makedev-syntax.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
docs/manual/makedev-syntax.txt +1 -1
index 0bbc16e..e4dffc9 100644
@@ -44,7 +44,7 @@ this syntax, you will need to write:
 ----
 /usr/bin/foo f 755 0 0 - - - - -
 /usr/bin/bar f 755 root root - - - - -
-/data/buz f buz-user buz-group - - - - -
+/data/buz f 644 buz-user buz-group - - - - -
 ----
 
 Alternatively, if you want to change owner/permission of a directory
Signature · 1 line
1.9.1
#5 lore raw

PATCH 1/2 Set PGROOT dir owner to be "postgres".

In reply to Alan Yaniger

Hi Alan,

Quoted 13 lines · Alan Yaniger

Without setting the owner of /var/lib/pgsql to the user "postgres", the postgres server fails to start on boot.

Signed-off-by Alan Yaniger <[email protected]>
---
 package/postgresql/postgresql.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/postgresql/postgresql.mk +0 -0
index 444c1b1..5906ce9 100644

package/postgresql/postgresql.mk POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \ · line 22

Quoted 6 lines
package/postgresql/postgresql.mk +3 -0
@@ -17,6 +17,10 @@ POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \
 POSTGRESQL_AUTORECONF = YES
 POSTGRESQL_CONF_OPTS = --disable-rpath
 
+define POSTGRESQL_PERMISSIONS
+	/var/lib/pgsql d 755 postgres postgres - - - - -
+endef

A better place for this IMO would be near POSTGRESQL_USERS below.

Thanks,
baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#6 lore raw

PATCH 1/2 Set PGROOT dir owner to be "postgres".

Hi Alan,

Quoted 17 lines · Baruch Siach
Quoted 16 lines · Alan Yaniger

Without setting the owner of /var/lib/pgsql to the user "postgres", the postgres server fails to start on boot.

Signed-off-by Alan Yaniger <[email protected]>
---
 package/postgresql/postgresql.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/postgresql/postgresql.mk +0 -0
index 444c1b1..5906ce9 100644
@@ -17,6 +17,10 @@ POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \
 POSTGRESQL_AUTORECONF = YES
 POSTGRESQL_CONF_OPTS = --disable-rpath
Quoted 5 lines

package/postgresql/postgresql.mk POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \ · line 22

Quoted 3 lines
package/postgresql/postgresql.mk +3 -0
+define POSTGRESQL_PERMISSIONS
+	/var/lib/pgsql d 755 postgres postgres - - - - -
+endef

A better place for this IMO would be near POSTGRESQL_USERS below.

One more comment that I forgot: patch subject line should not end with a full stop.

I believe that the maintainer applying these patches can fix those minor issues while applying, so unless someone else finds bigger issues with these patches you do not need to resend.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#7 lore raw

PATCH 1/2 Set PGROOT dir owner to be "postgres".

In reply to Baruch Siach

Hello,

Quoted 17 lines · Baruch Siach
Quoted 16 lines · Alan Yaniger

Without setting the owner of /var/lib/pgsql to the user "postgres", the postgres server fails to start on boot.

Signed-off-by Alan Yaniger <[email protected]>
---
 package/postgresql/postgresql.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/postgresql/postgresql.mk +0 -0
index 444c1b1..5906ce9 100644
@@ -17,6 +17,10 @@ POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \
 POSTGRESQL_AUTORECONF = YES
 POSTGRESQL_CONF_OPTS = --disable-rpath
Quoted 5 lines

package/postgresql/postgresql.mk POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \ · line 22

Quoted 3 lines
package/postgresql/postgresql.mk +3 -0
+define POSTGRESQL_PERMISSIONS
+	/var/lib/pgsql d 755 postgres postgres - - - - -
+endef

A better place for this IMO would be near POSTGRESQL_USERS below.

Well, there is already a POSTGRESQL_USERS:

define POSTGRESQL_USERS
postgres -1 postgres -1 * /var/lib/pgsql /bin/sh - PostgreSQL Server
endef

And this should already create /var/lib/pgsql, owned by the postgres:postgres user.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#8 lore raw

PATCH 1/2 Set PGROOT dir owner to be "postgres".

Hi Thomas,

I see what my error was. I installed the rootfs on my SSD by copying it from a partition on a USB-disk which I had mounted. Then I ran "cp" to copy from the mounted partition to the SSD, and I forgot to use the -p option to preserve attributes. When I installed after the "fix", I used "tar" to install, which preserved the ownership.

I changed the state of the patch to "Rejected" in Patchwork.

Alan

Quoted 43 lines · Thomas Petazzoni

Hello,

Quoted 17 lines · Baruch Siach
Quoted 16 lines · Alan Yaniger

Without setting the owner of /var/lib/pgsql to the user "postgres", the postgres server fails to start on boot.

Signed-off-by Alan Yaniger <[email protected]>
---
 package/postgresql/postgresql.mk | 4 ++++
 1 file changed, 4 insertions(+)
package/postgresql/postgresql.mk +0 -0
index 444c1b1..5906ce9 100644
@@ -17,6 +17,10 @@ POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \
 POSTGRESQL_AUTORECONF = YES
 POSTGRESQL_CONF_OPTS = --disable-rpath
Quoted 5 lines

package/postgresql/postgresql.mk POSTGRESQL_CONF_ENV = ac_cv_type_struct_sockaddr_in6=yes \ · line 22

Quoted 3 lines
package/postgresql/postgresql.mk +3 -0
+define POSTGRESQL_PERMISSIONS
+	/var/lib/pgsql d 755 postgres postgres - - - - -
+endef

A better place for this IMO would be near POSTGRESQL_USERS below.

Well, there is already a POSTGRESQL_USERS:

define POSTGRESQL_USERS
postgres -1 postgres -1 * /var/lib/pgsql /bin/sh - PostgreSQL Server
endef

And this should already create /var/lib/pgsql, owned by the postgres:postgres user.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Signature · 5 lines
Alan Yaniger
Tk Open Systems, Ltd
Telephone: 0546-841-481
Skype: alanyaniger
http://tkos.co.il
#9 lore raw

PATCH 1/2 Set PGROOT dir owner to be "postgres".

Alan,

Quoted 5 lines · Alan Yaniger

I see what my error was. I installed the rootfs on my SSD by copying it from a partition on a USB-disk which I had mounted. Then I ran "cp" to copy from the mounted partition to the SSD, and I forgot to use the -p option to preserve attributes. When I installed after the "fix", I used "tar" to install, which preserved the ownership.

OK.

Quoted 1 line

I changed the state of the patch to "Rejected" in Patchwork.

Thanks for following up and changing the state of your patch!

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com