Skip to contentSkip to conversation

putty: add new package

PATCH Superseded Alexander Dahl 3 participants 5 messages Mar 11, 2016 – Mar 12, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 putty: add new package

---
This is the first patch in a series trying to get packages upstream created for and used by fli4l [1], in some cases for a long time. I start with putty, because it got a security update this week anyway.

[1] http://www.fli4l.de/

 package/Config.in        |  1 +
 package/putty/Config.in  | 12 ++++++++++++
 package/putty/putty.hash |  5 +++++
 package/putty/putty.mk   | 22 ++++++++++++++++++++++
 4 files changed, 40 insertions(+)
 create mode 100644 package/putty/Config.in
 create mode 100644 package/putty/putty.hash
 create mode 100644 package/putty/putty.mk
package/Config.in +1 -0
index 35a24ba..2e00fbb 100644
@@ -1465,6 +1465,7 @@ endif
 	source "package/ptpd/Config.in"
 	source "package/ptpd2/Config.in"
 	source "package/pure-ftpd/Config.in"
+	source "package/putty/Config.in"
 	source "package/quagga/Config.in"
 	source "package/radvd/Config.in"
 	source "package/rp-pppoe/Config.in"
package/putty/Config.in new file +12 -0
new file mode 100644
index 0000000..5c18b2c
@@ -0,0 +1,12 @@
+config BR2_PACKAGE_PUTTY
+	bool "putty"
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_USE_WCHAR
+	help
+	  PuTTY is a free SSH and Telnet client
+
+	  http://www.chiark.greenend.org.uk/~sgtatham/putty/
+
+comment "putty needs a toolchain w/ wchar"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR
package/putty/putty.hash new file +5 -0
new file mode 100644
index 0000000..4b02acc
@@ -0,0 +1,5 @@
+# Hashes from: http://the.earth.li/~sgtatham/putty/0.67/{md5,sha1,sha256,sha512}sums
+md5 8d5d450e8f9a011e2e411e3f30827e9b                                                                                                    putty-0.67.tar.gz
+sha1 132ff74266e590a007f86cbb4bea5642db7bdd76                                                                                           putty-0.67.tar.gz
+sha256 80192458e8a46229de512afeca5c757dd8fce09606b3c992fbaeeee29b994a47                                                                 putty-0.67.tar.gz
+sha512 c2b17da46b8db3fe3837a10cb9cf5dd4b3ef6bfa15cadab83f3b87cf1479ed31fced90b774297ae53bdcbbdf230fc80d5c73d5ff3be6916fb591fd7ce3d35eca putty-0.67.tar.gz
package/putty/putty.mk new file +22 -0
new file mode 100644
index 0000000..ca86c47
@@ -0,0 +1,22 @@
+################################################################################
+#
+# putty
+#
+################################################################################
+
+PUTTY_VERSION = 0.67
+PUTTY_SOURCE = putty-$(PUTTY_VERSION).tar.gz
+PUTTY_SITE = http://the.earth.li/~sgtatham/putty/$(PUTTY_VERSION)
+PUTTY_SUBDIR = unix
+PUTTY_LICENSE = MIT
+PUTTY_LICENSE_FILES = LICENCE
+PUTTY_CONF_OPTS = --disable-gtktest
+
+ifeq ($(BR2_PACKAGE_LIBGTK2),y)
+PUTTY_CONF_OPTS += --with-gtk=2
+PUTTY_DEPENDENCIES += libgtk2
+else
+PUTTY_CONF_OPTS += --without-gtk
+endif
+
+$(eval $(autotools-package))
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 putty: add new package

Hi Alexander,

package/putty/Config.in line 8

Quoted 8 lines · Alexander Dahl
package/putty/Config.in new file +8 -0
+config BR2_PACKAGE_PUTTY
+	bool "putty"
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_USE_WCHAR
+	help
+	  PuTTY is a free SSH and Telnet client
+
+	  http://www.chiark.greenend.org.uk/~sgtatham/putty/

It might be useful to note here that the putty program itself depends on gtk2. Without gtk2, only command line utilities (pscp, plink, etc.) are built.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH 1/1 putty: add new package

Hei hei,

Quoted 8 lines · Baruch Siach

package/putty/Config.in line 8

Quoted 4 lines · Alexander Dahl
package/putty/Config.in new file +4 -0
+	help
+	  PuTTY is a free SSH and Telnet client
+
+	  http://www.chiark.greenend.org.uk/~sgtatham/putty/

It might be useful to note here that the putty program itself depends on gtk2. Without gtk2, only command line utilities (pscp, plink, etc.) are built.

You mean in the help text there? I know this is the case, but it might be a good idea to make it a little more explicit, yes.

Greets
Alex

Signature · 12 lines
?With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.? (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160311/56b1db34/attachment.asc>
#3 lore raw

PATCH 1/1 putty: add new package

Alexander, All,

On 2016-03-11 08:54 +0100, Alexander Dahl spake thusly:

Quoted 12 lines

Hei hei,

Quoted 8 lines · Baruch Siach

package/putty/Config.in line 8

Quoted 4 lines · Alexander Dahl
package/putty/Config.in new file +4 -0
+	help
+	  PuTTY is a free SSH and Telnet client
+
+	  http://www.chiark.greenend.org.uk/~sgtatham/putty/

It might be useful to note here that the putty program itself depends on gtk2. Without gtk2, only command line utilities (pscp, plink, etc.) are built.

Quoted 2 lines

You mean in the help text there? I know this is the case, but it might be a good idea to make it a little more explicit, yes.

Yes, in the help text. Something like:

help
PuTTY is a free SSH and Telnet client.

Without GTK2, onlt the command line utilities ar ebuilt; enable GTK2 for the graphical client.

http://www.chiark.greenend.org.uk/~sgtatham/putty/

Regards,
Yann E. MORIN.

Quoted 16 lines

Greets
Alex

Signature · 12 lines
?With the first link, the chain is forged. The first speech censured,
the first thought forbidden, the first freedom denied, chains us all
irrevocably.? (Jean-Luc Picard, quoting Judge Aaron Satie)
*** GnuPG-FP: 02C8 A590 7FE5 CA5F 3601  D1D5 8FBA 7744 CC87 10D0 ***




_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#4 lore raw

PATCH 1/1 putty: add new package

In reply to Alexander Dahl

Alexander, All,

On 2016-03-11 07:45 +0100, Alexander Dahl spake thusly:

Quoted 2 lines

---

[--SNIP--]

package/putty/putty.hash line 5

Quoted 11 lines
package/putty/putty.hash new file +5 -0
new file mode 100644
index 0000000..4b02acc
@@ -0,0 +1,5 @@
+# Hashes from: http://the.earth.li/~sgtatham/putty/0.67/{md5,sha1,sha256,sha512}sums
+md5 8d5d450e8f9a011e2e411e3f30827e9b                                                                                                    putty-0.67.tar.gz
+sha1 132ff74266e590a007f86cbb4bea5642db7bdd76                                                                                           putty-0.67.tar.gz
+sha256 80192458e8a46229de512afeca5c757dd8fce09606b3c992fbaeeee29b994a47                                                                 putty-0.67.tar.gz
+sha512 c2b17da46b8db3fe3837a10cb9cf5dd4b3ef6bfa15cadab83f3b87cf1479ed31fced90b774297ae53bdcbbdf230fc80d5c73d5ff3be6916fb591fd7ce3d35eca putty-0.67.tar.gz

sha256 and sha512 are two strong hashes, so md5 and sha1 are not needed.

Otherwise, looks good. When you fix the hashes and tweak the help text as mentionned in the other mail, you can add my:

    Reviewed-by: "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 35 lines
package/putty/putty.mk new file +22 -0
new file mode 100644
index 0000000..ca86c47
@@ -0,0 +1,22 @@
+################################################################################
+#
+# putty
+#
+################################################################################
+
+PUTTY_VERSION = 0.67
+PUTTY_SOURCE = putty-$(PUTTY_VERSION).tar.gz
+PUTTY_SITE = http://the.earth.li/~sgtatham/putty/$(PUTTY_VERSION)
+PUTTY_SUBDIR = unix
+PUTTY_LICENSE = MIT
+PUTTY_LICENSE_FILES = LICENCE
+PUTTY_CONF_OPTS = --disable-gtktest
+
+ifeq ($(BR2_PACKAGE_LIBGTK2),y)
+PUTTY_CONF_OPTS += --with-gtk=2
+PUTTY_DEPENDENCIES += libgtk2
+else
+PUTTY_CONF_OPTS += --without-gtk
+endif
+
+$(eval $(autotools-package))
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'