bfa: Brocade BFA FC SCSI driver
Hello Jing Huang,
The patch 7725ccfda597: "[SCSI] bfa: Brocade BFA FC SCSI driver" from Sep 23, 2009, leads to the following static checker warning:
drivers/scsi/bfa/bfa_fcs_fcpim.c:596 bfa_fcs_itnim_create() error: potentially using uninitialized 'itnim'.
drivers/scsi/bfa/bfa_fcs_fcpim.c
588 struct bfa_fcs_lport_s *port = rport->port;
589 struct bfa_fcs_itnim_s *itnim;
^^^^^
590 struct bfad_itnim_s *itnim_drv;
591
592 /*
593 * call bfad to allocate the itnim
594 */
595 bfa_fcb_itnim_alloc(port->fcs->bfad, &itnim, &itnim_drv);
^^^^^This function should probably return negative error codes on failure.
596 if (itnim == NULL) {
^^^^^^^^^^^^^
597 bfa_trc(port->fcs, rport->pwwn);
598 return NULL;
599 }regards,
dan carpenter