staging: android: binder: fixed line over 80 caracters

PATCH In review Juliana Rodrigues 2 participants 3 messages Mar 12, 2016 – Mar 13, 2016 Android drivers

lore

Share & tools

lore

Juliana Rodrigues

author

2016-03-12 23:40 UTC #0 lore raw

PATCH 1/1 staging: android: binder: fixed line over 80 caracters

This patch fixes the following warning caused by checkpatch.pl:

WARNING: line over 80 characters
+ if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {

Signed-off-by Juliana Rodrigues <[email protected]>

---
 drivers/android/binder.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

drivers/android/binder.c +3 -1

index 7d00b7a..94190fc 100644
@@ -2054,7 +2054,9 @@ static int binder_thread_write(struct binder_proc *proc,
 				ref->death = NULL;
 				if (list_empty(&death->work.entry)) {
 					death->work.type = BINDER_WORK_CLEAR_DEATH_NOTIFICATION;
-					if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
+					if (thread->looper & (
+						BINDER_LOOPER_STATE_REGISTERED |
+						BINDER_LOOPER_STATE_ENTERED)) {
 						list_add_tail(&death->work.entry, &thread->todo);
 					} else {
 						list_add_tail(&death->work.entry, &proc->todo);

Signature · 1 line

2.7.2

Greg KH

maintainer

2016-03-13 00:45 UTC #1 lore raw

Quoted 15 lines · Juliana Rodrigues

This patch fixes the following warning caused by checkpatch.pl:
WARNING: line over 80 characters
+ if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
Signed-off-by Juliana Rodrigues <[email protected]>
---
 drivers/android/binder.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/android/binder.c +0 -0
index 7d00b7a..94190fc 100644

drivers/android/binder.c static int binder_thread_write(struct binder_proc *proc, · line 2059

Quoted 7 lines

drivers/android/binder.c +3 -1

@@ -2054,7 +2054,9 @@ static int binder_thread_write(struct binder_proc *proc,
 				ref->death = NULL;
 				if (list_empty(&death->work.entry)) {
 					death->work.type = BINDER_WORK_CLEAR_DEATH_NOTIFICATION;
-					if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
+					if (thread->looper & (
+						BINDER_LOOPER_STATE_REGISTERED |
+						BINDER_LOOPER_STATE_ENTERED)) {

Please put the original ( on the second line, and don't use a full tab to indent, that just looks confusing now, don't you agree? Line it up under the first character in "thread->".

thanks,

greg k-h

Greg KH

maintainer

2016-03-13 00:45 UTC #2 lore raw

In reply to Juliana Rodrigues

Quoted 8 lines · Juliana Rodrigues

This patch fixes the following warning caused by checkpatch.pl:
WARNING: line over 80 characters
+ if (thread->looper & (BINDER_LOOPER_STATE_REGISTERED | BINDER_LOOPER_STATE_ENTERED)) {
Signed-off-by Juliana Rodrigues <[email protected]>
---
 drivers/android/binder.c | 4 +++-

Same comment here about not being in drivers/staging :(