Skip to contentSkip to conversation

staging: android: binder: fixed checkpatch warning

PATCH In review Juliana Rodrigues 2 participants 3 messages Mar 12, 2016 – Mar 13, 2016 Android drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: android: binder: fixed checkpatch warning

A comment was not properly formatted, causing warnings when running checkpatch.pl.

---
 drivers/android/binder.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/android/binder.c +6 -4
index 16288e7..9d109f7 100644
@@ -2741,8 +2741,9 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
 	unsigned int size = _IOC_SIZE(cmd);
 	void __user *ubuf = (void __user *)arg;
 
-	/*pr_info("binder_ioctl: %d:%d %x %lx\n",
-			proc->pid, current->pid, cmd, arg);*/
+	/* pr_info("binder_ioctl: %d:%d %x %lx\n",
+	 *		proc->pid, current->pid, cmd, arg);
+	 */
 
 	if (unlikely(current->mm != proc->vma_vm_mm)) {
 		pr_err("current mm mismatch proc mm\n");
@@ -2930,8 +2931,9 @@ static int binder_mmap(struct file *filp, struct vm_area_struct *vma)
 	proc->vma = vma;
 	proc->vma_vm_mm = vma->vm_mm;
 
-	/*pr_info("binder_mmap: %d %lx-%lx maps %p\n",
-		 proc->pid, vma->vm_start, vma->vm_end, proc->buffer);*/
+	/* pr_info("binder_mmap: %d %lx-%lx maps %p\n",
+	 *	 proc->pid, vma->vm_start, vma->vm_end, proc->buffer);
+	 */
 	return 0;
 
 err_alloc_small_buf_failed:
Signature · 1 line
2.7.2
maintainer
#1 lore raw
Quoted 5 lines · Juliana Rodrigues

A comment was not properly formatted, causing warnings when running checkpatch.pl.

---
 drivers/android/binder.c | 10 ++++++----

I can't take outreachy patches for anything outside of drivers/staging/ why are you making changes in drivers/android?

sorry,

greg k-h

#2 lore raw

oh sorry, i didnt know ):

Em sábado, 12 de março de 2016 21:45:24 UTC-3, gregkh escreveu:

Quoted 16 lines · Juliana Rodrigues
Quoted 1 line

A comment was not properly formatted, causing warnings when running

checkpatch.pl.

Quoted 4 lines
Signed-off-by Juliana Rodrigues <[email protected] <javascript:>>

---

 drivers/android/binder.c | 10 ++++++---- 

I can't take outreachy patches for anything outside of drivers/staging/ why are you making changes in drivers/android?

sorry,

greg k-h