staging: dgnc: fixed multiple blank lines
PATCH v2 1/1 staging: dgnc: fixed multiple blank lines
This patch removes multiple blank lines that caused checkpatch issues.
Signed-off-by Juliana Rodrigues <[email protected]>
---
Changes in v2:
- Removed file name from subject line.
drivers/staging/dgnc/dgnc_driver.h | 9 --------- 1 file changed, 9 deletions(-)
drivers/staging/dgnc/dgnc_driver.h +0 -9
@@ -88,7 +88,6 @@#define _POSIX_VDISABLE '\0'#endif -/* * All the possible states the driver can be while being loaded. */
@@ -106,7 +105,6 @@ enum { BOARD_READY }; -/************************************************************************* * * Structures and closely related defines.
@@ -145,7 +143,6 @@ struct board_ops {************************************************************************/ #define BD_IS_PCI_EXPRESS 0x0001/* Is a PCI Express board */ -/* * Per-board information */
@@ -241,7 +238,6 @@ struct dgnc_board { }; -/************************************************************************ * Unit flag definitions for un_flags. ************************************************************************/
@@ -277,7 +273,6 @@ struct un_t {struct device *un_sysfs; }; -/************************************************************************ * Device flag definitions for ch_flags. ************************************************************************/
@@ -300,7 +295,6 @@ struct un_t {#define CH_FORCED_STOP 0x20000/* Output is forcibly stopped */ #define CH_FORCED_STOPI 0x40000/* Input is forcibly stopped */ -/* Our Read/Error/Write queue sizes */ #define RQUEUEMASK 0x1FFF/* 8 K - 1 */ #define EQUEUEMASK 0x1FFF/* 8 K - 1 */
@@ -309,7 +303,6 @@ struct un_t {#define EQUEUESIZE RQUEUESIZE#define WQUEUESIZE (WQUEUEMASK + 1) -/************************************************************************ * Channel information structure. ************************************************************************/
@@ -397,7 +390,6 @@ struct channel_t {ulong ch_intr_tx;/* Count of interrupts */ ulong ch_intr_rx;/* Count of interrupts */ -/* /proc/<board>/<channel> entries */ struct proc_dir_entry *proc_entry_pointer;struct dgnc_proc_entry *dgnc_channel_table;
@@ -415,5 +407,4 @@ extern uint dgnc_NumBoards; /* Total number of boards */extern struct dgnc_board *dgnc_Board[MAXBOARDS ];/* Array of board * structs */ -#endif
Signature · 1 line
2.7.2
Quoted 2 lines · Juliana Rodrigues
This patch removes multiple blank lines that caused checkpatch issues.
Looks better, thanks. Still you can approach 80 characters for the commit message. You should be using an editor to write your commit messages that inserts a newline in the right place, so you don't have to think about this issue.
julia
Quoted 94 lines
Signed-off-by Juliana Rodrigues <[email protected]>---
Changes in v2:
- Removed file name from subject line.drivers/staging/dgnc/dgnc_driver.h | 9 --------- 1 file changed, 9 deletions(-)drivers/staging/dgnc/dgnc_driver.h +0
-9@@ -88,7 +88,6 @@#define _POSIX_VDISABLE '\0'#endif -/* * All the possible states the driver can be while being loaded. */ @@ -106,7 +105,6 @@ enum { BOARD_READY }; -/************************************************************************* * * Structures and closely related defines. @@ -145,7 +143,6 @@ struct board_ops {************************************************************************/ #define BD_IS_PCI_EXPRESS 0x0001/* Is a PCI Express board */ -/* * Per-board information */ @@ -241,7 +238,6 @@ struct dgnc_board { }; -/************************************************************************ * Unit flag definitions for un_flags. ************************************************************************/ @@ -277,7 +273,6 @@ struct un_t {struct device *un_sysfs; }; -/************************************************************************ * Device flag definitions for ch_flags. ************************************************************************/ @@ -300,7 +295,6 @@ struct un_t {#define CH_FORCED_STOP 0x20000/* Output is forcibly stopped */ #define CH_FORCED_STOPI 0x40000/* Input is forcibly stopped */ -/* Our Read/Error/Write queue sizes */ #define RQUEUEMASK 0x1FFF/* 8 K - 1 */ #define EQUEUEMASK 0x1FFF/* 8 K - 1 */ @@ -309,7 +303,6 @@ struct un_t {#define EQUEUESIZE RQUEUESIZE#define WQUEUESIZE (WQUEUEMASK + 1) -/************************************************************************ * Channel information structure. ************************************************************************/ @@ -397,7 +390,6 @@ struct channel_t {ulong ch_intr_tx;/* Count of interrupts */ ulong ch_intr_rx;/* Count of interrupts */ -/* /proc/<board>/<channel> entries */ struct proc_dir_entry *proc_entry_pointer;struct dgnc_proc_entry *dgnc_channel_table;@@ -415,5 +407,4 @@ extern uint dgnc_NumBoards; /* Total number of boards */extern struct dgnc_board *dgnc_Board[MAXBOARDS ];/* Array of board * structs */ -#endif Signature · 8 lines
2.7.2 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313040529.GA10236%40spock. For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 8 lines · Juliana Rodrigues
This patch removes multiple blank lines that caused checkpatch issues.
Signed-off-by Juliana Rodrigues <[email protected]>---
Changes in v2:
- Removed file name from subject line.
You have sent a lot of different patches for this same driver, some in series, some not. So I don't know what order to apply which in. Some also depend on other patches. I'm totally confused. Please resend all patches you have made for this driver, in one series, in the needed order as I've flushed all of your pending patches for this driver from my todo queue now.
thanks,
greg k-h