Skip to contentSkip to conversation

staging: dgnc: replaced udelay with usleep_range

PATCH In review Juliana Rodrigues 3 participants 3 messages Mar 13, 2016 – Mar 21, 2016 Staging

lore
Share & tools
lore

Juliana Rodrigues

author
#0 lore raw

PATCH v2 1/1 staging: dgnc: replaced udelay with usleep_range

This patch replaces udelay with usleep_range fixing a checkpatch.pl issue:

CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
+ udelay(10);

Signed-off-by Juliana Rodrigues <[email protected]>

---
Changes in v2:
- Fixed range timing

 drivers/staging/dgnc/dgnc_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +1 -1
index 51db98b..7e3cc48 100644
@@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
 	 * Presumably, this is a bug in this UART.
 	 */
 
-	usleep_range(10000, 11000);
+	usleep_range(10, 20);
 }
 
 static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)
Signature · 1 line
2.7.2
#1 lore raw
Quoted 19 lines · Juliana Rodrigues

This patch replaces udelay with usleep_range fixing a checkpatch.pl issue:

CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
+ udelay(10);

Signed-off-by Juliana Rodrigues <[email protected]>

---
Changes in v2:
- Fixed range timing

 drivers/staging/dgnc/dgnc_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +0 -0
index 51db98b..7e3cc48 100644

drivers/staging/dgnc/dgnc_cls.c static void cls_flush_uart_read(struct channel_t *ch) · line 959

Quoted 5 lines
drivers/staging/dgnc/dgnc_cls.c +1 -1
@@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
 	 * Presumably, this is a bug in this UART.
 	 */
 
-	usleep_range(10000, 11000);
+	usleep_range(10, 20);

It still doesn't say why you chose this value.

julia

Quoted 13 lines
drivers/staging/dgnc/dgnc_cls.c +0 -0
 }
 
 static void cls_copy_data_from_queue_to_uart(struct channel_t *ch)
Signature · 8 lines
2.7.2

-- 
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160313123337.GA10274%40spock.
For more options, visit https://groups.google.com/d/optout.
maintainer
#2 lore raw
In reply to Juliana Rodrigues
Quoted 19 lines · Juliana Rodrigues

This patch replaces udelay with usleep_range fixing a checkpatch.pl issue:

CHECK: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt
+ udelay(10);

Signed-off-by Juliana Rodrigues <[email protected]>

---
Changes in v2:
- Fixed range timing

 drivers/staging/dgnc/dgnc_cls.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/dgnc/dgnc_cls.c +0 -0
index 51db98b..7e3cc48 100644

drivers/staging/dgnc/dgnc_cls.c static void cls_flush_uart_read(struct channel_t *ch) · line 959

Quoted 5 lines
drivers/staging/dgnc/dgnc_cls.c +1 -1
@@ -956,7 +956,7 @@ static void cls_flush_uart_read(struct channel_t *ch)
 	 * Presumably, this is a bug in this UART.
 	 */
 
-	usleep_range(10000, 11000);
+	usleep_range(10, 20);

Your subject does not match this patch :(