Skip to contentSkip to conversation

slang: make install-static do install-pkgconfig

PATCH Superseded Max Filippov 4 participants 8 messages Mar 13, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Max Filippov

author
#0 lore raw

PATCH 1/1 slang: make install-static do install-pkgconfig

mc's configure can't find S-Lang because static S-Lang build doesn't install pkgconfig file into staging. Adding install-pkgconfig to install-static dependencies fixes that.

Fixes:
http://autobuild.buildroot.net/results/085194f18bc7db1e801d98e6620e3a75fd988cc5/

Signed-off-by Max Filippov <[email protected]>
---
 package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch +2 -1
index ee306a1..b0f8779 100644
@@ -39,7 +39,8 @@ diff -rup a/autoconf/Makefile.in b/autoconf/Makefile.in
  	cd slsh; $(MAKE) all
 @@ -73,10 +76,11 @@ clean:
  	cd demo; $(MAKE) clean
- install-static:
+-install-static:
++install-static: install-pkgconfig
  	cd src; $(MAKE) install-static
 +	cd slsh; $(MAKE) install-static
  install-pkgconfig: slang.pc
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 slang: make install-static do install-pkgconfig

package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch

Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Max" == Max Filippov <[email protected]> writes:

mc's configure can't find S-Lang because static S-Lang build doesn't install pkgconfig file into staging. Adding install-pkgconfig to install-static dependencies fixes that.

Fixes:
http://autobuild.buildroot.net/results/085194f18bc7db1e801d98e6620e3a75fd988cc5/

Signed-off-by Max Filippov <[email protected]>
---
 package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch +0 -0
index ee306a1..b0f8779 100644

Patch description and signed-off-by missing. Alternatively we can drop the patch and just pass install-pkgconfig to the 'make install' step as we already need to use a custom make target anyway.

Quoted 19 lines
package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch +2 -1
@@ -39,7 +39,8 @@ diff -rup a/autoconf/Makefile.in b/autoconf/Makefile.in
  	cd slsh; $(MAKE) all
 @@ -73,10 +76,11 @@ clean:
  	cd demo; $(MAKE) clean
- install-static:
+-install-static:
++install-static: install-pkgconfig
  	cd src; $(MAKE) install-static
 +	cd slsh; $(MAKE) install-static
  install-pkgconfig: slang.pc
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 slang: make install-static do install-pkgconfig

Peter,

Quoted 3 lines · Peter Korsgaard

Patch description and signed-off-by missing. Alternatively we can drop the patch and just pass install-pkgconfig to the 'make install' step as we already need to use a custom make target anyway.

This is *exactly* what Max was doing in its first iteration of the patch, to which Yann replied:

"""
Could you instead fix the 0002-Enable-a-statically-linked-version-of-slsh patch to have install-static also depend on install-pkgconfig, please? """

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#3 lore raw

PATCH 1/1 slang: make install-static do install-pkgconfig

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Peter,

Quoted 3 lines · Peter Korsgaard

Patch description and signed-off-by missing. Alternatively we can drop the patch and just pass install-pkgconfig to the 'make install' step as we already need to use a custom make target anyway.

Quoted 8 lines

This is *exactly* what Max was doing in its first iteration of the patch, to which Yann replied:

"""
Could you instead fix the 0002-Enable-a-statically-linked-version-of-slsh patch to have install-static also depend on install-pkgconfig, please? """

Ok, I missed that mail.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard
#4 lore raw

PATCH 1/1 slang: make install-static do install-pkgconfig

In reply to Peter Korsgaard

Peter, All,

On 2016-03-13 21:14 +0100, Peter Korsgaard spake thusly:

Quoted 14 lines
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Max" == Max Filippov <[email protected]> writes:

mc's configure can't find S-Lang because static S-Lang build doesn't install pkgconfig file into staging. Adding install-pkgconfig to install-static dependencies fixes that.

Fixes:
http://autobuild.buildroot.net/results/085194f18bc7db1e801d98e6620e3a75fd988cc5/

Signed-off-by Max Filippov <[email protected]>
---
 package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Quoted 6 lines

package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch

Quoted 2 lines
package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch +0 -0
index ee306a1..b0f8779 100644

Patch description and signed-off-by missing. Alternatively we can drop the patch and just pass install-pkgconfig to the 'make install' step as we already need to use a custom make target anyway.

That's what Max did in his first patch, and I asked him to do it in our patch.
The .pc file is not installed for static-only because *we* added a patch that breaks down install into install-staging and install-shared.

So it makes more sense to fix our own patch, that work around deficiencies we added.

Plus, it makes for a patch that can be more easily upstremable.

Regards,
Yann E. MORIN.

Quoted 23 lines
Quoted 19 lines
package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch +2 -1
@@ -39,7 +39,8 @@ diff -rup a/autoconf/Makefile.in b/autoconf/Makefile.in
  	cd slsh; $(MAKE) all
 @@ -73,10 +76,11 @@ clean:
  	cd demo; $(MAKE) clean
- install-static:
+-install-static:
++install-static: install-pkgconfig
  	cd src; $(MAKE) install-static
 +	cd slsh; $(MAKE) install-static
  install-pkgconfig: slang.pc
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 1 line
Bye, Peter Korsgaard
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#5 lore raw

PATCH 1/1 slang: make install-static do install-pkgconfig

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 8 lines
Quoted 3 lines

Patch description and signed-off-by missing. Alternatively we can drop the patch and just pass install-pkgconfig to the 'make install' step as we already need to use a custom make target anyway.

That's what Max did in his first patch, and I asked him to do it in our patch.
The .pc file is not installed for static-only because *we* added a patch that breaks down install into install-staging and install-shared.

But that patch is an upstream patch:

Repository: git://git.jedsoft.org/git/slang.git
Commit ID: 3796db6fb94a2fc7fe2fb0b6918501b69a4d3a02
Author: John E. Davis <[email protected]>

So just changing what the patch does without updating the comment is imho not the right way to go. We should instead add a 0003 patch and send it upstream.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard
#6 lore raw

PATCH 1/1 slang: make install-static do install-pkgconfig

Peter, All,

On 2016-03-13 21:44 +0100, Peter Korsgaard spake thusly:

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

Hi,

Quoted 8 lines
Quoted 3 lines

Patch description and signed-off-by missing. Alternatively we can drop the patch and just pass install-pkgconfig to the 'make install' step as we already need to use a custom make target anyway.

That's what Max did in his first patch, and I asked him to do it in our patch.
The .pc file is not installed for static-only because *we* added a patch that breaks down install into install-staging and install-shared.

Quoted 5 lines

But that patch is an upstream patch:

Repository: git://git.jedsoft.org/git/slang.git
Commit ID: 3796db6fb94a2fc7fe2fb0b6918501b69a4d3a02
Author: John E. Davis <[email protected]>

Oh...

Quoted 3 lines

So just changing what the patch does without updating the comment is imho not the right way to go. We should instead add a 0003 patch and send it upstream.

Definitely.

Thanks! :-)

Regards,
Yann E. MORIN.

Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#7 lore raw

PATCH 1/1 slang: make install-static do install-pkgconfig

In reply to Max Filippov

Max, All,

On 2016-03-13 06:06 +0300, Max Filippov spake thusly:

Quoted 8 lines

mc's configure can't find S-Lang because static S-Lang build doesn't install pkgconfig file into staging. Adding install-pkgconfig to install-static dependencies fixes that.

Fixes:
http://autobuild.buildroot.net/results/085194f18bc7db1e801d98e6620e3a75fd988cc5/

Signed-off-by Max Filippov <[email protected]>
Acked-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 21 lines
---
 package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/slang/0002-Enable-a-statically-linked-version-of-slsh.patch +2 -1
index ee306a1..b0f8779 100644
@@ -39,7 +39,8 @@ diff -rup a/autoconf/Makefile.in b/autoconf/Makefile.in
  	cd slsh; $(MAKE) all
 @@ -73,10 +76,11 @@ clean:
  	cd demo; $(MAKE) clean
- install-static:
+-install-static:
++install-static: install-pkgconfig
  	cd src; $(MAKE) install-static
 +	cd slsh; $(MAKE) install-static
  install-pkgconfig: slang.pc
Signature · 1 line
2.1.4
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'