Skip to contentSkip to conversation

staging: iio: meter: remove fixme comment on device remove

PATCH In review Alison Schofield 2 participants 2 messages Mar 14, 2016

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: iio: meter: remove fixme comment on device remove

This comment was in place in the original drafts of these drivers when the remove function did a whole lot of work: flushed queues, unregistered interrupts, uninitialized rings, unconfigured rings, and a few kfree's.

The remove functions have since been reduced to unregistering and stopping the device. This is the inverse of what was done during probe and is correct. Time to remove the comment.

---
 drivers/staging/iio/meter/ade7753.c | 1 -
 drivers/staging/iio/meter/ade7754.c | 1 -
 drivers/staging/iio/meter/ade7759.c | 1 -
 3 files changed, 3 deletions(-)
drivers/staging/iio/meter/ade7753.c +0 -1
index 6928710..b0bc99a 100644
@@ -528,7 +528,6 @@ static int ade7753_probe(struct spi_device *spi)
 	return iio_device_register(indio_dev);
 }
 
-/* fixme, confirm ordering in this function */
 static int ade7753_remove(struct spi_device *spi)
 {
 	struct iio_dev *indio_dev = spi_get_drvdata(spi);
drivers/staging/iio/meter/ade7754.c +0 -1
index f4188e1..fed1180 100644
@@ -558,7 +558,6 @@ powerdown_on_error:
 	return ret;
 }
 
-/* fixme, confirm ordering in this function */
 static int ade7754_remove(struct spi_device *spi)
 {
 	struct iio_dev *indio_dev = spi_get_drvdata(spi);
drivers/staging/iio/meter/ade7759.c +0 -1
index 684e612..c14892d 100644
@@ -476,7 +476,6 @@ static int ade7759_probe(struct spi_device *spi)
 	return iio_device_register(indio_dev);
 }
 
-/* fixme, confirm ordering in this function */
 static int ade7759_remove(struct spi_device *spi)
 {
 	struct iio_dev *indio_dev = spi_get_drvdata(spi);
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Alison Schofield

This comment was in place in the original drafts of these drivers when the remove function did a whole lot of work: flushed queues, unregistered interrupts, uninitialized rings, unconfigured rings, and a few kfree's.

The remove functions have since been reduced to unregistering and stopping the device. This is the inverse of what was done during probe and is correct. Time to remove the comment.

Quoted 51 lines
---
 drivers/staging/iio/meter/ade7753.c | 1 -
 drivers/staging/iio/meter/ade7754.c | 1 -
 drivers/staging/iio/meter/ade7759.c | 1 -
 3 files changed, 3 deletions(-)
drivers/staging/iio/meter/ade7753.c +0 -1
index 6928710..b0bc99a 100644
@@ -528,7 +528,6 @@ static int ade7753_probe(struct spi_device *spi)
        return iio_device_register(indio_dev);
 }
 
-/* fixme, confirm ordering in this function */
 static int ade7753_remove(struct spi_device *spi)
 {
        struct iio_dev *indio_dev = spi_get_drvdata(spi);
drivers/staging/iio/meter/ade7754.c +0 -1
index f4188e1..fed1180 100644
@@ -558,7 +558,6 @@ powerdown_on_error:
        return ret;
 }
 
-/* fixme, confirm ordering in this function */
 static int ade7754_remove(struct spi_device *spi)
 {
        struct iio_dev *indio_dev = spi_get_drvdata(spi);
drivers/staging/iio/meter/ade7759.c +0 -2
index 684e612..c14892d 100644
@@ -476,7 +476,6 @@ static int ade7759_probe(struct spi_device *spi)
        return iio_device_register(indio_dev);
 }
 
-/* fixme, confirm ordering in this function */
 static int ade7759_remove(struct spi_device *spi)
 {
        struct iio_dev *indio_dev = spi_get_drvdata(spi);
--

2.1.4

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160314061120.GA6620%40d830.WORKGROUP.
For more options, visit https://groups.google.com/d/optout.