Skip to contentSkip to conversation

Input: synaptics-rmi4 - using logical instead of bitwise AND

PATCH Applied Dan Carpenter 4 participants 6 messages Mar 15, 2016

Subsystems (3)
Kernel janitors HID Input drivers
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 Input: synaptics-rmi4 - using logical instead of bitwise AND

There is a typo so we have && instead of &.

Fixes ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
Signed-off-by Dan Carpenter <[email protected]>
drivers/input/rmi4/rmi_f11.c +1 -0
index 77a5eb8..ec8a10d 100644
@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
 	sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
 	sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
 	sensor_query->has_sensitivity_adjust -		!!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
+		!!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
 	sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
 
 	sensor_query->nr_x_electrodes @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,

sensor_query->has_bending_correction !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
sensor_query->has_large_object_suppression - !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
+ !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
sensor_query->has_jitter_filter !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
query_size++;

#1 lore raw

drivers/input/rmi4/rmi_f11.c

Quoted 6 lines · Dan Carpenter

There is a typo so we have && instead of &.

Fixes ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
Signed-off-by Dan Carpenter <[email protected]>
drivers/input/rmi4/rmi_f11.c +0 -0

[]

Quoted 11 lines
drivers/input/rmi4/rmi_f11.c +1 -0
@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
  	sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
  	sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
  	sensor_query->has_sensitivity_adjust > -		!!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
+		!!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
  	sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);


  sensor_query->nr_x_electrodes > @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
  sensor_query->has_bending_correction >   !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
  sensor_query->has_large_object_suppression > - !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);

drivers/input/rmi4/rmi_f11.c +1 -0
+			!!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
Quoted 2 lines

  sensor_query->has_jitter_filter >   !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
  query_size++;

Right and as well these are bool so the !! isn't necessary.
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw
Quoted 1 line · Joe Perches

Right and as well these are bool so the !! isn't necessary.

Not necessary but nice for reading...

regards,
dan carpenter

#3 lore raw
Quoted 4 lines · Dan Carpenter
Quoted 2 lines · Joe Perches

Right and as well these are bool so the !! isn't necessary.

Not necessary but nice for reading...

<shrug> opinions vary.

cheers, Joe

Acked-by on v1 1/1
#4 lore raw
In reply to Dan Carpenter
Quoted 4 lines · Dan Carpenter

There is a typo so we have && instead of &.

Fixes ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Andrew Duggan <[email protected]>
Quoted 17 lines
drivers/input/rmi4/rmi_f11.c +2 -0
index 77a5eb8..ec8a10d 100644
@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
  	sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
  	sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
  	sensor_query->has_sensitivity_adjust > -		!!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
+		!!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
  	sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
 
  	sensor_query->nr_x_electrodes > @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
  		sensor_query->has_bending_correction >   			!!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
  		sensor_query->has_large_object_suppression > -		!!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
+			!!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
  		sensor_query->has_jitter_filter >   			!!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
  		query_size++;
maintainer Applied
#5 lore raw
Quoted 7 lines · Andrew Duggan
Quoted 4 lines · Dan Carpenter

There is a typo so we have && instead of &.

Fixes ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sensors and F11')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Andrew Duggan <[email protected]>

Applied, thank you.

Quoted 18 lines
Quoted 17 lines
drivers/input/rmi4/rmi_f11.c +2 -0
index 77a5eb8..ec8a10d 100644
@@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
 	sensor_query->has_abs = !!(query_buf[0] & RMI_F11_HAS_ABS);
 	sensor_query->has_gestures = !!(query_buf[0] & RMI_F11_HAS_GESTURES);
 	sensor_query->has_sensitivity_adjust > >-		!!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ);
+		!!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ);
 	sensor_query->configurable = !!(query_buf[0] & RMI_F11_CONFIGURABLE);
 	sensor_query->nr_x_electrodes > >@@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rmi_device *rmi_dev,
 		sensor_query->has_bending_correction > >  			!!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION);
 		sensor_query->has_large_object_suppression > >-		!!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
+			!!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION);
 		sensor_query->has_jitter_filter > >  			!!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER);
 		query_size++;
Signature · 1 line
Dmitry