Skip to contentSkip to conversation

mediatek: unlock on error in mtk_tx_map()

PATCH Applied Dan Carpenter 3 participants 3 messages Mar 15, 2016 – Mar 18, 2016

Subsystems (5)
Networking Network drivers Kernel janitors Arm MediaTek +1 more subsystems
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 2/2 mediatek: unlock on error in mtk_tx_map()

There was a missing unlock on the error path.

Fixes 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/mediatek/mtk_eth_soc.c +2 -0
index 9759fe5..c2c2e206 100644
@@ -661,6 +661,8 @@ err_dma:
 		itxd = mtk_qdma_phys_to_virt(ring, itxd->txd2);
 	} while (itxd != txd);
 
+	spin_unlock_irqrestore(&eth->page_lock, flags);
+
 	return -ENOMEM;
 }
Acked-by on v1 2/2
#1 lore raw
Quoted 5 lines · Dan Carpenter

There was a missing unlock on the error path.

Fixes 656e705243fd ('net-next: mediatek: add support for MT7623 ethernet')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by John Crispin <[email protected]>

Thanks !

Quoted 19 lines
drivers/net/ethernet/mediatek/mtk_eth_soc.c +2 -0
index 9759fe5..c2c2e206 100644
@@ -661,6 +661,8 @@ err_dma:
 		itxd = mtk_qdma_phys_to_virt(ring, itxd->txd2);
 	} while (itxd != txd);
 
+	spin_unlock_irqrestore(&eth->page_lock, flags);
+
 	return -ENOMEM;
 }

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek