linux: Build and install kernel selftests
PATCH v2 1/1 linux: Build and install kernel selftests
This patch simply adds the ability to compile and install the kernel selftests into the target at /usr/lib/kselftests. The rationale behind /usr/lib is that the selftests have subdirectories where they are installed which makes them unsuitable to be placed in /usr/sbin as this would result in /usr/sbin/kselftests/x/y/z. While the selftests aren't libraries either, they don't achieve much as a standalone binary so they can be considered to be a 'library of tests' making /usr/lib sensible.
The selftests require that the kernel headers be installed into the kernel build tree as some of the selftests have a hardcoded CFLAGS to include kernel headers (CFLAGS += -I../../../../usr/include/). This is most easily achieved by using the make ... headers_install inside the kernel build dir.
This is likely to be a rarely used debugging/performance feature for development and unlikely to be used in a production configuration.
---
V2: Address review by Yann E. Morin.
Fixup dependences in the Config.in
Comment the need to use the kernel headers_install target Place tests in /usr/lib/kselftests in target Remove installing into staging
--- linux/Config.tools.in | 18 ++++++++++++++++++ linux/linux-tool-selftests.mk | 42 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 60 insertions(+) create mode 100644 linux/linux-tool-selftests.mk
linux/Config.tools.in +18 -0
@@ -26,4 +26,22 @@ config BR2_LINUX_KERNEL_TOOL_PERF https://perf.wiki.kernel.org/ +config BR2_LINUX_KERNEL_TOOL_SELFTESTS + bool"selftests" + depends on BR2_PACKAGE_BUSYBOX_SHOW_OTHERS # bash + depends on BR2_USE_MMU # bash + select BR2_PACKAGE_BASH + help + Build and install (to /usr/lib/kselftests) kernel selftests. + + Use of this option implies you know the process using and compiling + the kernel selftests. The Makefile to build and install these is very + noisy and may appear to cause your build to fail for strange reasons. + + This is very much a use at your risk option and may not work for + every setup or every architecture. + +comment "selftests needs BR2_PACKAGE_BUSYBOX_SHOW_OTHERS" + depends on !BR2_PACKAGE_BUSYBOX_SHOW_OTHERS + endmenu
linux/linux-tool-selftests.mk new file +42 -0
42 lines not on this page · raw message
Signature · 1 line
2.6.4
PATCH v2 1/1 linux: Build and install kernel selftests
Cyril, All,
On 2016-01-04 11:59 +1100, Cyril Bur spake thusly:
Quoted 8 lines
This patch simply adds the ability to compile and install the kernel selftests into the target at
/usr/lib/kselftests. The rationale behind/usr/libis that the selftests have subdirectories where they are installed which makes them unsuitable to be placed in/usr/sbinas this would result in/usr/sbin/kselftests/x/y/z. While the selftests aren't libraries either, they don't achieve much as a standalone binary so they can be considered to be a 'library of tests' making/usr/libsensible.
Quoted 7 lines
The selftests require that the kernel headers be installed into the kernel build tree as some of the selftests have a hardcoded CFLAGS to include kernel headers (CFLAGS += -I../../../../usr/include/). This is most easily achieved by using the make ...
headers_installinside the kernel build dir.This is likely to be a rarely used debugging/performance feature for development and unlikely to be used in a production configuration.
So I finally take some time to review this new iteration; sorry for the delay... :-/
Quoted 2 lines
Signed-off-by Cyril Bur <[email protected]>---
[--SNIP--]
Quoted 6 lines
linux/linux-tool-selftests.mk new file +0
-0
linux/linux-tool-selftests.mk line 9
Quoted 9 lines
linux/linux-tool-selftests.mk new file +9
-0@@ -0,0 +1,42 @@ +################################################################################ +# +# selftests +# +################################################################################ + +LINUX_TOOLS += selftests + +ifeq ($(KERNEL_ARCH),x86_64)
For i386, Buildroot sets KERNEL_ARCH=i386, so we may also want to handle that case, no?
linux/linux-tool-selftests.mk line 10
Quoted 1 line
linux/linux-tool-selftests.mk new file +1
-0+SELFTESTS_ARCH=x86
I know the other linux-tools don't, but I think we should call that linux-selftests (so LINUX_SEFLTESTS_ARCH and so on) to avoid name clashing with other packages.
linux/linux-tool-selftests.mk line 15
Quoted 5 lines
linux/linux-tool-selftests.mk new file +5
-0+else +SELFTESTS_ARCH=$(KERNEL_ARCH) +endif + +SELFTESTS_DEPENDENCIES = bash
It can also use libcap-ng, so you probably want to depend on it, too:
/home/ymorin/dev/buildroot/O/host/usr/bin/i686-pc-linux-gnu-gcc -O2 -g
-std=gnu99 -Wall validate_cap.c -lcap-ng -lrt -ldl -o validate_cap
validate_cap.c:1:20: fatal error: cap-ng.h: No such file or directory
Ditto popt:
/home/ymorin/dev/buildroot/O/host/opt/ext-toolchain/bin/../lib/gcc/ i686-pc-linux-gnu/4.7.2/../../../../i686-pc-linux-gnu/bin/ld: cannot find -lpopt
collect2: error: ld returned 1 exit status
However, as you said in the commit log, those are not fatal errors (although reported as such) and the build goes on successfully for the rest of the tests:
Regards,
Yann E. MORIN.
Quoted 29 lines
linux/linux-tool-selftests.mk new file +26
-0+SELFTESTS_MAKE_FLAGS = \ + $(LINUX_MAKE_FLAGS) \ + ARCH=$(SELFTESTS_ARCH) + +# O must be redefined here to overwrite the one used by Buildroot for +# out of tree build. We build the selftests in $(@D)/tools/selftests and +# not just $(@D) so that it isn't built in the root directory of the kernel +# sources. +# +# The headers_install step here is important as some kernel selftests use a +# hardcoded CFLAGS to find kernel headers e.g: +# CFLAGS += -I../../../../usr/include/ +# The headers_install target will install the kernel headers locally inside +# the Linux build dir +define SELFTESTS_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE1) -C $(@D) $(SELFTESTS_MAKE_FLAGS) \ + headers_install + $(TARGET_MAKE_ENV) $(MAKE1) -C $(@D)/tools/testing/selftests \ + $(SELFTESTS_MAKE_FLAGS) O=$(@D)/tools/testing/selftests +endef + +define SELFTESTS_INSTALL_TARGET_CMDS + $(TARGET_MAKE_ENV) $(MAKE1) -C $(@D)/tools/testing/selftests \ + $(SELFTESTS_MAKE_FLAGS) O=$(@D)/tools/testing/selftests \ + INSTALL_PATH=$(TARGET_DIR)/usr/lib/kselftests install +endefSignature · 1 line
2.6.4
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 linux: Build and install kernel selftests
Quoted 16 lines · On Tue, 15 Mar 2016 10:24:13 +0100 "Yann E. MORIN" <[email protected]>…
Cyril, All,
On 2016-01-04 11:59 +1100, Cyril Bur spake thusly:
Quoted 13 lines
This patch simply adds the ability to compile and install the kernel selftests into the target at
/usr/lib/kselftests. The rationale behind/usr/libis that the selftests have subdirectories where they are installed which makes them unsuitable to be placed in/usr/sbinas this would result in/usr/sbin/kselftests/x/y/z. While the selftests aren't libraries either, they don't achieve much as a standalone binary so they can be considered to be a 'library of tests' making/usr/libsensible.The selftests require that the kernel headers be installed into the kernel build tree as some of the selftests have a hardcoded CFLAGS to include kernel headers (CFLAGS += -I../../../../usr/include/). This is most easily achieved by using the make ...
headers_installinside the kernel build dir.
Quoted 5 lines
Quoted 2 lines
This is likely to be a rarely used debugging/performance feature for development and unlikely to be used in a production configuration.
So I finally take some time to review this new iteration; sorry for the delay... :-/
Hi Yann,
No worries, thanks for taking the time.
Quoted 14 lines
Quoted 3 lines
Signed-off-by Cyril Bur <[email protected]>---
[--SNIP--]
Quoted 10 lines
linux/linux-tool-selftests.mk new file +4
-0@@ -0,0 +1,42 @@ +################################################################################ +# +# selftests +#
Quoted 9 lines
linux/linux-tool-selftests.mk line 9
Quoted 5 lines
linux/linux-tool-selftests.mk new file +5
-0+################################################################################ + +LINUX_TOOLS += selftests + +ifeq ($(KERNEL_ARCH),x86_64)For i386, Buildroot sets KERNEL_ARCH=i386, so we may also want to handle that case, no?
I think you're right but not super sure... I'll leave it up to an x86 boffin to confirm that it's the correct thing to do :)
Quoted 5 lines
linux/linux-tool-selftests.mk line 10
Quoted 1 line
linux/linux-tool-selftests.mk new file +1
-0+SELFTESTS_ARCH=x86I know the other linux-tools don't, but I think we should call that linux-selftests (so
LINUX_SEFLTESTS_ARCHand so on) to avoid name clashing with other packages.
Yeah that's a good idea.
Quoted 13 lines
linux/linux-tool-selftests.mk line 15
Quoted 6 lines
linux/linux-tool-selftests.mk new file +5
-0+else +SELFTESTS_ARCH=$(KERNEL_ARCH) +endif + +SELFTESTS_DEPENDENCIES = bashIt can also use libcap-ng, so you probably want to depend on it, too:
/home/ymorin/dev/buildroot/O/host/usr/bin/i686-pc-linux-gnu-gcc-O2 -g
-std=gnu99 -Wallvalidate_cap.c-lcap-ng -lrt -ldl -ovalidate_cap
validate_cap.c:1:20: fatal error:cap-ng.h: No such file or directory
Quoted 7 lines
Ditto popt:
/home/ymorin/dev/buildroot/O/host/opt/ext-toolchain/bin/../lib/gcc/i686-pc-linux-gnu/4.7.2/../../../../i686-pc-linux-gnu/bin/ld: cannot find -lpopt
collect2: error: ld returned 1 exit status
I could add those dependencies I suppose, it would be nicer for everyone.
Quoted 6 lines
However, as you said in the commit log, those are not fatal errors (although reported as such) and the build goes on successfully for the rest of the tests:
Reviewed-by "Yann E. MORIN" <[email protected]>Tested-by "Yann E. MORIN" <[email protected]>
Are you happy for me to do a v3 based on your comments and leave both the Reviewed-by and Tested-by tags?
Also, for what its worth, I've built and used it a lot for powerpc.
Thanks again,
Cyril
Quoted 35 lines
[build-tested only, for i386]
Regards,
Yann E. MORIN.Quoted 29 lines
linux/linux-tool-selftests.mk new file +26
-0+SELFTESTS_MAKE_FLAGS = \ + $(LINUX_MAKE_FLAGS) \ + ARCH=$(SELFTESTS_ARCH) + +# O must be redefined here to overwrite the one used by Buildroot for +# out of tree build. We build the selftests in $(@D)/tools/selftests and +# not just $(@D) so that it isn't built in the root directory of the kernel +# sources. +# +# The headers_install step here is important as some kernel selftests use a +# hardcoded CFLAGS to find kernel headers e.g: +# CFLAGS += -I../../../../usr/include/ +# The headers_install target will install the kernel headers locally inside +# the Linux build dir +define SELFTESTS_BUILD_CMDS + $(TARGET_MAKE_ENV) $(MAKE1) -C $(@D) $(SELFTESTS_MAKE_FLAGS) \ + headers_install + $(TARGET_MAKE_ENV) $(MAKE1) -C $(@D)/tools/testing/selftests \ + $(SELFTESTS_MAKE_FLAGS) O=$(@D)/tools/testing/selftests +endef + +define SELFTESTS_INSTALL_TARGET_CMDS + $(TARGET_MAKE_ENV) $(MAKE1) -C $(@D)/tools/testing/selftests \ + $(SELFTESTS_MAKE_FLAGS) O=$(@D)/tools/testing/selftests \ + INSTALL_PATH=$(TARGET_DIR)/usr/lib/kselftests install +endefSignature · 1 line
2.6.4
PATCH v2 1/1 linux: Build and install kernel selftests
Cyril, All,
On 2016-03-16 09:09 +1100, Cyril Bur spake thusly:
Quoted 5 lines
Quoted 3 lines · On Tue, 15 Mar 2016 10:24:13 +0100 "Yann E. MORIN" <[email protected]>…
On 2016-01-04 11:59 +1100, Cyril Bur spake thusly:
Quoted 2 lines
This patch simply adds the ability to compile and install the kernel selftests into the target at
/usr/lib/kselftests.
[--SNIP--]
Quoted 19 lines
Quoted 10 lines
Quoted 10 lines
linux/linux-tool-selftests.mk new file +4
-0@@ -0,0 +1,42 @@ +################################################################################ +# +# selftests +#Quoted 8 lines
linux/linux-tool-selftests.mk line 9
Quoted 5 lines
linux/linux-tool-selftests.mk new file +5
-0+################################################################################ + +LINUX_TOOLS += selftests + +ifeq ($(KERNEL_ARCH),x86_64)For i386, Buildroot sets KERNEL_ARCH=i386, so we may also want to handle that case, no?
Quoted 2 lines
I think you're right but not super sure... I'll leave it up to an x86 boffin to confirm that it's the correct thing to do :)
Well, I guess you don't need a i386 guru to just add it, as that's what we already do for the kernel (see linux/linux.mk at 157).
[--SNIP--]
Quoted 8 lines
Quoted 8 lines
linux/linux-tool-selftests.mk line 15
Quoted 1 line
linux/linux-tool-selftests.mk new file +1
-0+SELFTESTS_DEPENDENCIES = bashIt can also use libcap-ng, so you probably want to depend on it, too:
/home/ymorin/dev/buildroot/O/host/usr/bin/i686-pc-linux-gnu-gcc-O2 -g
-std=gnu99 -Wallvalidate_cap.c-lcap-ng -lrt -ldl -ovalidate_cap
validate_cap.c:1:20: fatal error:cap-ng.h: No such file or directory
Quoted 8 lines
Quoted 6 lines
Ditto popt:
/home/ymorin/dev/buildroot/O/host/opt/ext-toolchain/bin/../lib/gcc/i686-pc-linux-gnu/4.7.2/../../../../i686-pc-linux-gnu/bin/ld: cannot find -lpopt
collect2: error: ld returned 1 exit statusI could add those dependencies I suppose, it would be nicer for everyone.
Yes, please do.
Quoted 9 lines
Quoted 6 lines
However, as you said in the commit log, those are not fatal errors (although reported as such) and the build goes on successfully for the rest of the tests:
Reviewed-by "Yann E. MORIN" <[email protected]>Tested-by "Yann E. MORIN" <[email protected]>Are you happy for me to do a v3 based on your comments and leave both the Reviewed-by and Tested-by tags?
If all you do is:
- add the i386 case,
- add libcap-ng and popt dependencies,
then yes, those tags of mine still stand.
Don;t rename selftests into linux-selftests, though. It should be a separate patch that renames all the tools. For now, stay consistent with the existing tools, that is: do not prefix.
Quoted 1 line
Also, for what its worth, I've built and used it a lot for powerpc.
Great! :-)
Quoted 1 line
Thanks again,
My pleasure! :-)
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH v2 1/1 linux: Build and install kernel selftests
Quoted 61 lines · On Tue, 15 Mar 2016 23:21:51 +0100 "Yann E. MORIN" <[email protected]>…
Cyril, All,
On 2016-03-16 09:09 +1100, Cyril Bur spake thusly:
Quoted 5 lines
Quoted 3 lines · On Tue, 15 Mar 2016 10:24:13 +0100 "Yann E. MORIN" <[email protected]>…
On 2016-01-04 11:59 +1100, Cyril Bur spake thusly:
Quoted 2 lines
This patch simply adds the ability to compile and install the kernel selftests into the target at
/usr/lib/kselftests.[--SNIP--]
Quoted 19 lines
Quoted 10 lines
Quoted 10 lines
linux/linux-tool-selftests.mk new file +4
-0@@ -0,0 +1,42 @@ +################################################################################ +# +# selftests +#Quoted 8 lines
linux/linux-tool-selftests.mk line 9
Quoted 5 lines
linux/linux-tool-selftests.mk new file +5
-0+################################################################################ + +LINUX_TOOLS += selftests + +ifeq ($(KERNEL_ARCH),x86_64)For i386, Buildroot sets KERNEL_ARCH=i386, so we may also want to handle that case, no?
Quoted 2 lines
I think you're right but not super sure... I'll leave it up to an x86 boffin to confirm that it's the correct thing to do :)
Well, I guess you don't need a i386 guru to just add it, as that's what we already do for the kernel (see
linux/linux.mkat 157).[--SNIP--]
Quoted 8 lines
Quoted 8 lines
linux/linux-tool-selftests.mk line 15
Quoted 1 line
linux/linux-tool-selftests.mk new file +1
-0+SELFTESTS_DEPENDENCIES = bashIt can also use libcap-ng, so you probably want to depend on it, too:
/home/ymorin/dev/buildroot/O/host/usr/bin/i686-pc-linux-gnu-gcc-O2 -g
-std=gnu99 -Wallvalidate_cap.c-lcap-ng -lrt -ldl -ovalidate_cap
validate_cap.c:1:20: fatal error:cap-ng.h: No such file or directoryQuoted 8 lines
Quoted 6 lines
Ditto popt:
/home/ymorin/dev/buildroot/O/host/opt/ext-toolchain/bin/../lib/gcc/i686-pc-linux-gnu/4.7.2/../../../../i686-pc-linux-gnu/bin/ld: cannot find -lpopt
collect2: error: ld returned 1 exit statusI could add those dependencies I suppose, it would be nicer for everyone.
Yes, please do.
Quoted 7 lines
Quoted 6 lines
However, as you said in the commit log, those are not fatal errors (although reported as such) and the build goes on successfully for the rest of the tests:
Reviewed-by "Yann E. MORIN" <[email protected]>Tested-by "Yann E. MORIN" <[email protected]>
Quoted 8 lines
Quoted 2 lines
Are you happy for me to do a v3 based on your comments and leave both the Reviewed-by and Tested-by tags?
If all you do is:
- add the i386 case,
- add libcap-ng and popt dependencies,
then yes, those tags of mine still stand.
Ok, in doing it I had a thought, would it not just be best to add a "select" line in the Config.tools.in line for libcap-ng and popt? That way people don't HAVE to have it if they don't care about those tests.
I'm not sure as to the mapping between adding a select in a Config.in and using "*_DEPENDENCIES =" in the .mk
Quoted 3 lines
Don;t rename selftests into linux-selftests, though. It should be a separate patch that renames all the tools. For now, stay consistent with the existing tools, that is: do not prefix.
Yeah good point.
Quoted 12 lines
Quoted 2 lines
Also, for what its worth, I've built and used it a lot for powerpc.
Great! :-)
Quoted 1 line
Thanks again,
My pleasure! :-)
Regards,
Yann E. MORIN.