Skip to contentSkip to conversation

xorriso: Bump version, Add host variant

PATCH New Benoît Allard 3 participants 7 messages Mar 15, 2016 – Mar 16, 2016

lore
Share & tools
lore

Benoît Allard

author
#0 lore raw

PATCH 1/1 xorriso: Bump version, Add host variant

Signed-off-by Beno?t Allard <[email protected]>
---
 package/Config.in.host         |  1 +
 package/xorriso/Config.in.host | 14 ++++++++++++++
 package/xorriso/xorriso.hash   |  2 +-
 package/xorriso/xorriso.mk     |  3 ++-
 4 files changed, 18 insertions(+), 2 deletions(-)
 create mode 100644 package/xorriso/Config.in.host
package/Config.in.host +1 -0
index 09c98fb..a91612b 100644
@@ -32,6 +32,7 @@ menu "Host utilities"
 	source "package/uboot-tools/Config.in.host"
 	source "package/util-linux/Config.in.host"
 	source "package/vboot-utils/Config.in.host"
+	source "package/xorriso/Config.in.host"
 	source "package/zip/Config.in.host"
 
 endmenu
package/xorriso/Config.in.host new file +14 -0
new file mode 100644
index 0000000..2baa043
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_HOST_XORRISO
+	bool "host xorriso"
+	help
+	  xorriso copies file objects from POSIX compliant
+	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
+	  and allows session-wise manipulation of such filesystems.
+	  It can load the management information of existing ISO
+	  images and it writes the session results to optical media
+	  or to filesystem objects.
+
+	  Vice versa xorriso is able to copy file objects out of ISO
+	  9660 filesystems.
+
+	  https://www.gnu.org/software/xorriso
package/xorriso/xorriso.hash +1 -1
index 98a716d..3c2a726 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 901204634651533f7cbd105eab560534702458258529aac4b2f0fc946992107e xorriso-1.3.8.tar.gz
+sha256 2843beded1aa4c678706e96fdf9cc5e4b34430b559bdf5bc35df5202125004b3 xorriso-1.4.2.tar.gz
package/xorriso/xorriso.mk +2 -1
index 5826340..a465beb 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-XORRISO_VERSION = 1.3.8
+XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT

@@ -64,3 +64,4 @@ XORRISO_CONF_OPTS += --disable-jtethreads
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 1 line
2.1.4
author
#1 lore raw

PATCH 1/2 xorriso: Bump version to 1.4.2

Signed-off-by Beno?t Allard <[email protected]>
---
 package/xorriso/xorriso.hash | 2 +-
 package/xorriso/xorriso.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/xorriso/xorriso.hash +1 -1
index 98a716d..3c2a726 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 901204634651533f7cbd105eab560534702458258529aac4b2f0fc946992107e xorriso-1.3.8.tar.gz
+sha256 2843beded1aa4c678706e96fdf9cc5e4b34430b559bdf5bc35df5202125004b3 xorriso-1.4.2.tar.gz
package/xorriso/xorriso.mk +1 -1
index 5826340..e8bb5cb 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-XORRISO_VERSION = 1.3.8
+XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
Signature · 1 line
2.1.4
#2 lore raw

PATCH 1/2 xorriso: Bump version to 1.4.2

Beno?t, All,

On 2016-03-15 15:07 +0100, Beno?t Allard spake thusly:

Quoted 1 line
Signed-off-by Beno?t Allard <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>
[build-tested only, with no deps then with all deps]
Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

PS. Sorry for the potential duplicate, the previous mail hasn't made it
to the list yet, one hour later...
YEM.

Quoted 33 lines
---
 package/xorriso/xorriso.hash | 2 +-
 package/xorriso/xorriso.mk   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/xorriso/xorriso.hash +1 -1
index 98a716d..3c2a726 100644
@@ -1,2 +1,2 @@
 # Locally computed
-sha256 901204634651533f7cbd105eab560534702458258529aac4b2f0fc946992107e xorriso-1.3.8.tar.gz
+sha256 2843beded1aa4c678706e96fdf9cc5e4b34430b559bdf5bc35df5202125004b3 xorriso-1.4.2.tar.gz
package/xorriso/xorriso.mk +1 -1
index 5826340..e8bb5cb 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-XORRISO_VERSION = 1.3.8
+XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#4 lore raw

PATCH 2/2 xorriso: Add host variant

In reply to Benoît Allard
Signed-off-by Beno?t Allard <[email protected]>
---
 package/Config.in.host         |  1 +
 package/xorriso/Config.in.host | 14 ++++++++++++++
 package/xorriso/xorriso.mk     |  2 ++
 3 files changed, 17 insertions(+)
 create mode 100644 package/xorriso/Config.in.host
package/Config.in.host +1 -0
index 09c98fb..a91612b 100644
@@ -32,6 +32,7 @@ menu "Host utilities"
 	source "package/uboot-tools/Config.in.host"
 	source "package/util-linux/Config.in.host"
 	source "package/vboot-utils/Config.in.host"
+	source "package/xorriso/Config.in.host"
 	source "package/zip/Config.in.host"
 
 endmenu
package/xorriso/Config.in.host new file +14 -0
new file mode 100644
index 0000000..2baa043
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_HOST_XORRISO
+	bool "host xorriso"
+	help
+	  xorriso copies file objects from POSIX compliant
+	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
+	  and allows session-wise manipulation of such filesystems.
+	  It can load the management information of existing ISO
+	  images and it writes the session results to optical media
+	  or to filesystem objects.
+
+	  Vice versa xorriso is able to copy file objects out of ISO
+	  9660 filesystems.
+
+	  https://www.gnu.org/software/xorriso
package/xorriso/xorriso.mk +2 -0
index e8bb5cb..9e9ec8a 100644
@@ -8,6 +8,7 @@ XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
+HOST_XORRISO_DEPENDENCIES =
 
 ifeq ($(BR2_PACKAGE_LIBICONV),y)
 XORRISO_DEPENDENCIES += libiconv

@@ -64,3 +65,4 @@ XORRISO_CONF_OPTS += --disable-jtethreads
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 1 line
2.1.4
#5 lore raw

PATCH 2/2 xorriso: Add host variant

Beno?t, All,

On 2016-03-15 15:07 +0100, Beno?t Allard spake thusly:

Quoted 30 lines
Signed-off-by Beno?t Allard <[email protected]>
---
 package/Config.in.host         |  1 +
 package/xorriso/Config.in.host | 14 ++++++++++++++
 package/xorriso/xorriso.mk     |  2 ++
 3 files changed, 17 insertions(+)
 create mode 100644 package/xorriso/Config.in.host
package/Config.in.host +1 -0
index 09c98fb..a91612b 100644
@@ -32,6 +32,7 @@ menu "Host utilities"
 	source "package/uboot-tools/Config.in.host"
 	source "package/util-linux/Config.in.host"
 	source "package/vboot-utils/Config.in.host"
+	source "package/xorriso/Config.in.host"
 	source "package/zip/Config.in.host"
 
 endmenu
package/xorriso/Config.in.host new file +4 -0
new file mode 100644
index 0000000..2baa043
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_HOST_XORRISO
+	bool "host xorriso"
+	help
+	  xorriso copies file objects from POSIX compliant

package/xorriso/Config.in.host line 14

Quoted 10 lines
package/xorriso/Config.in.host new file +10 -0
+	  filesystems into Rock Ridge enhanced ISO 9660 filesystems
+	  and allows session-wise manipulation of such filesystems.
+	  It can load the management information of existing ISO
+	  images and it writes the session results to optical media
+	  or to filesystem objects.
+
+	  Vice versa xorriso is able to copy file objects out of ISO
+	  9660 filesystems.
+
+	  https://www.gnu.org/software/xorriso

As I already replied in response to your previous iteration, I am totally fine with xorriso being exposed in the host utilities submenu.

package/xorriso/xorriso.mk XORRISO_VERSION = 1.4.2 · line 11

Quoted 9 lines
package/xorriso/xorriso.mk +1 -0
index e8bb5cb..9e9ec8a 100644
@@ -8,6 +8,7 @@ XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
+HOST_XORRISO_DEPENDENCIES =

Well, that part I am not so sure. Yes, it does build correectly, but it is highly dependent on the set of libraries (and their -dev files) being installed on your host distro.

So, either we set the dependency list to empty, but then we explicitly disable all optional features:

    HOST_XORRISO_DEPENDENCIES =
    HOST_XORRISO_CONF_OPTS = \
        --disable-libcdio \
        --disable-libreadline \
        --disable-libacl \
        and so on...

or we enable all those for which we do have a host package and for which it makes sense (probably just acl, zlib and bzip2):

    HOST_XORRISO_DEPENDENCIES = host-acl host-zlib host-bzip2
    HOST_XORRISO_CONF_OPTS = \
        --enable-libacl \
        --enable-zlib \
        --enable-bzip2 \
        --disable-libcdio
        --disable-libreadline \
        ...

Both are equally easy I guess. However, I think the latter is more interesting.

Regards,
Yann E. MORIN.

Quoted 14 lines
package/xorriso/xorriso.mk +1 -0
 ifeq ($(BR2_PACKAGE_LIBICONV),y)
 XORRISO_DEPENDENCIES += libiconv

@@ -64,3 +65,4 @@ XORRISO_CONF_OPTS += --disable-jtethreads
 endif
 
 $(eval $(autotools-package))
+$(eval $(host-autotools-package))
Signature · 6 lines
2.1.4

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
author
#6 lore raw

PATCH 2/2 xorriso: Add host variant

Quoted 36 lines · On Tue, 15 Mar 2016 22:35:37 +0100 "Yann E. MORIN" <[email protected]>…

package/xorriso/xorriso.mk XORRISO_VERSION = 1.4.2 · line 11

Quoted 9 lines
package/xorriso/xorriso.mk +1 -0
index e8bb5cb..9e9ec8a 100644
@@ -8,6 +8,7 @@ XORRISO_VERSION = 1.4.2
 XORRISO_SITE = $(BR2_GNU_MIRROR)/xorriso
 XORRISO_LICENSE = GPLv3+
 XORRISO_LICENSE_FILES = COPYING COPYRIGHT
+HOST_XORRISO_DEPENDENCIES =

Well, that part I am not so sure. Yes, it does build correectly, but it is highly dependent on the set of libraries (and their -dev files) being installed on your host distro.

So, either we set the dependency list to empty, but then we explicitly disable all optional features:

    HOST_XORRISO_DEPENDENCIES =
    HOST_XORRISO_CONF_OPTS = \
        --disable-libcdio \
        --disable-libreadline \
        --disable-libacl \
        and so on...

or we enable all those for which we do have a host package and for which it makes sense (probably just acl, zlib and bzip2):

    HOST_XORRISO_DEPENDENCIES = host-acl host-zlib host-bzip2
    HOST_XORRISO_CONF_OPTS = \
        --enable-libacl \
        --enable-zlib \
        --enable-bzip2 \
        --disable-libcdio
        --disable-libreadline \
        ...
Quoted 2 lines

Both are equally easy I guess. However, I think the latter is more interesting.

That makes sense of course ! I'll repost that patch with these options and extend the CONF_OPTS with all the necessary disables, hopefully, the needed features will still be included. I believe it makes sense to select the correct packages in the Config.in.host as well, right ?

Regards,
Ben
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160316/b0cb1fae/attachment.asc>