Skip to contentSkip to conversation

spurious warning from of_i2c_register_device with fixed_regulator?

DISCUSSION Pavel Machek 3 participants 3 messages Mar 16, 2016 – Mar 23, 2016 I2C subsystem host drivers

lore
Share & tools
lore
#0 lore raw

Hi!

We are getting this in the logs:

i2c i2c-0: of_i2c: invalid reg on /soc/i2c@ffc04000/vcc3p3-regulator

In the dts we have:

socfpga_cyclone5_sockit.dts:

        regulator_3_3v: vcc3p3-regulator {
	                compatible = "regulator-fixed";
		        regulator-name = "VCC3P3";
		        regulator-min-microvolt = <3300000>;
	                regulator-max-microvolt = <3300000>;
        };

Which seems to trigger

drivers/i2c/i2c-core.c:

      addr_be = of_get_property(node, "reg", &len);
                  if (!addr_be || (len < sizeof(*addr_be))) {
                       dev_err(&adap->dev, "of_i2c: invalid reg on %s\n",

...

But we have fixed regulator there, it does not have "reg" property.

Git blame says: a430a3455f2c48995e06b359a82a1109a419e9ef. (And no, I don't have exactly mainline kernel here, but it should be close enough.)

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 2 lines

But we have fixed regulator there, it does not have "reg" property.

The fixed regulator doesn't even use I2C. So, you need to debug why it calls I2C. Your information given is not enough for me.

#2 lore raw

Hi!

Quoted 4 lines
Quoted 1 line

But we have fixed regulator there, it does not have "reg" property.

The fixed regulator doesn't even use I2C. So, you need to debug why it calls I2C. Your information given is not enough for me.

Thanks for the help. It seems to have been mismerge on my dts.

Best regards,
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html