esp: Fix crash observed during device unregistration and decryption
Subsystems (3)
PATCH 1/1 esp: Fix crash observed during device unregistration and decryption
A crash is observed when a decrypted packet is processed in receive path. get_rps_cpus() tries to dereference the skb->dev fields but it appears that the device is freed from the poison pattern.
[<ffffffc000af58ec>] get_rps_cpu+0x94/0x2f0 [<ffffffc000af5f94>] netif_rx_internal+0x140/0x1cc [<ffffffc000af6094>] netif_rx+0x74/0x94 [<ffffffc000bc0b6c>] xfrm_input+0x754/0x7d0 [<ffffffc000bc0bf8>] xfrm_input_resume+0x10/0x1c [<ffffffc000ba6eb8>] esp_input_done+0x20/0x30 [<ffffffc0000b64c8>] process_one_work+0x244/0x3fc [<ffffffc0000b7324>] worker_thread+0x2f8/0x418 [<ffffffc0000bb40c>] kthread+0xe0/0xec
-013|get_rps_cpu(
| dev = 0xFFFFFFC08B688000,
| skb = 0xFFFFFFC0C76AAC00 -> (
| dev = 0xFFFFFFC08B688000 -> (
| name =
"......................................................
| name_hlist = (next = 0xAAAAAAAAAAAAAAAA, pprev =0xAAAAAAAAAAA
Following are the sequence of events observed -
- Encrypted packet in receive path from netdevice is queued
- Encrypted packet queued for decryption (asynchronous)
- Netdevice brought down and freed
- Packet is decrypted and returned through callback in esp_input_done
- Packet is queued again for process in network stack using netif_rx
Since the device appears to have been freed, the dereference of skb->dev in get_rps_cpus() leads to an unhandled page fault exception.
Fix this by holding on to device reference when queueing packets asynchronously and releasing the reference on call back return.
--- net/ipv4/esp4.c | 2 ++ net/ipv6/esp6.c | 2 ++ 2 files changed, 4 insertions(+)
net/ipv4/esp4.c +0 -0
@@ -380,6 +380,7 @@ static void esp_input_done(struct crypto_async_request
*base, int err)
{
struct sk_buff *skb = base->data;
+ dev_put(skb->dev);
xfrm_input_resume(skb, esp_input_done2(skb, err));
}
@@ -454,6 +455,7 @@ static int esp_input(struct xfrm_state *x, struct sk_buff *skb)
esph = (struct ip_esp_hdr *)skb->data;
+ dev_hold(skb->dev);
aead_request_set_callback(req, 0, esp_input_done, skb);
/* For ESN we move the header forward by 4 bytes to
net/ipv6/esp6.c +0 -0
@@ -334,6 +334,7 @@ static void esp_input_done(struct crypto_async_request
*base, int err)
{
struct sk_buff *skb = base->data;
+ dev_put(skb->dev);
xfrm_input_resume(skb, esp_input_done2(skb, err));
}
@@ -408,6 +409,7 @@ static int esp6_input(struct xfrm_state *x, struct sk_buff *skb)
esph = (struct ip_esp_hdr *)skb->data;
+ dev_hold(skb->dev);
aead_request_set_callback(req, 0, esp_input_done, skb);
/* For ESN we move the header forward by 4 bytes to
Steffen Klassert
maintainerQuoted 49 lines · Subash Abhinov Kasiviswanathan
A crash is observed when a decrypted packet is processed in receive path.
get_rps_cpus()tries to dereference theskb->devfields but it appears that the device is freed from the poison pattern.[<ffffffc000af58ec>] get_rps_cpu+0x94/0x2f0 [<ffffffc000af5f94>] netif_rx_internal+0x140/0x1cc [<ffffffc000af6094>] netif_rx+0x74/0x94 [<ffffffc000bc0b6c>] xfrm_input+0x754/0x7d0 [<ffffffc000bc0bf8>] xfrm_input_resume+0x10/0x1c [<ffffffc000ba6eb8>] esp_input_done+0x20/0x30 [<ffffffc0000b64c8>] process_one_work+0x244/0x3fc [<ffffffc0000b7324>] worker_thread+0x2f8/0x418 [<ffffffc0000bb40c>] kthread+0xe0/0xec-013|get_rps_cpu(
| dev = 0xFFFFFFC08B688000, | skb = 0xFFFFFFC0C76AAC00 -> ( | dev = 0xFFFFFFC08B688000 -> ( | name = "...................................................... | name_hlist = (next = 0xAAAAAAAAAAAAAAAA, pprev =
0xAAAAAAAAAAAFollowing are the sequence of events observed -
- Encrypted packet in receive path from netdevice is queued
- Encrypted packet queued for decryption (asynchronous)
- Netdevice brought down and freed
- Packet is decrypted and returned through callback inesp_input_done
- Packet is queued again for process in network stack usingnetif_rxSince the device appears to have been freed, the dereference of
skb->devinget_rps_cpus()leads to an unhandled page fault exception.Fix this by holding on to device reference when queueing packets asynchronously and releasing the reference on call back return.
Suggested-by Herbert Xu <[email protected]>Signed-off-by Subash Abhinov Kasiviswanathan <[email protected]>--- net/ipv4/esp4.c | 2 ++ net/ipv6/esp6.c | 2 ++ 2 files changed, 4 insertions(+)net/ipv4/esp4.c +0
-0
net/ipv4/esp4.c static void esp_input_done(struct crypto_async_request · line 384
Quoted 5 lines
net/ipv4/esp4.c +1
-0@@ -380,6 +380,7 @@ static void esp_input_done(struct crypto_async_request *base, int err) {struct sk_buff *skb = base->data; +dev_put (skb->dev);
esp_input_done() is called just on asynchronous resumption, so you leak the reference on synchronous crypto.
Also, other IPsec protocols need this too. So maybe better to add this to xfrm_input().