nfsd: fix deadlock secinfo+readdir compound
Subsystems (2)
PATCH 1/1 nfsd: fix deadlock secinfo+readdir compound
From: "J. Bruce Fields" <[email protected]>
nfsd_lookup_dentry exits with the parent filehandle locked. fh_put also unlocks if necessary (nfsd filehandle locking is probably too lenient), so it gets unlocked eventually, but if the following op in the compound needs to lock it again, we can deadlock.
A fuzzer ran into this; normal clients don't send a secinfo followed by a readdir in the same compound.
Signed-off-by J. Bruce Fields <[email protected]>
--- fs/nfsd/nfs4proc.c | 1 + 1 file changed, 1 insertion(+)
fs/nfsd/nfs4proc.c +1 -0
@@ -876,6 +876,7 @@ nfsd4_secinfo(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate, &exp, &dentry);if (err)return err; +fh_unlock (&cstate->current_fh);if (d_really_is_negative (dentry)) {exp_put (exp); err = nfserr_noent;
Signature · 1 line
2.5.0