Bad rever-select of CONFIG_SND_HDA_I915
Hi,
while build testing, I noticed the following warning:
warning: (SND_SOC_INTEL_SKYLAKE) selects SND_HDA_I915 which has unmet direct dependencies (SOUND && !M68K && !UML && SND && DRM_I915 && SND_HDA_CORE)
And it's indeed broken: you can't select CONFIG_SND_HDA_I915 from the driver side. This is the condition depending on DRM i915 driver.
Fixing this doesn't look too trivial, though. Since SND_SOC_INTEL_SKYLAKE is the item to be selected, it can't have "depends on". So, the top-level configs that select SND_SOC_INTEL_SKYLAKE need to have "depends on DRM_I915" lines, or modify the driver to be built without i915 binding.
Takashi
Quoted 4 lines · Takashi Iwai
Hi,
while build testing, I noticed the following warning:
warning: (SND_SOC_INTEL_SKYLAKE) selectsSND_HDA_I915which has unmet direct dependencies (SOUND && !M68K && !UML && SND &&DRM_I915&&SND_HDA_CORE)
Thanks Takashi for reporting,
Quoted 2 lines
And it's indeed broken: you can't select
CONFIG_SND_HDA_I915from the driver side. This is the condition depending on DRM i915 driver.
But who selects CONFIG_SND_HDA_I915. It is a bool symbol, so someone needs to select it. I didn't see anyone select it, either from Gfx side or HDA side?
Quoted 6 lines
Fixing this doesn't look too trivial, though. Since
SND_SOC_INTEL_SKYLAKEis the item to be selected, it can't have "depends on". So, the top-level configs that selectSND_SOC_INTEL_SKYLAKEneed to have "depends onDRM_I915" lines, or modify the driver to be built without i915 binding.
can you please share the config where you saw this...
Signature · 1 line
~Vinod
Quoted 7 lines · Vinod Koul
Quoted 4 lines · Takashi Iwai
Hi,
while build testing, I noticed the following warning:
warning: (SND_SOC_INTEL_SKYLAKE) selectsSND_HDA_I915which has unmet direct dependencies (SOUND && !M68K && !UML && SND &&DRM_I915&&SND_HDA_CORE)
Quoted 8 lines
Thanks Takashi for reporting,
Quoted 2 lines
And it's indeed broken: you can't select
CONFIG_SND_HDA_I915from the driver side. This is the condition depending on DRM i915 driver.But who selects
CONFIG_SND_HDA_I915. It is a bool symbol, so someone needs to select it. I didn't see anyone select it, either from Gfx side or HDA side?
No, it's not a kconfig to be selected manually by others, but it adjusts itself automatically depending on DRM_I915. That is, it's a read-only value.
Quoted 7 lines
Quoted 5 lines
Fixing this doesn't look too trivial, though. Since
SND_SOC_INTEL_SKYLAKEis the item to be selected, it can't have "depends on". So, the top-level configs that selectSND_SOC_INTEL_SKYLAKEneed to have "depends onDRM_I915" lines, or modify the driver to be built without i915 binding.can you please share the config where you saw this...
Just set DRM_I915=n and run config again on your machine.
Takashi
Quoted 14 lines · Takashi Iwai
Quoted 12 lines · Vinod Koul
Quoted 4 lines · Takashi Iwai
Hi,
while build testing, I noticed the following warning:
warning: (SND_SOC_INTEL_SKYLAKE) selectsSND_HDA_I915which has unmet direct dependencies (SOUND && !M68K && !UML && SND &&DRM_I915&&SND_HDA_CORE)Thanks Takashi for reporting,
Quoted 2 lines
And it's indeed broken: you can't select
CONFIG_SND_HDA_I915from the driver side. This is the condition depending on DRM i915 driver.
Quoted 7 lines
Quoted 3 lines
But who selects
CONFIG_SND_HDA_I915. It is a bool symbol, so someone needs to select it. I didn't see anyone select it, either from Gfx side or HDA side?No, it's not a kconfig to be selected manually by others, but it adjusts itself automatically depending on
DRM_I915. That is, it's a read-only value.
Okay then
Quoted 9 lines
Quoted 7 lines
Quoted 5 lines
Fixing this doesn't look too trivial, though. Since
SND_SOC_INTEL_SKYLAKEis the item to be selected, it can't have "depends on". So, the top-level configs that selectSND_SOC_INTEL_SKYLAKEneed to have "depends onDRM_I915" lines, or modify the driver to be built without i915 binding.can you please share the config where you saw this...
Just set DRM_I915=n and run config again on your machine.
Yes saw this now. I made depends on DRM_I915 to make it disappear.
I will check again for compilation fix and get back on proper patch either which depends on DRM or ensure we compile clean
Thanks
Signature · 1 line
~Vinod
Quoted 32 lines · Vinod Koul
Quoted 14 lines · Takashi Iwai
Quoted 12 lines · Vinod Koul
Quoted 4 lines · Takashi Iwai
Hi,
while build testing, I noticed the following warning:
warning: (SND_SOC_INTEL_SKYLAKE) selectsSND_HDA_I915which has unmet direct dependencies (SOUND && !M68K && !UML && SND &&DRM_I915&&SND_HDA_CORE)Thanks Takashi for reporting,
Quoted 2 lines
And it's indeed broken: you can't select
CONFIG_SND_HDA_I915from the driver side. This is the condition depending on DRM i915 driver.Quoted 7 lines
Quoted 3 lines
But who selects
CONFIG_SND_HDA_I915. It is a bool symbol, so someone needs to select it. I didn't see anyone select it, either from Gfx side or HDA side?No, it's not a kconfig to be selected manually by others, but it adjusts itself automatically depending on
DRM_I915. That is, it's a read-only value.Okay then
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Fixing this doesn't look too trivial, though. Since
SND_SOC_INTEL_SKYLAKEis the item to be selected, it can't have "depends on". So, the top-level configs that selectSND_SOC_INTEL_SKYLAKEneed to have "depends onDRM_I915" lines, or modify the driver to be built without i915 binding.
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
can you please share the config where you saw this...
Just set DRM_I915=n and run config again on your machine.
Yes saw this now. I made depends on
DRM_I915to make it disappear.
OTOH, this makes impossible to use the driver without graphics, even if you want only Realtek codec.
Quoted 2 lines
I will check again for compilation fix and get back on proper patch either which depends on DRM or ensure we compile clean
I guess the build failure won't happen even if you rip off SND_HDA_I915 dependency from SND_SOC_INTEL_SKYLAKE. Let's check.
Takashi
Quoted 40 lines · Takashi Iwai
Quoted 32 lines · Vinod Koul
Quoted 14 lines · Takashi Iwai
Quoted 12 lines · Vinod Koul
Quoted 4 lines · Takashi Iwai
Hi,
while build testing, I noticed the following warning:
warning: (SND_SOC_INTEL_SKYLAKE) selectsSND_HDA_I915which has unmet direct dependencies (SOUND && !M68K && !UML && SND &&DRM_I915&&SND_HDA_CORE)Thanks Takashi for reporting,
Quoted 2 lines
And it's indeed broken: you can't select
CONFIG_SND_HDA_I915from the driver side. This is the condition depending on DRM i915 driver.Quoted 7 lines
Quoted 3 lines
But who selects
CONFIG_SND_HDA_I915. It is a bool symbol, so someone needs to select it. I didn't see anyone select it, either from Gfx side or HDA side?No, it's not a kconfig to be selected manually by others, but it adjusts itself automatically depending on
DRM_I915. That is, it's a read-only value.Okay then
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Fixing this doesn't look too trivial, though. Since
SND_SOC_INTEL_SKYLAKEis the item to be selected, it can't have "depends on". So, the top-level configs that selectSND_SOC_INTEL_SKYLAKEneed to have "depends onDRM_I915" lines, or modify the driver to be built without i915 binding.Quoted 5 lines
Quoted 3 lines
Quoted 1 line
can you please share the config where you saw this...
Just set DRM_I915=n and run config again on your machine.
Yes saw this now. I made depends on
DRM_I915to make it disappear.
Quoted 8 lines
OTOH, this makes impossible to use the driver without graphics, even if you want only Realtek codec.
Quoted 2 lines
I will check again for compilation fix and get back on proper patch either which depends on DRM or ensure we compile clean
I guess the build failure won't happen even if you rip off
SND_HDA_I915dependency fromSND_SOC_INTEL_SKYLAKE. Let's check.
It doesn't. So both work well :)
Depends on DRM_I915 as well as removing current select.
FWIW, the removing the DRM will not work as HDMI will fail so dailinks wont be there and sound card will not get registered :)
So which one to do in above?
Signature · 1 line
~Vinod
Quoted 51 lines · Vinod Koul
Quoted 40 lines · Takashi Iwai
Quoted 32 lines · Vinod Koul
Quoted 14 lines · Takashi Iwai
Quoted 12 lines · Vinod Koul
Quoted 4 lines · Takashi Iwai
Hi,
while build testing, I noticed the following warning:
warning: (SND_SOC_INTEL_SKYLAKE) selectsSND_HDA_I915which has unmet direct dependencies (SOUND && !M68K && !UML && SND &&DRM_I915&&SND_HDA_CORE)Thanks Takashi for reporting,
Quoted 2 lines
And it's indeed broken: you can't select
CONFIG_SND_HDA_I915from the driver side. This is the condition depending on DRM i915 driver.Quoted 7 lines
Quoted 3 lines
But who selects
CONFIG_SND_HDA_I915. It is a bool symbol, so someone needs to select it. I didn't see anyone select it, either from Gfx side or HDA side?No, it's not a kconfig to be selected manually by others, but it adjusts itself automatically depending on
DRM_I915. That is, it's a read-only value.Okay then
Quoted 6 lines
Quoted 6 lines
Quoted 5 lines
Fixing this doesn't look too trivial, though. Since
SND_SOC_INTEL_SKYLAKEis the item to be selected, it can't have "depends on". So, the top-level configs that selectSND_SOC_INTEL_SKYLAKEneed to have "depends onDRM_I915" lines, or modify the driver to be built without i915 binding.Quoted 5 lines
Quoted 3 lines
Quoted 1 line
can you please share the config where you saw this...
Just set DRM_I915=n and run config again on your machine.
Yes saw this now. I made depends on
DRM_I915to make it disappear.Quoted 8 lines
OTOH, this makes impossible to use the driver without graphics, even if you want only Realtek codec.
Quoted 2 lines
I will check again for compilation fix and get back on proper patch either which depends on DRM or ensure we compile clean
I guess the build failure won't happen even if you rip off
SND_HDA_I915dependency fromSND_SOC_INTEL_SKYLAKE. Let's check.
Quoted 8 lines
It doesn't. So both work well :)
Depends on
DRM_I915as well as removing current select.FWIW, the removing the DRM will not work as HDMI will fail so dailinks wont be there and sound card will not get registered :)
So which one to do in above?
HDMI would never work without graphics, so it shouldn't be a big problem. I'm for dropping the dependency, for now.
Takashi
Quoted 7 lines · Takashi Iwai
Quoted 7 lines
Quoted 2 lines
I guess the build failure won't happen even if you rip off
SND_HDA_I915dependency fromSND_SOC_INTEL_SKYLAKE. Let's check.It doesn't. So both work well :)
Depends on
DRM_I915as well as removing current select.
Quoted 7 lines
Quoted 4 lines
FWIW, the removing the DRM will not work as HDMI will fail so dailinks wont be there and sound card will not get registered :)
So which one to do in above?
HDMI would never work without graphics, so it shouldn't be a big problem. I'm for dropping the dependency, for now.
Okay sent you the patch for that
Signature · 1 line
~Vinod