Skip to contentSkip to conversation

staging: rtl8712: Fixed Multiple FSF address checkpatch warnings

PATCH Superseded Parth Sane 4 participants 11 messages Mar 20, 2016 – Mar 21, 2016 Staging

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Parth Sane

author
#0 lore raw

cover staging: rtl8712: Fixed Multiple FSF address checkpatch warnings

*** BLURB HERE ***

Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl9712: Fixed FSF address warning in ethernet.h
staging: rtl9712: Fixed FSF address warning in hal_init.c
staging: rtl9712: Fixed FSF address warning in ieee80211.c

 drivers/staging/rtl8712/basic_types.h | 4 ----
 drivers/staging/rtl8712/drv_types.h   | 4 ----
 drivers/staging/rtl8712/ethernet.h    | 4 ----
 drivers/staging/rtl8712/hal_init.c    | 4 ----
 drivers/staging/rtl8712/ieee80211.c   | 4 ----
 5 files changed, 20 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/5 staging: rtl8712: Fixed FSF address warning in basic_types.h

Signed-off-by Parth Sane <[email protected]>
---
 drivers/staging/rtl8712/basic_types.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8712/basic_types.h +0 -4
index 7561bed..f5c0231 100644
@@ -11,10 +11,6 @@
  * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
  * Modifications for inclusion into the Linux staging tree are
  * Copyright(c) 2010 Larry Finger. All rights reserved.
  *
Signature · 1 line
1.9.1
maintainer
#2 lore raw

Re: [PATCH 1/5] staging: rtl8712: Fixed FSF address warning in basic_types.h

Quoted 1 line · Parth Sane
Signed-off-by Parth Sane <[email protected]>

I can't take patches with no changelog text :(

author
#3 lore raw

PATCH 2/5 staging: rtl8712: Fixed FSF address warning in drv_types.h

In reply to Parth Sane
Signed-off-by Parth Sane <[email protected]>
---
 drivers/staging/rtl8712/drv_types.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8712/drv_types.h +0 -4
index 29e47e1..ae79047 100644
@@ -11,10 +11,6 @@
  * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
  * Modifications for inclusion into the Linux staging tree are
  * Copyright(c) 2010 Larry Finger. All rights reserved.
  *
Signature · 1 line
1.9.1
author
#4 lore raw

PATCH 3/5 staging: rtl9712: Fixed FSF address warning in ethernet.h

In reply to Parth Sane
Signed-off-by Parth Sane <[email protected]>
---
 drivers/staging/rtl8712/ethernet.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8712/ethernet.h +0 -4
index fad173f..039da36 100644
@@ -11,10 +11,6 @@
  * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
  * Modifications for inclusion into the Linux staging tree are
  * Copyright(c) 2010 Larry Finger. All rights reserved.
  *
Signature · 1 line
1.9.1
author
#5 lore raw

PATCH 4/5 staging: rtl9712: Fixed FSF address warning in hal_init.c

In reply to Parth Sane
Signed-off-by Parth Sane <[email protected]>
---
 drivers/staging/rtl8712/hal_init.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8712/hal_init.c +0 -4
index 17d2b5f..afa7fe78 100644
@@ -13,10 +13,6 @@
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
  * Modifications for inclusion into the Linux staging tree are
  * Copyright(c) 2010 Larry Finger. All rights reserved.
  *
Signature · 1 line
1.9.1
author
#6 lore raw

PATCH 5/5 staging: rtl9712: Fixed FSF address warning in ieee80211.c

In reply to Parth Sane
Signed-off-by Parth Sane <[email protected]>
---
 drivers/staging/rtl8712/ieee80211.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/staging/rtl8712/ieee80211.c +0 -4
index d13b4d5..8918654 100644
@@ -13,10 +13,6 @@
  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
  * more details.
  *
- * You should have received a copy of the GNU General Public License along with
- * this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
- *
  * Modifications for inclusion into the Linux staging tree are
  * Copyright(c) 2010 Larry Finger. All rights reserved.
  *
Signature · 1 line
1.9.1
#7 lore raw
In reply to Parth Sane
Quoted 16 lines · Parth Sane

*** BLURB HERE ***

Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl9712: Fixed FSF address warning in ethernet.h
staging: rtl9712: Fixed FSF address warning in hal_init.c
staging: rtl9712: Fixed FSF address warning in ieee80211.c

 drivers/staging/rtl8712/basic_types.h | 4 ----
 drivers/staging/rtl8712/drv_types.h   | 4 ----
 drivers/staging/rtl8712/ethernet.h    | 4 ----
 drivers/staging/rtl8712/hal_init.c    | 4 ----
 drivers/staging/rtl8712/ieee80211.c   | 4 ----
 5 files changed, 20 deletions(-)
Quoted 7 lines

--
1.9.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

It looks like all the patches in this set do not contain a commit log in the body. It's up to the maintainer but I'm fairly certain they won't be accepted without a body.

Quoted 23 lines · Parth Sane

Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style.

Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl9712: Fixed FSF address warning in ethernet.h
staging: rtl9712: Fixed FSF address warning in hal_init.c
staging: rtl9712: Fixed FSF address warning in ieee80211.c

 drivers/staging/rtl8712/basic_types.h | 4 ----
 drivers/staging/rtl8712/drv_types.h   | 4 ----
 drivers/staging/rtl8712/ethernet.h    | 4 ----
 drivers/staging/rtl8712/hal_init.c    | 4 ----
 drivers/staging/rtl8712/ieee80211.c   | 4 ----
 5 files changed, 20 deletions(-)

--
1.9.1

_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

author
#8 lore raw
Quoted 16 lines

Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style.

Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl9712: Fixed FSF address warning in ethernet.h
staging: rtl9712: Fixed FSF address warning in hal_init.c
staging: rtl9712: Fixed FSF address warning in ieee80211.c

drivers/staging/rtl8712/basic_types.h | 4 ----
drivers/staging/rtl8712/drv_types.h   | 4 ----
drivers/staging/rtl8712/ethernet.h    | 4 ----
drivers/staging/rtl8712/hal_init.c    | 4 ----
drivers/staging/rtl8712/ieee80211.c   | 4 ----
5 files changed, 20 deletions(-)
Quoted 2 lines

--
1.9.1

Hi,
The thing is all these patches are related and have a cover letter explaining changes. But this seems to be a trivial change which is self explanatory. This should possibly suffice. What do you think?
Regards,
Parth Sane

#9 lore raw
Quoted 16 lines · Parth Sane
Quoted 16 lines

Fixed Multiple FSF address checkpatch warnings to conform to kernel coding style.

Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl9712: Fixed FSF address warning in ethernet.h
staging: rtl9712: Fixed FSF address warning in hal_init.c
staging: rtl9712: Fixed FSF address warning in ieee80211.c

drivers/staging/rtl8712/basic_types.h | 4 ----
drivers/staging/rtl8712/drv_types.h   | 4 ----
drivers/staging/rtl8712/ethernet.h    | 4 ----
drivers/staging/rtl8712/hal_init.c    | 4 ----
drivers/staging/rtl8712/ieee80211.c   | 4 ----
5 files changed, 20 deletions(-)
Quoted 7 lines
Quoted 2 lines

--
1.9.1

Hi,
The thing is all these patches are related and have a cover letter explaining changes. But this seems to be a trivial change which is self explanatory. This should possibly suffice. What do you think?
Regards,
Parth Sane

The cover letter does not end up in the repository. A cover letter can be helpful, but is not required. You MUST, however add a descriptive commit message to each patch for them to be accepted into the kernel. See Documentation/SubmittingPatches in the kernel sources.

maintainer
#10 lore raw
In reply to Parth Sane
Quoted 1 line · Parth Sane

*** BLURB HERE ***

You forgot to fill this out :(

Quoted 7 lines

Parth Sane (5):
staging: rtl8712: Fixed FSF address warning in basic_types.h
staging: rtl8712: Fixed FSF address warning in drv_types.h
staging: rtl9712: Fixed FSF address warning in ethernet.h
staging: rtl9712: Fixed FSF address warning in hal_init.c
staging: rtl9712: Fixed FSF address warning in ieee80211.c

Your subject lines are refering to an unknown driver :(