Skip to contentSkip to conversation

staging: xgifb: Fix comment style

PATCH In review YU Bo 2 participants 3 messages Mar 12, 2016 – Mar 22, 2016 Staging

lore
Share & tools
lore

YU Bo

author
#0 lore raw

PATCH 1/1 staging: xgifb: Fix comment style

Fix comments to use trailing */ on separste lines.

---

drivers/staging/xgifb/vb_init.c    |    3 ++-
drivers/staging/xgifb/vb_setmode.c |    3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
drivers/staging/xgifb/vb_init.c +0 -0
index 26b539bc6faf..572487388e81 100644
@@ -355,7 +355,8 @@ static void XGINew_DDR2_DefaultRegister(
	unsigned long P3d4 = Port, P3c4 = Port - 0x10;

	/* keep following setting sequence, each setting in
-	 * the same reg insert idle */
+	 * the same reg insert idle
+	 */
	xgifb_reg_set(P3d4, 0x82, 0x77);
	xgifb_reg_set(P3d4, 0x86, 0x00);
	xgifb_reg_get(P3d4, 0x86); /* Insert read command for delay */
drivers/staging/xgifb/vb_setmode.c +0 -0
index f97c77d88173..240d4257bc2f 100644
@@ -1992,7 +1992,8 @@ static void XGI_GetVBInfo(unsigned short ModeIdIndex,
		}

		/* LCD+TV can't support in slave mode
-		 * (Force LCDA+TV->LCDB) */
+		 * (Force LCDA+TV->LCDB)
+		 */
		if ((tempbx & SetInSlaveMode) && (tempbx & XGI_SetCRT2ToLCDA)) {
			tempbx ^= (SetCRT2ToLCD | XGI_SetCRT2ToLCDA |
				   SetCRT2ToDualEdge);

--
1.7.10.4

maintainer
#1 lore raw
Quoted 7 lines · YU Bo

Fix comments to use trailing */ on separste lines.

---

drivers/staging/xgifb/vb_init.c    |    3 ++-
drivers/staging/xgifb/vb_setmode.c |    3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)

You sent me 2 different patches with the identical subject: line, which I can't accept. Please fix them up and send a patch series, with unique subjects.

thanks,

greg k-h

author
#2 lore raw

On Mon, Mar 21, 2016 at 03:38:21PM -0400, Kroah-Hartman wrote:
hi,

Quoted 9 lines · YU Bo
Quoted 7 lines

Fix comments to use trailing */ on separste lines.

---

drivers/staging/xgifb/vb_init.c    |    3 ++-
drivers/staging/xgifb/vb_setmode.c |    3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
Quoted 3 lines

You sent me 2 different patches with the identical subject: line, which I can't accept. Please fix them up and send a patch series, with unique subjects.

yes, you are right:) I will fix them up and resend a patch series. Sorry for the noise.
Thanks.

Quoted 4 lines

thanks,

greg k-h