Skip to contentSkip to conversation

dt: add patch to fix failures on newer toolchains

PATCH New gustavo.zacarias at free-electrons.com 3 participants 3 messages Mar 21, 2016 – Mar 22, 2016

lore
Share & tools
lore

gustavo.zacarias at free-electrons.com

author
#0 lore raw

PATCH 1/1 dt: add patch to fix failures on newer toolchains

From: Gustavo Zacarias <[email protected]>

On newer toolchains (glibc >= 2.20) _BSD_SOURCE behaviour was deprecated in favour if the _DEFAULT_SOURCE macro. See man 7 feature_test_macros. Add patch from Fedora to also consider _DEFAULT_SOURCE. Fixes:
http://autobuild.buildroot.net/results/9e2/9e2126b0e68d0d59d37616a268adb810efd8281a/

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/dt/0002-dt-default-source-define.patch | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 package/dt/0002-dt-default-source-define.patch
package/dt/0002-dt-default-source-define.patch new file +20 -0
new file mode 100644
index 0000000..d59faaf
@@ -0,0 +1,20 @@
+Patch taken from Fedora:
+http://pkgs.fedoraproject.org/cgit/rpms/dt.git/commit/dt-default-source-define.patch?id=a3107b34a3efc6af66a5f892514f233bb66eb6b5
+
+_BSD_SOURCE was deprecated, hence switch to use _DEFAULT_SOURCE as well
+to avoid the build from breaking on newer toolchains.
+
+Signed-off-by: Gustavo Zacarias <[email protected]>
+
+diff -rupN dt.v18.32.old/common.h dt.v18.32/common.h
+--- dt.v18.32.old/common.h	2013-03-01 23:52:30.000000000 +0100
++++ dt.v18.32/common.h	2014-09-24 17:41:40.777604710 +0200
+@@ -127,7 +127,7 @@ typedef volatile slarge_t	v_slarge;
+ 
+ #endif /* defined(_WIN64) */
+ 
+-#elif defined(__GNUC__) && defined(_BSD_SOURCE) || defined(SCO) || defined(__QNXNTO__) || defined(SOLARIS) || defined(HP_UX) || defined(AIX) || defined(_NT_SOURCE) 
++#elif defined(__GNUC__) && defined(_BSD_SOURCE) || defined (_DEFAULT_SOURCE) ||  defined(SCO) || defined(__QNXNTO__) || defined(SOLARIS) || defined(HP_UX) || defined(AIX) || defined(_NT_SOURCE) 
+ 
+ #define QuadIsLongLong
+ typedef unsigned long long int	large_t;
Signature · 1 line
2.7.3
#1 lore raw

PATCH 1/1 dt: add patch to fix failures on newer toolchains

Dear Gustavo Zacarias,

Quoted 8 lines · gustavo.zacarias at free-electrons.com

From: Gustavo Zacarias <[email protected]>

On newer toolchains (glibc >= 2.20) _BSD_SOURCE behaviour was deprecated in favour if the _DEFAULT_SOURCE macro. See man 7 feature_test_macros. Add patch from Fedora to also consider _DEFAULT_SOURCE. Fixes:
http://autobuild.buildroot.net/results/9e2/9e2126b0e68d0d59d37616a268adb810efd8281a/

Signed-off-by Gustavo Zacarias <[email protected]>
Reviewed-by Vicente Olivert Riera <[email protected]>
Tested-by Vicente Olivert Riera <[email protected]>

I was in contact with upstream to fix this problem. I have shared the Fedora patch and your explanation with them. Let's hope we can delete this patch from Buildroot in the near future :P

Regards,

Vincent.

Applied
#2 lore raw

PATCH 1/1 dt: add patch to fix failures on newer toolchains

In reply to gustavo.zacarias at free-electrons.com

Hello,

Quoted 7 lines · gustavo.zacarias at free-electrons.com

From: Gustavo Zacarias <[email protected]>

On newer toolchains (glibc >= 2.20) _BSD_SOURCE behaviour was deprecated in favour if the _DEFAULT_SOURCE macro. See man 7 feature_test_macros. Add patch from Fedora to also consider _DEFAULT_SOURCE. Fixes:
http://autobuild.buildroot.net/results/9e2/9e2126b0e68d0d59d37616a268adb810efd8281a/

Quoted 5 lines
Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/dt/0002-dt-default-source-define.patch | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 package/dt/0002-dt-default-source-define.patch

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com