Skip to contentSkip to conversation

drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

PATCH In review Dongwon Kim 3 participants 11 messages Mar 15, 2016 – Apr 11, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

For BXT, Polarity of PORT_PLL_REF_SEL is reversed in its description in Bspec. This bit should be set for "Non-SSC".

---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +1 -1
index 4b636c4..d55b308 100644
@@ -1285,7 +1285,7 @@ static void bxt_ddi_pll_enable(struct drm_i915_private *dev_priv,
 	enum port port = (enum port)pll->id;	/* 1:1 port->PLL mapping */
 
 	temp = I915_READ(BXT_PORT_PLL_ENABLE(port));
-	temp &= ~PORT_PLL_REF_SEL;
+	temp |= PORT_PLL_REF_SEL;
 	/* Non-SSC reference */
 	I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);
 
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 3 lines · Dongwon Kim

For BXT, Polarity of PORT_PLL_REF_SEL is reversed in its description in Bspec. This bit should be set for "Non-SSC".

Thanks for the patch.

In the future please also mention where the change originates from, in this case it is a recent update to the specification (which in turn is based on an internal report of an HDMI HW problem). Looking at that internal report (HSD) it says it only affects BXT-P but not BXT-T, so do we know that the meaning of the bit is inverted on both?

Adding Art for more info.

--Imre

Quoted 18 lines

---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +0 -0
index 4b636c4..d55b308 100644
@@ -1285,7 +1285,7 @@ static void bxt_ddi_pll_enable(struct
 drm_i915_private *dev_priv,

  enum port port = (enum port)pll->id; /* 1:1 port->PLL
mapping */

  temp = I915_READ(BXT_PORT_PLL_ENABLE(port));

drivers/gpu/drm/i915/intel_dpll_mgr.c +1 -1
-	temp &= ~PORT_PLL_REF_SEL;
+	temp |= PORT_PLL_REF_SEL;
Quoted 3 lines

  /* Non-SSC reference */ I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

In reply to Dongwon Kim
== Series Details ==

== Series Details ==

Series: drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
URL : https://patchwork.freedesktop.org/series/4491/
State : failure

== Summary ==

Series 4491v1 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
http://patchwork.freedesktop.org/api/1.0/series/4491/revisions/1/mbox/

Test gem_mmap_gtt:

        Subgroup basic-small-copy:
                dmesg-warn -> PASS       (bsw-nuc-2)
                pass       -> DMESG-WARN (skl-nuci5)
Test gem_ringfill:
        Subgroup basic-default-s3:
                dmesg-warn -> PASS       (skl-i5k-2)
                pass       -> DMESG-WARN (skl-nuci5)
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (snb-x220t)
                dmesg-warn -> PASS       (hsw-brixbox)
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-a:
                dmesg-warn -> PASS       (bdw-nuci7)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                dmesg-warn -> PASS       (bsw-nuc-2)
                pass       -> DMESG-WARN (hsw-brixbox)
bdw-nuci7        total:194  pass:182  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:194  pass:173  dwarn:0   dfail:0   fail:0   skip:21 
bsw-nuc-2        total:194  pass:157  dwarn:0   dfail:0   fail:0   skip:37 
byt-nuc          total:194  pass:155  dwarn:4   dfail:0   fail:0   skip:35 
hsw-brixbox      total:194  pass:171  dwarn:1   dfail:0   fail:0   skip:22 
hsw-gt2          total:194  pass:177  dwarn:0   dfail:0   fail:0   skip:17 
ivb-t430s        total:194  pass:169  dwarn:0   dfail:0   fail:0   skip:25 
skl-i5k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-i7k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-nuci5        total:194  pass:181  dwarn:2   dfail:0   fail:0   skip:11 
snb-x220t        total:194  pass:158  dwarn:1   dfail:0   fail:2   skip:33 

Results at /archive/results/CI_IGT_test/Patchwork_1611/

9f8709ffd099e85e5e116ed7d09f1b8009f40847 drm-intel-nightly: 2016y-03m-16d-10h-30m-26s UTC integration manifest a5aa41667c7524d0df92320530f11dc283c6c95e drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#3 lore raw

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

This error doesn't seem to be related to this specific patch. Similar issue was already filed in Bugzilla a week ago at

https://bugs.freedesktop.org/show_bug.cgi?id=94294

Quoted 43 lines · Patchwork

== Series Details ==

Series: drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
URL : https://patchwork.freedesktop.org/series/4491/
State : failure

== Summary ==

Series 4491v1 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
http://patchwork.freedesktop.org/api/1.0/series/4491/revisions/1/mbox/

Test gem_mmap_gtt:

        Subgroup basic-small-copy:
                dmesg-warn -> PASS       (bsw-nuc-2)
                pass       -> DMESG-WARN (skl-nuci5)
Test gem_ringfill:
        Subgroup basic-default-s3:
                dmesg-warn -> PASS       (skl-i5k-2)
                pass       -> DMESG-WARN (skl-nuci5)
Test kms_flip:
        Subgroup basic-flip-vs-wf_vblank:
                pass       -> FAIL       (snb-x220t)
                dmesg-warn -> PASS       (hsw-brixbox)
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-a:
                dmesg-warn -> PASS       (bdw-nuci7)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                dmesg-warn -> PASS       (bsw-nuc-2)
                pass       -> DMESG-WARN (hsw-brixbox)
bdw-nuci7        total:194  pass:182  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:194  pass:173  dwarn:0   dfail:0   fail:0   skip:21 
bsw-nuc-2        total:194  pass:157  dwarn:0   dfail:0   fail:0   skip:37 
byt-nuc          total:194  pass:155  dwarn:4   dfail:0   fail:0   skip:35 
hsw-brixbox      total:194  pass:171  dwarn:1   dfail:0   fail:0   skip:22 
hsw-gt2          total:194  pass:177  dwarn:0   dfail:0   fail:0   skip:17 
ivb-t430s        total:194  pass:169  dwarn:0   dfail:0   fail:0   skip:25 
skl-i5k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-i7k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-nuci5        total:194  pass:181  dwarn:2   dfail:0   fail:0   skip:11 
snb-x220t        total:194  pass:158  dwarn:1   dfail:0   fail:2   skip:33 
Quoted 5 lines

Results at /archive/results/CI_IGT_test/Patchwork_1611/

9f8709ffd099e85e5e116ed7d09f1b8009f40847 drm-intel-nightly: 2016y-03m-16d-10h-30m-26s UTC integration manifest a5aa41667c7524d0df92320530f11dc283c6c95e drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

PATCH 1/1 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

In reply to Dongwon Kim

For BXT, description of polarities of PORT_PLL_REF_SEL has been reversed for newer Gen9LP steppings according to the recent update in Bspec. This bit now should be set for "Non-SSC" mode for all Gen9LP starting from B0 stepping.

v2: Only B0 and newer stepping should be affected by this change.

---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +9 -1
index 4b636c4..c84589e 100644
@@ -1285,7 +1285,15 @@ static void bxt_ddi_pll_enable(struct drm_i915_private *dev_priv,
 	enum port port = (enum port)pll->id;	/* 1:1 port->PLL mapping */
 
 	temp = I915_READ(BXT_PORT_PLL_ENABLE(port));
-	temp &= ~PORT_PLL_REF_SEL;
+	/*
+	 * Definition of each bit polarity has been changed
+	 * after A1 stepping
+	 */
+	if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_A1))
+		temp &= ~PORT_PLL_REF_SEL;
+	else
+		temp |= PORT_PLL_REF_SEL;
+
 	/* Non-SSC reference */
 	I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);
 
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw
Quoted 7 lines · Dongwon Kim

For BXT, description of polarities of PORT_PLL_REF_SEL has been reversed for newer Gen9LP steppings according to the recent update in Bspec. This bit now should be set for "Non-SSC" mode for all Gen9LP starting from B0 stepping.

v2: Only B0 and newer stepping should be affected by this change.

What is this stepping information based on? It's not in BSpec, could you file a change request to get it added there?

--Imre

Quoted 27 lines

---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 10 +++++++++-

 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +0 -0
index 4b636c4..c84589e 100644
@@ -1285,7 +1285,15 @@ static void bxt_ddi_pll_enable(struct
 drm_i915_private *dev_priv,

  enum port port = (enum port)pll->id; /* 1:1 port->PLL
mapping */

  temp = I915_READ(BXT_PORT_PLL_ENABLE(port));

drivers/gpu/drm/i915/intel_dpll_mgr.c +9 -1
-	temp &= ~PORT_PLL_REF_SEL;
+	/*
+	 * Definition of each bit polarity has been changed
+	 * after A1 stepping
+	 */
+	if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_A1))
+		temp &= ~PORT_PLL_REF_SEL;
+	else
+		temp |= PORT_PLL_REF_SEL;
+
Quoted 3 lines

  /* Non-SSC reference */ I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#6 lore raw
Quoted 6 lines · Imre
Quoted 5 lines · Dongwon Kim

For BXT, description of polarities of PORT_PLL_REF_SEL has been reversed for newer Gen9LP steppings according to the recent update in Bspec. This bit now should be set for "Non-SSC" mode for all Gen9LP starting from B0 stepping.

Quoted 7 lines
Quoted 2 lines

v2: Only B0 and newer stepping should be affected by this change.

What is this stepping information based on? It's not in BSpec, could you file a change request to get it added there?

--Imre

That information is actually missing in Bspec and has to be added. I got this info from the owner of the HSD sighting directly. I will file a change request in Bspec.

Quoted 23 lines
Quoted 23 lines

---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 10 +++++++++-

 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +0 -0
index 4b636c4..c84589e 100644
@@ -1285,7 +1285,15 @@ static void bxt_ddi_pll_enable(struct
 drm_i915_private *dev_priv,

  enum port port = (enum port)pll->id; /* 1:1 port->PLL
mapping */

  temp = I915_READ(BXT_PORT_PLL_ENABLE(port));

drivers/gpu/drm/i915/intel_dpll_mgr.c +4 -1
-	temp &= ~PORT_PLL_REF_SEL;
+	/*
+	 * Definition of each bit polarity has been changed
+	 * after A1 stepping
+	 */
Quoted 8 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_dpll_mgr.c +5 -0
+	if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_A1))
+		temp &= ~PORT_PLL_REF_SEL;
+	else
+		temp |= PORT_PLL_REF_SEL;
+

  /* Non-SSC reference */ I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/1
#7 lore raw
In reply to Dongwon Kim
Quoted 9 lines · Dongwon Kim

For BXT, description of polarities of PORT_PLL_REF_SEL has been reversed for newer Gen9LP steppings according to the recent update in Bspec. This bit now should be set for "Non-SSC" mode for all Gen9LP starting from B0 stepping.

v2: Only B0 and newer stepping should be affected by this change.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94866

Quoted 25 lines

---
 drivers/gpu/drm/i915/intel_dpll_mgr.c | 10 +++++++++-

 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dpll_mgr.c +0 -0
index 4b636c4..c84589e 100644
@@ -1285,7 +1285,15 @@ static void bxt_ddi_pll_enable(struct
 drm_i915_private *dev_priv,

  enum port port = (enum port)pll->id; /* 1:1 port->PLL
mapping */

  temp = I915_READ(BXT_PORT_PLL_ENABLE(port));

drivers/gpu/drm/i915/intel_dpll_mgr.c +9 -1
-	temp &= ~PORT_PLL_REF_SEL;
+	/*
+	 * Definition of each bit polarity has been changed
+	 * after A1 stepping
+	 */
+	if (IS_BXT_REVID(dev_priv, 0, BXT_REVID_A1))
+		temp &= ~PORT_PLL_REF_SEL;
+	else
+		temp |= PORT_PLL_REF_SEL;
+
Quoted 3 lines

  /* Non-SSC reference */ I915_WRITE(BXT_PORT_PLL_ENABLE(port), temp);

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2)

In reply to Dongwon Kim
== Series Details ==

== Series Details ==

Series: drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2)
URL : https://patchwork.freedesktop.org/series/4491/
State : failure

== Summary ==

Series 4491v2 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
http://patchwork.freedesktop.org/api/1.0/series/4491/revisions/2/mbox/

Test drv_module_reload_basic:

                dmesg-warn -> PASS       (hsw-gt2)
Test gem_ringfill:
        Subgroup basic-default-s3:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                dmesg-warn -> PASS       (bdw-ultra)
        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (snb-x220t)
        Subgroup basic-plain-flip:
                pass       -> DMESG-WARN (hsw-gt2)
                dmesg-warn -> PASS       (hsw-brixbox)
Test kms_force_connector_basic:
        Subgroup prune-stale-modes:
                pass       -> SKIP       (snb-x220t)
Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-b-frame-sequence:
                dmesg-warn -> PASS       (snb-x220t)
        Subgroup read-crc-pipe-c-frame-sequence:
                dmesg-warn -> PASS       (hsw-gt2)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                fail       -> DMESG-FAIL (snb-x220t)
        Subgroup basic-rte:
                dmesg-warn -> PASS       (hsw-brixbox)
bdw-nuci7        total:194  pass:182  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:194  pass:173  dwarn:0   dfail:0   fail:0   skip:21 
bsw-nuc-2        total:194  pass:157  dwarn:0   dfail:0   fail:0   skip:37 
byt-nuc          total:194  pass:155  dwarn:4   dfail:0   fail:0   skip:35 
hsw-brixbox      total:194  pass:172  dwarn:0   dfail:0   fail:0   skip:22 
hsw-gt2          total:194  pass:176  dwarn:1   dfail:0   fail:0   skip:17 
ivb-t430s        total:194  pass:169  dwarn:0   dfail:0   fail:0   skip:25 
skl-i5k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-i7k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-nuci5        total:194  pass:183  dwarn:0   dfail:0   fail:0   skip:11 
snb-x220t        total:194  pass:159  dwarn:0   dfail:1   fail:0   skip:34 

Results at /archive/results/CI_IGT_test/Patchwork_1628/

8a9a911d489fe160df173580277983dac5952ed0 drm-intel-nightly: 2016y-03m-17d-10h-02m-10s UTC integration manifest f432d2fe29fb024ac515e2ad2a7a8bb9700e6c70 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#9 lore raw

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2)

Quoted 27 lines · Patchwork

== Series Details ==

Series: drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2)
URL : https://patchwork.freedesktop.org/series/4491/
State : failure

== Summary ==

Series 4491v2 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
http://patchwork.freedesktop.org/api/1.0/series/4491/revisions/2/mbox/

Test drv_module_reload_basic:

                dmesg-warn -> PASS       (hsw-gt2)
Test gem_ringfill:
        Subgroup basic-default-s3:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                dmesg-warn -> PASS       (bdw-ultra)
        Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (snb-x220t)
        Subgroup basic-plain-flip:
                pass       -> DMESG-WARN (hsw-gt2)
                dmesg-warn -> PASS       (hsw-brixbox)
Test kms_force_connector_basic:
        Subgroup prune-stale-modes:
                pass       -> SKIP       (snb-x220t)
Quoted 8 lines

Test kms_pipe_crc_basic:

        Subgroup read-crc-pipe-b-frame-sequence:
                dmesg-warn -> PASS       (snb-x220t)
        Subgroup read-crc-pipe-c-frame-sequence:
                dmesg-warn -> PASS       (hsw-gt2)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                fail       -> DMESG-FAIL (snb-x220t)

This basic-pci-d3-state failure shouldn't be caused by this specific patch. It was filed in bugzilla a few months back and hasn't been fixed yet.

https://bugs.freedesktop.org/show_bug.cgi?id=93123

Quoted 15 lines
        Subgroup basic-rte:
                dmesg-warn -> PASS       (hsw-brixbox)
bdw-nuci7        total:194  pass:182  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:194  pass:173  dwarn:0   dfail:0   fail:0   skip:21 
bsw-nuc-2        total:194  pass:157  dwarn:0   dfail:0   fail:0   skip:37 
byt-nuc          total:194  pass:155  dwarn:4   dfail:0   fail:0   skip:35 
hsw-brixbox      total:194  pass:172  dwarn:0   dfail:0   fail:0   skip:22 
hsw-gt2          total:194  pass:176  dwarn:1   dfail:0   fail:0   skip:17 
ivb-t430s        total:194  pass:169  dwarn:0   dfail:0   fail:0   skip:25 
skl-i5k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-i7k-2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 
skl-nuci5        total:194  pass:183  dwarn:0   dfail:0   fail:0   skip:11 
snb-x220t        total:194  pass:159  dwarn:0   dfail:1   fail:0   skip:34 
Quoted 5 lines

Results at /archive/results/CI_IGT_test/Patchwork_1628/

8a9a911d489fe160df173580277983dac5952ed0 drm-intel-nightly: 2016y-03m-17d-10h-02m-10s UTC integration manifest f432d2fe29fb024ac515e2ad2a7a8bb9700e6c70 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2)

Quoted 40 lines · dw kim
Quoted 30 lines · Patchwork

== Series Details ==

Series: drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit (rev2)
URL   : https://patchwork.freedesktop.org/series/4491/
State : failure

== Summary ==

Series 4491v2 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit
http://patchwork.freedesktop.org/api/1.0/series/4491/revisions/2/mb
ox/

Test drv_module_reload_basic:
                dmesg-warn -> PASS       (hsw-gt2) Test gem_ringfill:
        Subgroup basic-default-s3:
                dmesg-warn -> PASS       (bsw-nuc-2) Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                dmesg-warn -> PASS       (bdw-ultra) Subgroup basic-flip-vs-wf_vblank:
                fail       -> PASS       (snb-x220t) Subgroup basic-plain-flip:
                pass       -> DMESG-WARN (hsw-gt2) dmesg-warn -> PASS       (hsw-brixbox) Test kms_force_connector_basic:
        Subgroup prune-stale-modes:
                pass       -> SKIP       (snb-x220t)

Quoted 8 lines

Test kms_pipe_crc_basic:
        Subgroup read-crc-pipe-b-frame-sequence:
                dmesg-warn -> PASS       (snb-x220t) Subgroup read-crc-pipe-c-frame-sequence:
                dmesg-warn -> PASS       (hsw-gt2) Test pm_rpm:
        Subgroup basic-pci-d3-state:
                fail       -> DMESG-FAIL (snb-x220t)

Quoted 5 lines

This basic-pci-d3-state failure shouldn't be caused by this specific patch. It was filed in bugzilla a few months back and hasn't been fixed yet.

https://bugs.freedesktop.org/show_bug.cgi?id=93123

All the above failures were due to the WM programming w/o powerref issue which was fixed meanwhile.

Thanks for the patch I pushed it to drm-intel-next-queued.

--Imre

Quoted 42 lines
Quoted 35 lines

        Subgroup basic-rte:
                dmesg-warn -> PASS       (hsw-brixbox)

bdw-
nuci7        total:194  pass:182  dwarn:0   dfail:0   fail:0   skip :12
bdw-
ultra        total:194  pass:173  dwarn:0   dfail:0   fail:0   skip :21
bsw-nuc-
2        total:194  pass:157  dwarn:0   dfail:0   fail:0   skip:37 byt-
nuc          total:194  pass:155  dwarn:4   dfail:0   fail:0   skip :35
hsw-
brixbox      total:194  pass:172  dwarn:0   dfail:0   fail:0   skip :22
hsw-
gt2          total:194  pass:176  dwarn:1   dfail:0   fail:0   skip :17
ivb-
t430s        total:194  pass:169  dwarn:0   dfail:0   fail:0   skip :25
skl-i5k-
2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 skl-i7k-
2        total:194  pass:171  dwarn:0   dfail:0   fail:0   skip:23 skl-
nuci5        total:194  pass:183  dwarn:0   dfail:0   fail:0   skip :11
snb-
x220t        total:194  pass:159  dwarn:0   dfail:1   fail:0   skip :34

Quoted 7 lines

Results at /archive/results/CI_IGT_test/Patchwork_1628/

8a9a911d489fe160df173580277983dac5952ed0 drm-intel-nightly: 2016y- 03m-17d-10h-02m-10s UTC integration manifest f432d2fe29fb024ac515e2ad2a7a8bb9700e6c70 drm/i915/bxt: Reversed polarity of PORT_PLL_REF_SEL bit

Quoted 4 lines

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx