Skip to contentSkip to conversation

configs: atmel: unify and update defconfig for Xplained boards

PATCH Superseded Ludovic Desroches 3 participants 14 messages Mar 24, 2016 Arm/Microchip (AT91) SoC support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Ludovic Desroches

author
#0 lore raw

PATCH 1/4 configs: atmel: unify and update defconfig for Xplained boards

Unify and update the defconfig files for Atmel Xplained boards:
- use bootstrap as first stage bootloader
- build all dtb variants
- bump to latest version available on linux4sam github

Signed-off-by Ludovic Desroches <[email protected]>
---
 configs/atmel_sama5d3_xplained_defconfig     | 16 ++++++++------
 configs/atmel_sama5d3_xplained_mmc_defconfig | 32 ++++++++++++++--------------
 configs/atmel_sama5d4_xplained_defconfig     | 16 ++++++++------
 3 files changed, 34 insertions(+), 30 deletions(-)
configs/atmel_sama5d3_xplained_defconfig +9 -7
index 665a3d7..16e4521 100644
@@ -2,26 +2,28 @@ BR2_arm=y
 BR2_cortex_a5=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_INSTRUCTIONS_THUMB2=y
-# Linux headers same as kernel, a 3.18 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/linux4sam/linux-at91.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="03329ca4cf6b94acc5c65b59b2d1f90fdeee0887"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux-4.1-at91"
 BR2_LINUX_KERNEL_DEFCONFIG="sama5"
 BR2_LINUX_KERNEL_ZIMAGE=y
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d3_xplained at91-sama5d3_xplained_pda4 at91-sama5d3_xplained_pda7"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d3_xplained at91-sama5d3_xplained_pda4 at91-sama5d3_xplained_pda7 at91-sama5d3_xplained_pda7b"
 BR2_TARGET_ROOTFS_UBIFS=y
 BR2_TARGET_ROOTFS_UBIFS_LEBSIZE=0x1f000
 BR2_TARGET_ROOTFS_UBI=y
 BR2_TARGET_ROOTFS_UBI_SUBSIZE=2048
 BR2_TARGET_AT91BOOTSTRAP3=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="at91bootstrap-3.x"
 BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="sama5d3_xplainednf_uboot"
 BR2_TARGET_UBOOT=y
-BR2_TARGET_UBOOT_BOARDNAME="sama5d3_xplained_nandflash"
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_GIT=y
 BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/linux4sam/u-boot-at91.git"
-BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="677f3c2340b72131beebace8e96cac17b9569887"
-BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="u-boot-2015.01-at91"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sama5d3_xplained_nandflash"
 BR2_PACKAGE_HOST_SAM_BA=y
configs/atmel_sama5d3_xplained_mmc_defconfig +16 -16
index 1a75767..6de479b 100644
@@ -1,24 +1,24 @@
-# Architecture
 BR2_arm=y
 BR2_cortex_a5=y
 BR2_ARM_ENABLE_VFP=y
-
-# Linux headers same as kernel, a 3.18 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
-
-# Kernel configuration
+BR2_ARM_INSTRUCTIONS_THUMB2=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y
 BR2_LINUX_KERNEL=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="3.18.8"
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/linux4sam/linux-at91.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux-4.1-at91"
 BR2_LINUX_KERNEL_DEFCONFIG="sama5"
 BR2_LINUX_KERNEL_ZIMAGE=y
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d3_xplained"
-
-# First/second stage bootloader
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d3_xplained at91-sama5d3_xplained_pda4 at91-sama5d3_xplained_pda7 at91-sama5d3_xplained_pda7b"
+BR2_TARGET_AT91BOOTSTRAP3=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="at91bootstrap-3.x"
+BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="sama5d3_xplainedsd_uboot"
 BR2_TARGET_UBOOT=y
-BR2_TARGET_UBOOT_BOARDNAME="sama5d3_xplained_mmc"
-BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2015.01"
-BR2_TARGET_UBOOT_FORMAT_IMG=y
-BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/linux4sam/u-boot-at91.git"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="u-boot-2015.01-at91"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sama5d3_xplained_mmc"
configs/atmel_sama5d4_xplained_defconfig +9 -7
index 0991f86..7ab37dc 100644
@@ -3,16 +3,15 @@ BR2_cortex_a5=y
 BR2_ARM_ENABLE_NEON=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_INSTRUCTIONS_THUMB2=y
-# Linux headers same as kernel, a 3.18 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/linux4sam/linux-at91.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="03329ca4cf6b94acc5c65b59b2d1f90fdeee0887"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux-4.1-at91"
 BR2_LINUX_KERNEL_DEFCONFIG="sama5"
 BR2_LINUX_KERNEL_ZIMAGE=y
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
-BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d4_xplained"
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d4_xplained at91-sama5d4_xplained_hdmi at91-sama5d4_xplained_pda4 at91-sama5d4_xplained_pda7 at91-sama5d4_xplained_pda7b"
 BR2_TARGET_ROOTFS_UBIFS=y
 BR2_TARGET_ROOTFS_UBIFS_LEBSIZE=0x3e000
 BR2_TARGET_ROOTFS_UBIFS_MINIOSIZE=0x1000

@@ -21,11 +20,14 @@ BR2_TARGET_ROOTFS_UBI=y
 BR2_TARGET_ROOTFS_UBI_PEBSIZE=0x40000
 BR2_TARGET_ROOTFS_UBI_SUBSIZE=0
 BR2_TARGET_AT91BOOTSTRAP3=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="at91bootstrap-3.x"
 BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="sama5d4_xplainednf_uboot_secure"
 BR2_TARGET_UBOOT=y
-BR2_TARGET_UBOOT_BOARDNAME="sama5d4_xplained_nandflash"
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_GIT=y
 BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/linux4sam/u-boot-at91.git"
-BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="677f3c2340b72131beebace8e96cac17b9569887"
-BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="u-boot-2015.01-at91"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sama5d4_xplained_nandflash"
 BR2_PACKAGE_HOST_SAM_BA=y
Signature · 1 line
2.5.0
author
#1 lore raw

PATCH 2/4 configs: atmel: add support for sama5d4 xplained boot from sd card

This variant of SAMA5D4 Xplained defconfig file allows to boot from a SD card.

Signed-off-by Ludovic Desroches <[email protected]>
---
 configs/atmel_sama5d4_xplained_mmc_defconfig | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 configs/atmel_sama5d4_xplained_mmc_defconfig
configs/atmel_sama5d4_xplained_mmc_defconfig new file +26 -0
new file mode 100644
index 0000000..df285de
@@ -0,0 +1,26 @@
+BR2_arm=y
+BR2_cortex_a5=y
+BR2_ARM_ENABLE_NEON=y
+BR2_ARM_ENABLE_VFP=y
+BR2_ARM_INSTRUCTIONS_THUMB2=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/linux4sam/linux-at91.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux-4.1-at91"
+BR2_LINUX_KERNEL_DEFCONFIG="sama5"
+BR2_LINUX_KERNEL_ZIMAGE=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d4_xplained at91-sama5d4_xplained_hdmi at91-sama5d4_xplained_pda4 at91-sama5d4_xplained_pda7 at91-sama5d4_xplained_pda7b"
+BR2_TARGET_AT91BOOTSTRAP3=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="at91bootstrap-3.x"
+BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="sama5d4_xplainedsd_uboot_secure"
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/linux4sam/u-boot-at91.git"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="u-boot-2015.01-at91"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sama5d4_xplained_mmc"
+BR2_PACKAGE_HOST_SAM_BA=y
Signature · 1 line
2.5.0
author
#2 lore raw

PATCH 3/4 configs: atmel: add sama5d2 xplained support

In reply to Ludovic Desroches

This defconfig allows to build all the components to boot from a sd card on a SAMA5D2 Xplained board. For more details, please read the board/atmel/xplained/readme.txt file.

Signed-off-by Ludovic Desroches <[email protected]>
---
 configs/atmel_sama5d2_xplained_mmc_defconfig | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 configs/atmel_sama5d2_xplained_mmc_defconfig
configs/atmel_sama5d2_xplained_mmc_defconfig new file +26 -0
new file mode 100644
index 0000000..4e15d94
@@ -0,0 +1,26 @@
+BR2_arm=y
+BR2_cortex_a5=y
+BR2_ARM_ENABLE_NEON=y
+BR2_ARM_ENABLE_VFP=y
+BR2_ARM_FPU_VFPV4=y
+BR2_ARM_INSTRUCTIONS_THUMB2=y
+BR2_KERNEL_HEADERS_4_1=y
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_GIT=y
+BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/linux4sam/linux-at91.git"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux-4.1-at91"
+BR2_LINUX_KERNEL_DEFCONFIG="sama5"
+BR2_LINUX_KERNEL_ZIMAGE=y
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="at91-sama5d2_xplained at91-sama5d2_xplained_pda4 at91-sama5d2_xplained_pda7 at91-sama5d2_xplained_pda7b"
+BR2_TARGET_AT91BOOTSTRAP3=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="at91bootstrap-3.x"
+BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="sama5d2_xplainedsd_uboot"
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
+BR2_TARGET_UBOOT_CUSTOM_GIT=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_URL="https://github.com/linux4sam/u-boot-at91.git"
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="u-boot-2015.01-at91"
+BR2_TARGET_UBOOT_BOARD_DEFCONFIG="sama5d2_xplained_mmc"
Signature · 1 line
2.5.0
#3 lore raw

PATCH 3/4 configs: atmel: add sama5d2 xplained support

Hello,

Quoted 16 lines · Ludovic Desroches

This defconfig allows to build all the components to boot from a sd card on a SAMA5D2 Xplained board. For more details, please read the board/atmel/xplained/readme.txt file.

Signed-off-by Ludovic Desroches <[email protected]>
---
 configs/atmel_sama5d2_xplained_mmc_defconfig | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 configs/atmel_sama5d2_xplained_mmc_defconfig
configs/atmel_sama5d2_xplained_mmc_defconfig new file +0 -0
new file mode 100644
index 0000000..4e15d94

configs/atmel_sama5d2_xplained_mmc_defconfig line 7

Quoted 7 lines
configs/atmel_sama5d2_xplained_mmc_defconfig new file +7 -0
@@ -0,0 +1,26 @@
+BR2_arm=y
+BR2_cortex_a5=y
+BR2_ARM_ENABLE_NEON=y
+BR2_ARM_ENABLE_VFP=y
+BR2_ARM_FPU_VFPV4=y
+BR2_ARM_INSTRUCTIONS_THUMB2=y
+BR2_KERNEL_HEADERS_4_1=y

Not good, we want to use the "Same as kernel" option for the kernel headers.

(And same comment as for the other patches in terms of selecting the kernel/u-boot/at91bootstrap3 versions).

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#4 lore raw

PATCH 4/4 board/atmel/xplained/readme.txt: update documentation

In reply to Ludovic Desroches

This documentation is not only dedicated to SAMA5D3 Xplained boards. The procedure is the same for SAMA5D4 and SAMA5D2.
sfdisk, -u (--unit) option is obsolete on latest versions.

Signed-off-by Ludovic Desroches <[email protected]>
---
 board/atmel/xplained/readme.txt | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)
board/atmel/xplained/readme.txt +12 -11
index ba45122..4833e72 100644
@@ -1,9 +1,8 @@
-Atmel SAMA5D3 Xplained board
-============================
+Atmel SAMA5Dx Xplained boards
+=============================
 
 This document explains how to set up a basic Buildroot system on the
-Atmel SAMA5D3 Xplained board, whose main site is
-http://www.atmel.com/tools/ATSAMA5D3-XPLD.aspx. Additional details can
+Atmel SAMA5D2/SAMA5D3/SAMA5D4 Xplained boards. Additional details can
 also be found on the http://www.at91.com/linux4sam/bin/view/Linux4SAM/
 web site.
 

@@ -16,7 +15,9 @@ from NAND flash, see board/atmel/readme.txt
 Configuring and building Buildroot
 ----------------------------------
 
-  make atmel_sama5d3_xplained_mmc_defconfig
+Use the alternative mmc defconfig for you board. For instance:
+
+  make atmel_sama5d2_xplained_mmc_defconfig
   make
 
 Preparing the SD card

@@ -27,8 +28,8 @@ FAT16 partition for the bootloaders, kernel image and Device Tree
 blob, and one ext4 partition for the root filesystem. To partition the
 SD card:
 
-sudo sfdisk -uM /dev/mmcblk0 <<EOF
-,64,6
+sudo sfdisk /dev/mmcblk0 <<EOF
+,64MiB,6
 ;
 EOF
 

@@ -52,10 +53,10 @@ sudo mount /dev/mmcblk0p2 /media/rootfs
 Copy the bootloaders, kernel image and Device Tree blob to the first
 partition:
 
-cp output/images/u-boot-spl.bin /media/boot/boot.bin
-cp output/images/u-boot.img /media/boot/u-boot.img
-cp output/images/zImage /media/boot/zImage
-cp output/images/at91-sama5d3_xplained.dtb /media/boot/at91-sama5d3_xplained.dtb
+cp output/images/boot.bin /media/boot/
+cp output/images/u-boot.bin /media/boot/
+cp output/images/zImage /media/boot/
+cp output/images/at91-sama5d2_xplained.dtb /media/boot/
 
 Extract the root filesystem to the second partition:
Signature · 1 line
2.5.0
#5 lore raw

PATCH 4/4 board/atmel/xplained/readme.txt: update documentation

Hello,

Quoted 8 lines · Ludovic Desroches

This documentation is not only dedicated to SAMA5D3 Xplained boards. The procedure is the same for SAMA5D4 and SAMA5D2.
sfdisk, -u (--unit) option is obsolete on latest versions.

Signed-off-by Ludovic Desroches <[email protected]>
---
 board/atmel/xplained/readme.txt | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

There is some duplication of information between board/atmel/readme.txt (which also covers SAMA5 Xplained platforms) and board/atmel/xplained/readme.txt.

Perhaps board/atmel/xplained/readme.txt should be removed entirely, and board/atmel/readme.txt contain all the information?

Seems like board/atmel/readme.txt covers how to flash on NAND, while board/atmel/xplained/readme.txt covers how to use a SD card based booting. Definitely not very clear when looking at the readme.txt location.

Another possible (but future, and unrelated) improvement is to use genimage to generate a ready-to-use SD card image, which automatically contains the VFAT and ext4 partitions.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#6 lore raw

PATCH 4/4 board/atmel/xplained/readme.txt: update documentation

Hi,

Quoted 7 lines · Thomas Petazzoni

Hello,

Quoted 4 lines · Ludovic Desroches

This documentation is not only dedicated to SAMA5D3 Xplained boards. The procedure is the same for SAMA5D4 and SAMA5D2.
sfdisk, -u (--unit) option is obsolete on latest versions.

Quoted 9 lines
Quoted 4 lines
Signed-off-by Ludovic Desroches <[email protected]>
---
 board/atmel/xplained/readme.txt | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

There is some duplication of information between board/atmel/readme.txt (which also covers SAMA5 Xplained platforms) and board/atmel/xplained/readme.txt.

I agree.

Quoted 8 lines

Perhaps board/atmel/xplained/readme.txt should be removed entirely, and board/atmel/readme.txt contain all the information?

Seems like board/atmel/readme.txt covers how to flash on NAND, while board/atmel/xplained/readme.txt covers how to use a SD card based booting. Definitely not very clear when looking at the readme.txt location.

I will try to do a quick merge.

Quoted 4 lines

Another possible (but future, and unrelated) improvement is to use genimage to generate a ready-to-use SD card image, which automatically contains the VFAT and ext4 partitions.

We have some scripts which do this but at the moment I am not sure they can handle all possible errors. For sure, it will be great if we can achieve it in the future.

Regards

Ludovic

#7 lore raw

PATCH 4/4 board/atmel/xplained/readme.txt: update documentation

Hello,

Quoted 7 lines · Ludovic Desroches
Quoted 3 lines

Another possible (but future, and unrelated) improvement is to use genimage to generate a ready-to-use SD card image, which automatically contains the VFAT and ext4 partitions.

We have some scripts which do this but at the moment I am not sure they can handle all possible errors. For sure, it will be great if we can achieve it in the future.

There's no real need for a script, genimage does most of the work. Look at board/acmesystems/arietta-g25/genimage.cfg and board/acmesystems/arietta-g25/post-image.sh, which are doing this for an Atmel based platform.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#8 lore raw

PATCH 4/4 board/atmel/xplained/readme.txt: update documentation

Quoted 8 lines · Thomas Petazzoni

Hello,

Quoted 4 lines · Ludovic Desroches
Quoted 3 lines

Another possible (but future, and unrelated) improvement is to use genimage to generate a ready-to-use SD card image, which automatically contains the VFAT and ext4 partitions.

Quoted 9 lines
Quoted 3 lines

We have some scripts which do this but at the moment I am not sure they can handle all possible errors. For sure, it will be great if we can achieve it in the future.

There's no real need for a script, genimage does most of the work. Look at board/acmesystems/arietta-g25/genimage.cfg and board/acmesystems/arietta-g25/post-image.sh, which are doing this for an Atmel based platform.

Interesting, thank for the tip.

Regards

Ludovic

#9 lore raw

PATCH 1/4 configs: atmel: unify and update defconfig for Xplained boards

In reply to Ludovic Desroches

Hello,

I'm adding in Cc: Alexandre Belloni, who has worked on Atmel defconfigs in the past.

Quoted 1 line

- use bootstrap as first stage bootloader

As opposed to? Did you mean at91bootstrap3 rather than "bootstrap"?

Quoted 6 lines · Ludovic Desroches
configs/atmel_sama5d3_xplained_defconfig +0 -0
index 665a3d7..16e4521 100644
@@ -2,26 +2,28 @@ BR2_arm=y
 BR2_cortex_a5=y

configs/atmel_sama5d3_xplained_defconfig BR2_arm=y · line 9

Quoted 10 lines
configs/atmel_sama5d3_xplained_defconfig +2 -3
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_INSTRUCTIONS_THUMB2=y
-# Linux headers same as kernel, a 3.18 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/linux4sam/linux-at91.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="03329ca4cf6b94acc5c65b59b2d1f90fdeee0887"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux-4.1-at91"

This is not good. linux-4.1-at91 is a branch name, which means that the actual source behind this branch name will change over time, making this defconfig non-reproducible. You must stick to a tag or a commit id.

configs/atmel_sama5d3_xplained_defconfig BR2_arm=y · line 21

Quoted 4 lines
configs/atmel_sama5d3_xplained_defconfig +3 -0
 BR2_TARGET_AT91BOOTSTRAP3=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="at91bootstrap-3.x"

Same comment as for the kernel.

configs/atmel_sama5d3_xplained_defconfig BR2_arm=y · line 27

Quoted 9 lines
configs/atmel_sama5d3_xplained_defconfig +2 -3
 BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="sama5d3_xplainednf_uboot"
 BR2_TARGET_UBOOT=y
-BR2_TARGET_UBOOT_BOARDNAME="sama5d3_xplained_nandflash"
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_GIT=y
 BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/linux4sam/u-boot-at91.git"
-BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="677f3c2340b72131beebace8e96cac17b9569887"
-BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="u-boot-2015.01-at91"

Same comment.

(and ditto for the other defconfigs)

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#10 lore raw

PATCH 1/4 configs: atmel: unify and update defconfig for Xplained boards

Hi Thomas,

Quoted 5 lines · Thomas Petazzoni

Hello,

I'm adding in Cc: Alexandre Belloni, who has worked on Atmel defconfigs in the past.

He was in Cc.

Quoted 4 lines
Quoted 1 line

- use bootstrap as first stage bootloader

As opposed to? Did you mean at91bootstrap3 rather than "bootstrap"?

As opposed to u-boot spl which is less tested than at91bootstrap3.

Quoted 14 lines · Ludovic Desroches
Quoted 13 lines
configs/atmel_sama5d3_xplained_defconfig +1 -2
index 665a3d7..16e4521 100644
@@ -2,26 +2,28 @@ BR2_arm=y
 BR2_cortex_a5=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_INSTRUCTIONS_THUMB2=y
-# Linux headers same as kernel, a 3.18 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1=y
 BR2_LINUX_KERNEL=y
Quoted 9 lines

configs/atmel_sama5d3_xplained_defconfig BR2_arm=y · line 9

Quoted 4 lines
configs/atmel_sama5d3_xplained_defconfig +1 -1
 BR2_LINUX_KERNEL_CUSTOM_GIT=y
 BR2_LINUX_KERNEL_CUSTOM_REPO_URL="https://github.com/linux4sam/linux-at91.git"
-BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="03329ca4cf6b94acc5c65b59b2d1f90fdeee0887"
+BR2_LINUX_KERNEL_CUSTOM_REPO_VERSION="linux-4.1-at91"

This is not good. linux-4.1-at91 is a branch name, which means that the actual source behind this branch name will change over time, making this defconfig non-reproducible. You must stick to a tag or a commit id.

In fact it was the plan in order to prevent the need to update these defconfig files. If I must stick to a tag then I will use linux4sam releases.

Quoted 19 lines

configs/atmel_sama5d3_xplained_defconfig BR2_arm=y · line 21

Quoted 4 lines
configs/atmel_sama5d3_xplained_defconfig +3 -0
 BR2_TARGET_AT91BOOTSTRAP3=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_GIT=y
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_URL="https://github.com/linux4sam/at91bootstrap.git"
+BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="at91bootstrap-3.x"

Same comment as for the kernel.

configs/atmel_sama5d3_xplained_defconfig BR2_arm=y · line 27

Quoted 9 lines
configs/atmel_sama5d3_xplained_defconfig +2 -3
 BR2_TARGET_AT91BOOTSTRAP3_DEFCONFIG="sama5d3_xplainednf_uboot"
 BR2_TARGET_UBOOT=y
-BR2_TARGET_UBOOT_BOARDNAME="sama5d3_xplained_nandflash"
+BR2_TARGET_UBOOT_BUILD_SYSTEM_KCONFIG=y
 BR2_TARGET_UBOOT_CUSTOM_GIT=y
 BR2_TARGET_UBOOT_CUSTOM_REPO_URL="git://github.com/linux4sam/u-boot-at91.git"
-BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="677f3c2340b72131beebace8e96cac17b9569887"
-BR2_TARGET_UBOOT_SPL=y
+BR2_TARGET_UBOOT_CUSTOM_REPO_VERSION="u-boot-2015.01-at91"

Same comment.

Quoted 5 lines

(and ditto for the other defconfigs)

Thanks!

Thomas

Regards

Ludovic

#11 lore raw

PATCH 1/4 configs: atmel: unify and update defconfig for Xplained boards

Hello,

Quoted 7 lines · Ludovic Desroches
Quoted 4 lines · Thomas Petazzoni

Hello,

I'm adding in Cc: Alexandre Belloni, who has worked on Atmel defconfigs in the past.

He was in Cc.

Gah, my bad. Alex must have chosen in his mailing list preferences to remove duplicates or something like that, because on the mailing list, your Cc to Alex was clearly not visible. Hence my comment.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

- use bootstrap as first stage bootloader

As opposed to? Did you mean at91bootstrap3 rather than "bootstrap"?

As opposed to u-boot spl which is less tested than at91bootstrap3.

OK. I think Alex has a somewhat different opinion on the matter, but I guess that if the vendor recommends to use at91bootstrap3, we should use this solution in our defconfig.

Quoted 7 lines
Quoted 3 lines

This is not good. linux-4.1-at91 is a branch name, which means that the actual source behind this branch name will change over time, making this defconfig non-reproducible. You must stick to a tag or a commit id.

In fact it was the plan in order to prevent the need to update these defconfig files. If I must stick to a tag then I will use linux4sam releases.

We really want our defconfigs to be reproducible in terms of bootloader/kernel versions. Otherwise, what people will build/test is not something that the person submitting the defconfig has tested.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#12 lore raw

PATCH 1/4 configs: atmel: unify and update defconfig for Xplained boards

Quoted 18 lines · Thomas Petazzoni

Hello,

Quoted 7 lines · Ludovic Desroches
Quoted 4 lines · Thomas Petazzoni

Hello,

I'm adding in Cc: Alexandre Belloni, who has worked on Atmel defconfigs in the past.

He was in Cc.

Gah, my bad. Alex must have chosen in his mailing list preferences to remove duplicates or something like that, because on the mailing list, your Cc to Alex was clearly not visible. Hence my comment.

Quoted 2 lines
Quoted 2 lines
Quoted 1 line

- use bootstrap as first stage bootloader

Quoted 8 lines
Quoted 3 lines
Quoted 1 line

As opposed to? Did you mean at91bootstrap3 rather than "bootstrap"?

As opposed to u-boot spl which is less tested than at91bootstrap3.

OK. I think Alex has a somewhat different opinion on the matter, but I guess that if the vendor recommends to use at91bootstrap3, we should use this solution in our defconfig.

I know he doesn't share the same opinion. At the moment u-boot spl is not working on SAMA5D2. Moreover, latest enhancements for at91bootstrap are probably not ported to u-boot spl.

Quoted 11 lines
Quoted 7 lines
Quoted 3 lines

This is not good. linux-4.1-at91 is a branch name, which means that the actual source behind this branch name will change over time, making this defconfig non-reproducible. You must stick to a tag or a commit id.

In fact it was the plan in order to prevent the need to update these defconfig files. If I must stick to a tag then I will use linux4sam releases.

We really want our defconfigs to be reproducible in terms of bootloader/kernel versions. Otherwise, what people will build/test is not something that the person submitting the defconfig has tested.

There is pros and cons for this choice but I understand. I will resend the patches with a tag.

Quoted 3 lines

Thanks!

Thomas

Regards

Ludovic

#13 lore raw

PATCH 1/4 configs: atmel: unify and update defconfig for Xplained boards

Quoted 6 lines · Ludovic Desroches
Quoted 6 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

- use bootstrap as first stage bootloader

As opposed to? Did you mean at91bootstrap3 rather than "bootstrap"?

As opposed to u-boot spl which is less tested than at91bootstrap3.

Quoted 9 lines
Quoted 4 lines

OK. I think Alex has a somewhat different opinion on the matter, but I guess that if the vendor recommends to use at91bootstrap3, we should use this solution in our defconfig.

I know he doesn't share the same opinion. At the moment u-boot spl is not working on SAMA5D2. Moreover, latest enhancements for at91bootstrap are probably not ported to u-boot spl.

Still, the configs I submitted were using at91bootstrap ;) The one using u-boot spl was initially from Ryan Barnett.

Signature · 3 lines
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com