package/qwt : prepared package for other versions of Qt.

Hello,

package/qwt/Config.in if BR2_PACKAGE_QWT · line 26

Quoted 2 lines · David Picard

package/qwt/Config.in +2 -0

+	depends on (BR2_PACKAGE_HAS_LIBGLES && BR2_PACKAGE_HAS_LIBEG) || \
+		BR2_PACKAGE_QT5_GL_AVAILABLE

I know I told you to use this, but in fact I think a more correct dependency is:

	(BR2_PACKAGE_HAS_LIBGLES && BR2_PACKAGE_HAS_LIBEGL && BR2_PACKAGE_QT) || \
	(BR2_PACKAGE_QT5_GL_AVAILABLE && BR2_PACKAGE_QT5)

so that we are sure that if we're using Qt, we have the dependencies that are needed to have OpenGL support in Qt, and if we have Qt5, we have the dependencies that are needed to have OpenGL support in Qt5.

I've applied after fixing this.

Also, after applying, I noticed there was a typo: BR2_PACKAGE_HAS_LIBEG in your patch should have been BR2_PACKAGE_HAS_LIBEGL. I've fixed that up with a following commit, as I only noticed while replying to this e-mail.

Thanks!

Thomas

Reformatted the package configuration to make it more generic. It will thus be easier to handle more than one version of Qt. Indeed, multiple versions of Qt are compatible with the current Qwt. Dropped comment, considered uninformative.

Signed-off-by David Picard <[email protected]>

---
 package/qwt/Config.in | 10 +++-------
 package/qwt/qwt.mk    |  5 ++++-
 2 files changed, 7 insertions(+), 8 deletions(-)

Hello,

Quoted 9 lines · David Picard

Reformatted the package configuration to make it more generic. It will thus be easier to handle more than one version of Qt. Indeed, multiple versions of Qt are compatible with the current Qwt. Dropped comment, considered uninformative.

Signed-off-by David Picard <[email protected]>

---
  package/qwt/Config.in | 10 +++-------
  package/qwt/qwt.mk    |  5 ++++-
  2 files changed, 7 insertions(+), 8 deletions(-)

I've tweaked the commit log to explain a bit more that we are switching to use "select" rather than "depends on" for the Qt sub-options, and applied. Thanks!

Thomas

I get an error like :
make[1]: *** no rule to make target "qt5", needed by "<BASEDIR>/build/qwt-6.1.2/.stamp_configured". Stopping.

Wouldn't it be because of line 15 in package/qwt/qwt.mk ?
https://git.buildroot.net/buildroot/tree/package/qwt/qwt.mk?id=a976ee0dc834c56e67e1c832ded00ce23b5ccdb0

I changed it from :
QWT_DEPENDENCIES += qt5
to :
QWT_DEPENDENCIES += qt5base

and then I could build on. It seems like "qt5" is not a valid target name. By the way, where can you find what are the valid values ?

Hello,

Quoted 11 lines · David Picard

I get an error like :
make[1]: *** no rule to make target "qt5", needed by "<BASEDIR>/build/qwt-6.1.2/.stamp_configured". Stopping.

Wouldn't it be because of line 15 in package/qwt/qwt.mk ?
https://git.buildroot.net/buildroot/tree/package/qwt/qwt.mk?id=a976ee0dc834c56e67e1c832ded00ce23b5ccdb0

I changed it from :
QWT_DEPENDENCIES += qt5
to :
QWT_DEPENDENCIES += qt5base

Correct. Can you send a new patch to fix this?

Quoted 2 lines

and then I could build on. It seems like "qt5" is not a valid target name. By the way, where can you find what are the valid values ?

The possible values are the list of all packages in Buildroot. Whenever you have a .mk file that calls one of the generic-package, autotools-package, *-package macro, then there is a make target with the same name.

Best regards,

Thomas

I saw you merged the patches into the master branch. So should I make a new patch based on the current master, or issue a new version of the 2 previous patches ?