Skip to contentSkip to conversation

drm/exynos: mic: remove some dead code

PATCH In review Dan Carpenter 2 participants 4 messages Mar 17, 2016 – Mar 25, 2016

Subsystems (4)
DRM drivers Kernel janitors Arm Samsung Exynos DRM drivers for Exynos
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 2/2 drm/exynos: mic: remove some dead code

We know "ret" is zero and the test makes static checkers complain so let's delete this printk.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/exynos/exynos_drm_mic.c +0 -2
index 890c9b1..12db353 100644
@@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
 		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
 
 	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
-	if (ret)
-		DRM_ERROR("mic: Failed to read system register\n");
 }
 
 static int mic_sw_reset(struct exynos_mic *mic)
maintainer
#1 lore raw

Hi Dan,

2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:

Quoted 10 lines

We know "ret" is zero and the test makes static checkers complain so let's delete this printk.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/exynos/exynos_drm_mic.c +0 -0
index 890c9b1..12db353 100644

drivers/gpu/drm/exynos/exynos_drm_mic.c static void mic_set_path(struct exynos_mic *mic, bool enable) · line 134

Quoted 5 lines
drivers/gpu/drm/exynos/exynos_drm_mic.c +0 -2
@@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
 		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
 
 	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
-	if (ret)
-		DRM_ERROR("mic: Failed to read system register\n");

I think we missed to keep return value from regmap_write function,

	ret = regmap_write(mic->sysreg, ....);
	if (ret)
		...

Thanks,
Inki Dae

Quoted 9 lines
drivers/gpu/drm/exynos/exynos_drm_mic.c +0 -1
 }
 
 static int mic_sw_reset(struct exynos_mic *mic)
--

To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#2 lore raw

PATCH v2 2/2 drm/exynos: fix a warning message

The "ret = regmap_write()" assignment was missing so this error message is never printed.

Signed-off-by Dan Carpenter <[email protected]>

---
v2: in v1 I just deleted the error message

drivers/gpu/drm/exynos/exynos_drm_mic.c +1 -1
index 9869d70..ea2ea17 100644
@@ -129,7 +129,7 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
 	} else
 		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
 
-	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
+	ret = regmap_write(mic->sysreg, DSD_CFG_MUX, val);
 	if (ret)
 		DRM_ERROR("mic: Failed to read system register\n");
 }
author
#3 lore raw
In reply to Inki Dae
Quoted 15 lines · Inki Dae

Hi Dan,

2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:

Quoted 12 lines

We know "ret" is zero and the test makes static checkers complain so let's delete this printk.

Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/exynos/exynos_drm_mic.c +0 -0
index 890c9b1..12db353 100644
@@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
 		val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
Quoted 8 lines

drivers/gpu/drm/exynos/exynos_drm_mic.c static void mic_set_path(struct exynos_mic *mic, bool enable) · line 134

Quoted 3 lines
drivers/gpu/drm/exynos/exynos_drm_mic.c +0 -2
 	regmap_write(mic->sysreg, DSD_CFG_MUX, val);
-	if (ret)
-		DRM_ERROR("mic: Failed to read system register\n");

I think we missed to keep return value from regmap_write function,

	ret = regmap_write(mic->sysreg, ....);
	if (ret)
		...

Yeah. You're right.

regards,
dan carpenter