Skip to contentSkip to conversation

Staging: comedi: Fix 'unsigned' warning style

PATCH In review Aniket Sharma 2 participants 2 messages Mar 27, 2016 – Mar 29, 2016 Staging

lore
Share & tools
lore

Aniket Sharma

author
#0 lore raw

PATCH 1/1 Staging: comedi: Fix 'unsigned' warning style

This patch fixes the checkpatch.pl warning:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+ unsigned runflags;

WARNING: Prefer 'unsigned int' to bare use of 'unsigned' +struct comedi_device *comedi_dev_get_from_minor(unsigned minor);

Signed-off-by Aniket Sharma <[email protected]>
---
 drivers/staging/comedi/comedidev.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/comedidev.h +2 -2
index 1158072..dcb6376 100644
@@ -173,7 +173,7 @@ struct comedi_subdevice {
 
 	void *lock;
 	void *busy;
-	unsigned runflags;
+	unsigned int runflags;
 	spinlock_t spin_lock;	/* generic spin-lock for COMEDI and drivers */
 
 	unsigned int io_bits;

@@ -566,7 +566,7 @@ struct comedi_device {
 
 void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
 
-struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
+struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
 int comedi_dev_put(struct comedi_device *dev);
 
 bool comedi_is_subdevice_running(struct comedi_subdevice *s);
Signature · 1 line
1.9.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 28 lines · Aniket Sharma

This patch fixes the checkpatch.pl warning:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
+ unsigned runflags;

WARNING: Prefer 'unsigned int' to bare use of 'unsigned' +struct comedi_device *comedi_dev_get_from_minor(unsigned minor);

Signed-off-by Aniket Sharma <[email protected]>
---
  drivers/staging/comedi/comedidev.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/comedi/comedidev.h +1 -1
index 1158072..dcb6376 100644
@@ -173,7 +173,7 @@ struct comedi_subdevice {
 
  	void *lock;
  	void *busy;
-	unsigned runflags;
+	unsigned int runflags;
  	spinlock_t spin_lock;	/* generic spin-lock for COMEDI and drivers */
 
  	unsigned int io_bits;

drivers/staging/comedi/comedidev.h struct comedi_device { · line 572

Quoted 8 lines
drivers/staging/comedi/comedidev.h +1 -1
@@ -566,7 +566,7 @@ struct comedi_device {
 
  void comedi_event(struct comedi_device *dev, struct comedi_subdevice *s);
 
-struct comedi_device *comedi_dev_get_from_minor(unsigned minor);
+struct comedi_device *comedi_dev_get_from_minor(unsigned int minor);
  int comedi_dev_put(struct comedi_device *dev);
 
  bool comedi_is_subdevice_running(struct comedi_subdevice *s);

Thanks!

Reviewed-by Ian Abbott <[email protected]>
Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-