Skip to contentSkip to conversation

leds: core: add color LED sysfs extension

PATCH Superseded Heiner Kallweit 2 participants 2 messages Mar 1, 2016 – Mar 29, 2016 LED

v5 of 8 Superseded Latest is v8 →

lore
Share & tools
lore

Heiner Kallweit

author
#0 lore raw

PATCH v5 2/4 leds: core: add color LED sysfs extension

Extend brightness sysfs property handling to deal with monochrome and color mode as well.

Signed-off-by Heiner Kallweit <[email protected]>

---
v2:
- split from patch 1
v3:
- moved one change (led_is_off) to patch 1
v4:
- changed printf format string to %#.6x
v5:
- no changes

---
 drivers/leds/led-class.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/leds/led-class.c +5 -2
index 007a5b3..8a3748a 100644
@@ -32,7 +32,10 @@ static ssize_t brightness_show(struct device *dev,
 	/* no lock needed for this */
 	led_update_brightness(led_cdev);
 
-	return sprintf(buf, "%u\n", led_cdev->brightness);
+	if (led_cdev->brightness > LED_FULL)
+		return sprintf(buf, "%#.6x\n", led_cdev->brightness);
+	else
+		return sprintf(buf, "%u\n", led_cdev->brightness);
 }
 
 static ssize_t brightness_store(struct device *dev,

@@ -49,7 +52,7 @@ static ssize_t brightness_store(struct device *dev,
 		goto unlock;
 	}
 
-	ret = kstrtoul(buf, 10, &state);
+	ret = kstrtoul(buf, 0, &state);
 	if (ret)
 		goto unlock;
Signature · 1 line
2.7.1
#1 lore raw
Quoted 23 lines · Heiner Kallweit

Extend brightness sysfs property handling to deal with monochrome and color mode as well.

Signed-off-by Heiner Kallweit <[email protected]>

---
v2:
- split from patch 1
v3:
- moved one change (led_is_off) to patch 1
v4:
- changed printf format string to %#.6x
v5:
- no changes

---
 drivers/leds/led-class.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
drivers/leds/led-class.c +0 -0
index 007a5b3..8a3748a 100644
@@ -32,7 +32,10 @@ static ssize_t brightness_show(struct device *dev,
 	/* no lock needed for this */

drivers/leds/led-class.c static ssize_t brightness_show(struct device *dev, · line 41

Quoted 10 lines
drivers/leds/led-class.c +4 -1
 	led_update_brightness(led_cdev);
 
-	return sprintf(buf, "%u\n", led_cdev->brightness);
+	if (led_cdev->brightness > LED_FULL)
+		return sprintf(buf, "%#.6x\n", led_cdev->brightness);
+	else
+		return sprintf(buf, "%u\n", led_cdev->brightness);
 }
 
 static ssize_t brightness_store(struct device *dev,

No... I don't think you should change interface for existing file like this.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html