Skip to contentSkip to conversation

Compilation error: ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!

DISCUSSION Marcin Mirosław 2 participants 7 messages Mar 29, 2016 – Mar 30, 2016 bcache (block layer cache)

lore
Share & tools
lore
#0 lore raw

Hi again!
Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
Kernel: arch/x86/boot/bzImage is ready (#6)
Building modules, stage 2.
MODPOST 538 modules
ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "pagecache_block_put" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "pagecache_add_get" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "__pagecache_block_get" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "__pagecache_block_put" [drivers/md/bcache/bcache.ko] undefined!
ERROR: "pagecache_block_get" [drivers/md/bcache/bcache.ko] undefined! scripts/Makefile.modpost:91: polecenia dla obiektu '__modpost' nie powiodły się
make[1]: *** [__modpost] Błąd 1
Makefile:1108: recipe for target 'modules' failed
make: *** [modules] Error 2

Marcin

#1 lore raw
Quoted 6 lines · Marcin Mirosław

Hi again!
Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
Kernel: arch/x86/boot/bzImage is ready (#6)
Building modules, stage 2.
MODPOST 538 modules
ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!

Thanks, fixed.

Also pushed another small patch for the memory allocation failure in the lz4 code - it ought to work reliably in practice now.

#2 lore raw

W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:

Quoted 8 lines · Marcin Mirosław
Quoted 6 lines

Hi again!
Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
Kernel: arch/x86/boot/bzImage is ready (#6)
Building modules, stage 2.
MODPOST 538 modules
ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!

Quoted 4 lines

Thanks, fixed.

Also pushed another small patch for the memory allocation failure in the lz4 code - it ought to work reliably in practice now.

I didn't expect such fast fix for lz4:)
BTW, I'd like to ask how should I update my working tree via git. I run git pull in tree to fetch your fix and (again) I got conflict:
git pull
remote: Counting objects: 251, done.
remote: Compressing objects: 100% (52/52), done.
remote: Total 251 (delta 219), reused 231 (delta 199) Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done. Resolving deltas: 100% (219/219), completed with 63 local objects. From https://evilpiepirate.org/git/linux-bcache
+ 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
+ ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
update)
Auto-merging mm/filemap.c
CONFLICT (content): Merge conflict in mm/filemap.c Auto-merging drivers/md/bcache/fs-io.c
CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c Auto-merging drivers/md/bcache/extents.h
CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h Automatic merge failed; fix conflicts and then commit the result.

How I should update bcache git tree?
Marcin

#3 lore raw
Quoted 36 lines · Marcin Mirosław

W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:

Quoted 8 lines · Marcin Mirosław
Quoted 6 lines

Hi again!
Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
Kernel: arch/x86/boot/bzImage is ready (#6)
Building modules, stage 2.
MODPOST 538 modules
ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!

Quoted 4 lines

Thanks, fixed.

Also pushed another small patch for the memory allocation failure in the lz4 code - it ought to work reliably in practice now.

I didn't expect such fast fix for lz4:)
BTW, I'd like to ask how should I update my working tree via git. I run git pull in tree to fetch your fix and (again) I got conflict:
git pull
remote: Counting objects: 251, done.
remote: Compressing objects: 100% (52/52), done.
remote: Total 251 (delta 219), reused 231 (delta 199) Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done. Resolving deltas: 100% (219/219), completed with 63 local objects. From https://evilpiepirate.org/git/linux-bcache
+ 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
+ ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
update)
Auto-merging mm/filemap.c
CONFLICT (content): Merge conflict in mm/filemap.c Auto-merging drivers/md/bcache/fs-io.c
CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c Auto-merging drivers/md/bcache/extents.h
CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h Automatic merge failed; fix conflicts and then commit the result.

Quoted 1 line

How I should update bcache git tree?

git reset --hard origin/bcache-dev

#4 lore raw

W dniu 30.03.2016 o 10:20, Kent Overstreet pisze:

Quoted 37 lines · Marcin Mirosław
Quoted 36 lines

W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:

Quoted 8 lines · Marcin Mirosław
Quoted 6 lines

Hi again!
Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
Kernel: arch/x86/boot/bzImage is ready (#6)
Building modules, stage 2.
MODPOST 538 modules
ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!

Quoted 4 lines

Thanks, fixed.

Also pushed another small patch for the memory allocation failure in the lz4 code - it ought to work reliably in practice now.

I didn't expect such fast fix for lz4:)
BTW, I'd like to ask how should I update my working tree via git. I run git pull in tree to fetch your fix and (again) I got conflict:
git pull
remote: Counting objects: 251, done.
remote: Compressing objects: 100% (52/52), done.
remote: Total 251 (delta 219), reused 231 (delta 199) Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done. Resolving deltas: 100% (219/219), completed with 63 local objects. From https://evilpiepirate.org/git/linux-bcache
+ 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
+ ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
update)
Auto-merging mm/filemap.c
CONFLICT (content): Merge conflict in mm/filemap.c Auto-merging drivers/md/bcache/fs-io.c
CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c Auto-merging drivers/md/bcache/extents.h
CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h Automatic merge failed; fix conflicts and then commit the result.

Quoted 3 lines
Quoted 1 line

How I should update bcache git tree?

git reset --hard origin/bcache-dev

Hmm, I'm using:
url = https://evilpiepirate.org/git/linux-bcache.git
branch "bcache-dev"

should I expect fix of building in this branch? I'm still at commit 97951d039d3991d29035390ba5f0497af4e32ca3
bcachefs: fix fallocate + compression

#5 lore raw
Quoted 43 lines · Marcin Mirosław

W dniu 30.03.2016 o 10:20, Kent Overstreet pisze:

Quoted 37 lines · Marcin Mirosław
Quoted 36 lines

W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:

Quoted 8 lines · Marcin Mirosław
Quoted 6 lines

Hi again!
Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
Kernel: arch/x86/boot/bzImage is ready (#6)
Building modules, stage 2.
MODPOST 538 modules
ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!

Quoted 4 lines

Thanks, fixed.

Also pushed another small patch for the memory allocation failure in the lz4 code - it ought to work reliably in practice now.

I didn't expect such fast fix for lz4:)
BTW, I'd like to ask how should I update my working tree via git. I run git pull in tree to fetch your fix and (again) I got conflict:
git pull
remote: Counting objects: 251, done.
remote: Compressing objects: 100% (52/52), done.
remote: Total 251 (delta 219), reused 231 (delta 199) Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done. Resolving deltas: 100% (219/219), completed with 63 local objects. From https://evilpiepirate.org/git/linux-bcache
+ 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
+ ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
update)
Auto-merging mm/filemap.c
CONFLICT (content): Merge conflict in mm/filemap.c Auto-merging drivers/md/bcache/fs-io.c
CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c Auto-merging drivers/md/bcache/extents.h
CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h Automatic merge failed; fix conflicts and then commit the result.

Quoted 3 lines
Quoted 1 line

How I should update bcache git tree?

git reset --hard origin/bcache-dev

Quoted 7 lines

Hmm, I'm using:
url = https://evilpiepirate.org/git/linux-bcache.git
branch "bcache-dev"

should I expect fix of building in this branch? I'm still at commit 97951d039d3991d29035390ba5f0497af4e32ca3
bcachefs: fix fallocate + compression

yeah, that commit should work - I squashed the fix with the faulty commit, that's why you got the merge conflicts

#6 lore raw

W dniu 30.03.2016 o 12:14, Kent Overstreet pisze:

Quoted 48 lines · Marcin Mirosław
Quoted 47 lines

W dniu 30.03.2016 o 10:20, Kent Overstreet pisze:

Quoted 37 lines · Marcin Mirosław
Quoted 36 lines

W dniu 29.03.2016 o 23:01, Kent Overstreet pisze:

Quoted 8 lines · Marcin Mirosław
Quoted 6 lines

Hi again!
Since commit 53b6273b131a864947a2c55a18c07e86487e0a87 I'm getting errors:
Kernel: arch/x86/boot/bzImage is ready (#6)
Building modules, stage 2.
MODPOST 538 modules
ERROR: "pagecache_add_put" [drivers/md/bcache/bcache.ko] undefined!

Quoted 4 lines

Thanks, fixed.

Also pushed another small patch for the memory allocation failure in the lz4 code - it ought to work reliably in practice now.

I didn't expect such fast fix for lz4:)
BTW, I'd like to ask how should I update my working tree via git. I run git pull in tree to fetch your fix and (again) I got conflict:
git pull
remote: Counting objects: 251, done.
remote: Compressing objects: 100% (52/52), done.
remote: Total 251 (delta 219), reused 231 (delta 199) Receiving objects: 100% (251/251), 36.73 KiB | 0 bytes/s, done. Resolving deltas: 100% (219/219), completed with 63 local objects. From https://evilpiepirate.org/git/linux-bcache
+ 800353d...97951d0 bcache-dev -> origin/bcache-dev (forced update)
+ ad59dfd...eda3e8b bcache-dev-wip -> origin/bcache-dev-wip (forced
update)
Auto-merging mm/filemap.c
CONFLICT (content): Merge conflict in mm/filemap.c Auto-merging drivers/md/bcache/fs-io.c
CONFLICT (content): Merge conflict in drivers/md/bcache/fs-io.c Auto-merging drivers/md/bcache/extents.h
CONFLICT (content): Merge conflict in drivers/md/bcache/extents.h Automatic merge failed; fix conflicts and then commit the result.

Quoted 3 lines
Quoted 1 line

How I should update bcache git tree?

git reset --hard origin/bcache-dev

Hmm, I'm using:
url = https://evilpiepirate.org/git/linux-bcache.git
branch "bcache-dev"

Quoted 6 lines
Quoted 3 lines

should I expect fix of building in this branch? I'm still at commit 97951d039d3991d29035390ba5f0497af4e32ca3
bcachefs: fix fallocate + compression

yeah, that commit should work - I squashed the fix with the faulty commit, that's why you got the merge conflicts

I still live in svn world with immutable commits;)
Thank you for help. I'm using bcachefs with lz4 since a few hours and I don't have any problem.

Marcin