Skip to contentSkip to conversation

ARM: DRA722: Add ID detect for Silicon Rev 2.0

PATCH New Vishal Mahaveer 3 participants 3 messages Mar 9, 2016 – Mar 30, 2016

Subsystems (3)
Arm (32-bit) Arm sub-architectures OMAP2+ support
lore
Share & tools
lore

Vishal Mahaveer

author
#0 lore raw

PATCH 1/1 ARM: DRA722: Add ID detect for Silicon Rev 2.0

From: Vishal Mahaveer <[email protected]>

Silicon Rev 2.0 is a minor variant of Rev 1.0. Rev 2.0 is an incremental revision with various fixes including the following:
- Reset logic fixes
- Few asymetric aging logic fixes
- Ethernet speed fixes
- EDMA fixes for McASP

Signed-off-by Vishal Mahaveer <[email protected]>
---
 arch/arm/mach-omap2/id.c  |    4 ++--
 arch/arm/mach-omap2/soc.h |    1 +
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/id.c +2 -2
index 8a2ae82..84ee602 100644
@@ -667,9 +667,9 @@ void __init dra7xxx_check_revision(void)
 		case 0:
 			omap_revision = DRA722_REV_ES1_0;
 			break;
+		case 1:
 		default:
-			/* If we have no new revisions */
-			omap_revision = DRA722_REV_ES1_0;
+			omap_revision = DRA722_REV_ES2_0;
 			break;
 		}
 		break;
arch/arm/mach-omap2/soc.h +1 -0
index 83d3547..464e73f 100644
@@ -471,6 +471,7 @@ IS_OMAP_TYPE(3430, 0x3430)
 #define DRA752_REV_ES1_1	(DRA7XX_CLASS | (0x52 << 16) | (0x11 << 8))
 #define DRA752_REV_ES2_0	(DRA7XX_CLASS | (0x52 << 16) | (0x20 << 8))
 #define DRA722_REV_ES1_0	(DRA7XX_CLASS | (0x22 << 16) | (0x10 << 8))
+#define DRA722_REV_ES2_0	(DRA7XX_CLASS | (0x22 << 16) | (0x20 << 8))
 
 void omap2xxx_check_revision(void);
 void omap3xxx_check_revision(void);
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 ARM: DRA722: Add ID detect for Silicon Rev 2.0

Quoted 6 lines · Vishal Mahaveer

From: Vishal Mahaveer <[email protected]>

Silicon Rev 2.0 is a minor variant of Rev 1.0. Rev 2.0 is an incremental revision with various fixes including the following:
- Reset logic fixes
- Few asymetric aging logic fixes

minor:
s/asymetric/asymmetric/

Quoted 31 lines

- Ethernet speed fixes
- EDMA fixes for McASP

Signed-off-by Vishal Mahaveer <[email protected]>
---
 arch/arm/mach-omap2/id.c  |    4 ++--
 arch/arm/mach-omap2/soc.h |    1 +
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/id.c +2 -2
index 8a2ae82..84ee602 100644
@@ -667,9 +667,9 @@ void __init dra7xxx_check_revision(void)
 		case 0:
 			omap_revision = DRA722_REV_ES1_0;
 			break;
+		case 1:
 		default:
-			/* If we have no new revisions */
-			omap_revision = DRA722_REV_ES1_0;
+			omap_revision = DRA722_REV_ES2_0;
 			break;
 		}
 		break;
arch/arm/mach-omap2/soc.h +0 -0
index 83d3547..464e73f 100644

arch/arm/mach-omap2/soc.h IS_OMAP_TYPE(3430, 0x3430) · line 477

Quoted 7 lines
arch/arm/mach-omap2/soc.h +1 -0
@@ -471,6 +471,7 @@ IS_OMAP_TYPE(3430, 0x3430)
 #define DRA752_REV_ES1_1	(DRA7XX_CLASS | (0x52 << 16) | (0x11 << 8))
 #define DRA752_REV_ES2_0	(DRA7XX_CLASS | (0x52 << 16) | (0x20 << 8))
 #define DRA722_REV_ES1_0	(DRA7XX_CLASS | (0x22 << 16) | (0x10 << 8))
+#define DRA722_REV_ES2_0	(DRA7XX_CLASS | (0x22 << 16) | (0x20 << 8))
 
 void omap2xxx_check_revision(void);
 void omap3xxx_check_revision(void);

otherwise,
for me:

Acked-by Nishanth Menon <[email protected]>
Signature · 2 lines
Regards,
Nishanth Menon
maintainer
#2 lore raw

PATCH 1/1 ARM: DRA722: Add ID detect for Silicon Rev 2.0

Quoted 9 lines · Nishanth Menon
Quoted 6 lines · Vishal Mahaveer

From: Vishal Mahaveer <[email protected]>

Silicon Rev 2.0 is a minor variant of Rev 1.0. Rev 2.0 is an incremental revision with various fixes including the following:
- Reset logic fixes
- Few asymetric aging logic fixes

minor:
s/asymetric/asymmetric/

I'll update that while applying.

Quoted 35 lines
Quoted 35 lines

- Ethernet speed fixes
- EDMA fixes for McASP

Signed-off-by Vishal Mahaveer <[email protected]>
---
 arch/arm/mach-omap2/id.c  |    4 ++--
 arch/arm/mach-omap2/soc.h |    1 +
 2 files changed, 3 insertions(+), 2 deletions(-)
arch/arm/mach-omap2/id.c +2 -2
index 8a2ae82..84ee602 100644
@@ -667,9 +667,9 @@ void __init dra7xxx_check_revision(void)
 		case 0:
 			omap_revision = DRA722_REV_ES1_0;
 			break;
+		case 1:
 		default:
-			/* If we have no new revisions */
-			omap_revision = DRA722_REV_ES1_0;
+			omap_revision = DRA722_REV_ES2_0;
 			break;
 		}
 		break;
arch/arm/mach-omap2/soc.h +1 -0
index 83d3547..464e73f 100644
@@ -471,6 +471,7 @@ IS_OMAP_TYPE(3430, 0x3430)
 #define DRA752_REV_ES1_1	(DRA7XX_CLASS | (0x52 << 16) | (0x11 << 8))
 #define DRA752_REV_ES2_0	(DRA7XX_CLASS | (0x52 << 16) | (0x20 << 8))
 #define DRA722_REV_ES1_0	(DRA7XX_CLASS | (0x22 << 16) | (0x10 << 8))
+#define DRA722_REV_ES2_0	(DRA7XX_CLASS | (0x22 << 16) | (0x20 << 8))
Quoted 6 lines

arch/arm/mach-omap2/soc.h IS_OMAP_TYPE(3430, 0x3430) · line 477

Quoted 3 lines
arch/arm/mach-omap2/soc.h +0 -0
 void omap2xxx_check_revision(void);
 void omap3xxx_check_revision(void);

otherwise,
for me:

Acked-by Nishanth Menon <[email protected]>

Applying into omap-for-v4.6/fixes thanks.

Tony