Skip to contentSkip to conversation

wilc1000-firmware: new package

PATCH New Ludovic Desroches 3 participants 5 messages Apr 1, 2016 – Apr 4, 2016

lore
Share & tools
lore

Ludovic Desroches

author
#0 lore raw

PATCH 1/1 wilc1000-firmware: new package

Firmware for Atmel Wilc1000 wireless device.

Signed-off-by Ludovic Desroches <[email protected]>
---
 package/Config.in                              |  1 +
 package/wilc1000-firmware/Config.in            |  6 ++++++
 package/wilc1000-firmware/wilc1000-firmware.mk | 25 +++++++++++++++++++++++++
 3 files changed, 32 insertions(+)
 create mode 100644 package/wilc1000-firmware/Config.in
 create mode 100644 package/wilc1000-firmware/wilc1000-firmware.mk
package/Config.in +1 -0
index 1467f33..661b010 100644
@@ -336,6 +336,7 @@ menu "Firmware"
 	source "package/rpi-firmware/Config.in"
 	source "package/sunxi-boards/Config.in"
 	source "package/ux500-firmware/Config.in"
+	source "package/wilc1000-firmware/Config.in"
 	source "package/zd1211-firmware/Config.in"
 endmenu
 	source "package/a10disp/Config.in"
package/wilc1000-firmware/Config.in new file +6 -0
new file mode 100644
index 0000000..df8a7a6
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_WILC1000_FIRMWARE
+	bool "wilc1000-firmware"
+	help
+	  Firmware for Atmel Wilc1000 wireless device
+
+	  https://github.com/linux4sc/wireless-firmware.git
package/wilc1000-firmware/wilc1000-firmware.mk new file +25 -0
new file mode 100644
index 0000000..a3ec86f
@@ -0,0 +1,25 @@
+################################################################################
+#
+# wilc1000-firmware
+#
+################################################################################
+
+WILC1000_FIRMWARE_VERSION = 14.1
+WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
+WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip
+WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin
+
+WILC1000_FIRMWARE_LICENSE = PROPRIETARY
+
+define WILC1000_FIRMWARE_EXTRACT_CMDS
+	$(UNZIP) -d $(BUILD_DIR) $(DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
+	mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
+	rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
+endef
+
+define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
+	$(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/atmel/
+	cp $(@D)/$(WILC1000_FIRMWARE_DRIVER_FILE) $(TARGET_DIR)/lib/firmware/atmel/
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.5.0
#1 lore raw

PATCH 1/1 wilc1000-firmware: new package

Hi Ludovic,

Quoted 9 lines · Ludovic Desroches
package/wilc1000-firmware/wilc1000-firmware.mk new file +2 -0
new file mode 100644
index 0000000..a3ec86f
@@ -0,0 +1,25 @@
+################################################################################
+#

package/wilc1000-firmware/wilc1000-firmware.mk line 12

Quoted 10 lines
package/wilc1000-firmware/wilc1000-firmware.mk new file +10 -0
+# wilc1000-firmware
+#
+################################################################################
+
+WILC1000_FIRMWARE_VERSION = 14.1
+WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
+WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip
+WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin
+
+WILC1000_FIRMWARE_LICENSE = PROPRIETARY

No LICENSE_FILES? Is it distributable? I would guess it is, but we have no indication.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
author
#2 lore raw

PATCH 1/1 wilc1000-firmware: new package

Hi Baruch,

Quoted 17 lines · Baruch Siach

Hi Ludovic,

Quoted 14 lines · Ludovic Desroches
package/wilc1000-firmware/wilc1000-firmware.mk new file +7 -0
new file mode 100644
index 0000000..a3ec86f
@@ -0,0 +1,25 @@
+################################################################################
+#
+# wilc1000-firmware
+#
+################################################################################
+
+WILC1000_FIRMWARE_VERSION = 14.1
Quoted 8 lines

package/wilc1000-firmware/wilc1000-firmware.mk line 12

Quoted 5 lines
package/wilc1000-firmware/wilc1000-firmware.mk new file +5 -0
+WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
+WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip
+WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin
+
+WILC1000_FIRMWARE_LICENSE = PROPRIETARY

No LICENSE_FILES? Is it distributable? I would guess it is, but we have no indication.

Unfortunately there is no license file in this repository.

Yes it is distributable, I thought _REDISTRIBUTE was only used if not.

Regards

Ludovic

#3 lore raw

PATCH 1/1 wilc1000-firmware: new package

In reply to Ludovic Desroches

Hello,

Quoted 7 lines · Ludovic Desroches

Firmware for Atmel Wilc1000 wireless device.

Signed-off-by Ludovic Desroches <[email protected]>
---
 package/Config.in                              |  1 +
 package/wilc1000-firmware/Config.in            |  6 ++++++
 package/wilc1000-firmware/wilc1000-firmware.mk | 25 +++++++++++++++++++++++++

A hash file was missing.

package/wilc1000-firmware/wilc1000-firmware.mk line 9

Quoted 3 lines
package/wilc1000-firmware/wilc1000-firmware.mk new file +3 -0
+WILC1000_FIRMWARE_VERSION = 14.1
+WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
+WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip

What a crappy file name, which doesn't even contain the name of the project :-/

Quoted 1 line

+WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin

This variable is not really needed, it's only used once

package/wilc1000-firmware/wilc1000-firmware.mk line 22

Quoted 11 lines
package/wilc1000-firmware/wilc1000-firmware.mk new file +11 -0
+WILC1000_FIRMWARE_LICENSE = PROPRIETARY
+
+define WILC1000_FIRMWARE_EXTRACT_CMDS
+	$(UNZIP) -d $(BUILD_DIR) $(DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
+	mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
+	rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
+endef
+
+define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
+	$(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/atmel/
+	cp $(@D)/$(WILC1000_FIRMWARE_DRIVER_FILE) $(TARGET_DIR)/lib/firmware/atmel/

I've simplified this to use just one $(INSTALL) -D -m 0644 invocation, which is sufficient since 1/ there is only one file to install and 2/ option -D tells $(INSTALL) to create sub-directories as necessary.

Applied with those fixes. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 wilc1000-firmware: new package

Quoted 11 lines · Thomas Petazzoni

Hello,

Quoted 7 lines · Ludovic Desroches

Firmware for Atmel Wilc1000 wireless device.

Signed-off-by Ludovic Desroches <[email protected]>
---
 package/Config.in                              |  1 +
 package/wilc1000-firmware/Config.in            |  6 ++++++
 package/wilc1000-firmware/wilc1000-firmware.mk | 25 +++++++++++++++++++++++++
Quoted 8 lines

A hash file was missing.

package/wilc1000-firmware/wilc1000-firmware.mk line 9

Quoted 3 lines
package/wilc1000-firmware/wilc1000-firmware.mk new file +3 -0
+WILC1000_FIRMWARE_VERSION = 14.1
+WILC1000_FIRMWARE_SITE = https://github.com/linux4sc/wireless-firmware/archive
+WILC1000_FIRMWARE_SOURCE = v$(WILC1000_FIRMWARE_VERSION)_Firmware.zip

What a crappy file name, which doesn't even contain the name of the project :-/

I agree.

Quoted 21 lines
Quoted 2 lines

+WILC1000_FIRMWARE_DRIVER_FILE = wilc1003_firmware.bin

This variable is not really needed, it's only used once

package/wilc1000-firmware/wilc1000-firmware.mk line 22

Quoted 11 lines
package/wilc1000-firmware/wilc1000-firmware.mk new file +11 -0
+WILC1000_FIRMWARE_LICENSE = PROPRIETARY
+
+define WILC1000_FIRMWARE_EXTRACT_CMDS
+	$(UNZIP) -d $(BUILD_DIR) $(DL_DIR)/$(WILC1000_FIRMWARE_SOURCE)
+	mv $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware/* $(@D)
+	rmdir $(BUILD_DIR)/wireless-firmware-$(WILC1000_FIRMWARE_VERSION)_Firmware
+endef
+
+define WILC1000_FIRMWARE_INSTALL_TARGET_CMDS
+	$(INSTALL) -d -m 0755 $(TARGET_DIR)/lib/firmware/atmel/
+	cp $(@D)/$(WILC1000_FIRMWARE_DRIVER_FILE) $(TARGET_DIR)/lib/firmware/atmel/

I've simplified this to use just one $(INSTALL) -D -m 0644 invocation, which is sufficient since 1/ there is only one file to install and 2/ option -D tells $(INSTALL) to create sub-directories as necessary.

Quoted 1 line

Applied with those fixes. Thanks!

Great, thanks.

Regards

Ludovic