Skip to contentSkip to conversation

Ballooning on TPS!=HPS hosts

Qemu-devel Dr. David Alan Gilbert 2 participants 2 messages Mar 31, 2016 – Apr 1, 2016 virtio core

lore
Share & tools
lore
#0 lore raw

Hi,
I was reading the balloon code and am confused as to how/if ballooning
works on hosts where the host page size is larger than the target page size.

static void balloon_page(void *addr, int deflate)
{

#if defined(__linux__)
    if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
                                         kvm_has_sync_mmu())) {
        qemu_madvise(addr, TARGET_PAGE_SIZE,
                deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
    }

#endif
}

The virtio-balloon code only does stuff through ballon_page, and an madvise DONTNEED should fail if you try and do it on a size smaller than the host page size. So does ballooning work on Power/ARM?

Am I misunderstanding this?

Of course looking at the above we won't actually generate an error since we don't check the return of qemu_madvise.

We have three sizes:
a) host page size
b) target page size
c) VIRTIO_BALLOON_PFN_SHIFT

c == 12 (4k) for everyone

1) I think the virtio-balloon code needs to coallesce adjecent requests and call balloon_page on whole chunks at once passing a length.
2) why does balloon_page use TARGET_PAGE_SIZE, ignoring anything else shouldn't it be 1 << VIRTIO_BALLOON_PFN_SHIFT ?
3) I'm guessing the guest kernel doesn't know the host page size, so how can it know what size chunks of balloon to work in?

Dave

--
Dr. David Alan Gilbert / [email protected] / Manchester, UK

#1 lore raw

CC'ing virtualization list.

Quoted 16 lines · Dr. David Alan Gilbert

Hi,
I was reading the balloon code and am confused as to how/if ballooning
works on hosts where the host page size is larger than the target page size.

static void balloon_page(void *addr, int deflate)
{

#if defined(__linux__)
    if (!qemu_balloon_is_inhibited() && (!kvm_enabled() ||
                                         kvm_has_sync_mmu())) {
        qemu_madvise(addr, TARGET_PAGE_SIZE,
                deflate ? QEMU_MADV_WILLNEED : QEMU_MADV_DONTNEED);
    }

#endif
}

Quoted 6 lines

The virtio-balloon code only does stuff through ballon_page, and an madvise DONTNEED should fail if you try and do it on a size smaller than the host page size. So does ballooning work on Power/ARM?

Am I misunderstanding this?

I think you're right. Guess no one's tested this in such scenarios yet.

Quoted 2 lines

Of course looking at the above we won't actually generate an error since we don't check the return of qemu_madvise.

... at least we can deflate the balloon in case the madvise fails, so the guest can use the pages it's given us.

Quoted 8 lines

We have three sizes:
a) host page size
b) target page size
c) VIRTIO_BALLOON_PFN_SHIFT

c == 12 (4k) for everyone

Quoted 6 lines

1) I think the virtio-balloon code needs to coallesce adjecent requests and call balloon_page on whole chunks at once passing a length.
2) why does balloon_page use TARGET_PAGE_SIZE, ignoring anything else shouldn't it be 1 << VIRTIO_BALLOON_PFN_SHIFT ?
3) I'm guessing the guest kernel doesn't know the host page size, so how can it know what size chunks of balloon to work in?

Thanks,

Amit