drm/i915: Correct stepping check for WaRsDisableCoarsePowerGating
Subsystems (2)
PATCH 1/1 drm/i915: Correct stepping check for WaRsDisableCoarsePowerGating
This WA is applied in two different places for SKL GT3, GT4 until E0. Previously we were applying until F0 at one place.
A macro was introduced in the below commit to replace both usages but now we apply this WA until F0 in both places, this patch correct this.
commit 06e668ac91c93eb10bd21dfcc8891493722db29a
Author: Mika Kuoppala <[email protected]>
Date: Wed Dec 16 19:18:37 2015 +0200
drm/i915: Apply broader WaRsDisableCoarsePowerGating for guc also
--- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.h +1 -1
@@ -2637,7 +2637,7 @@ struct drm_i915_cmd_table {/* WaRsDisableCoarsePowerGating:skl,bxt */ #define NEEDS_WaRsDisableCoarsePowerGating (dev) (IS_BXT_REVID(dev, 0, BXT_REVID_A1) || \ ((IS_SKL_GT3(dev) || IS_SKL_GT4(dev)) && \ - IS_SKL_REVID(dev, 0, SKL_REVID_F0))) + IS_SKL_REVID(dev, 0, SKL_REVID_E0)))/* * dp aux and gmbus irq on gen4 seems to be able to generate legacy interrupts * even when in MSI mode. This results in spurious interrupt warnings if the
Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Arun Siluvery
This WA is applied in two different places for SKL GT3, GT4 until E0. Previously we were applying until F0 at one place.
A macro was introduced in the below commit to replace both usages but now we apply this WA until F0 in both places, this patch correct this.
commit
06e668ac91c93eb10bd21dfcc8891493722db29a
Author: Mika Kuoppala <[email protected]>
Date: Wed Dec 16 19:18:37 2015 +0200drm/i915: Apply broader WaRsDisableCoarsePowerGating for guc also
So here you're essentially reverting
commit 344df9809f45 ("drm/i915/skl: Disable coarse power gating up until F0") without any justification. Why is that the right thing to do?
Quoted 28 lines
Cc Sagar Arun Kamble <[email protected]>Cc Mika Kuoppala <[email protected]>Signed-off-by Arun Siluvery <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.h +1
-1@@ -2637,7 +2637,7 @@ struct drm_i915_cmd_table {/* WaRsDisableCoarsePowerGating:skl,bxt */ #define NEEDS_WaRsDisableCoarsePowerGating (dev) (IS_BXT_REVID(dev, 0, BXT_REVID_A1) || \ ((IS_SKL_GT3(dev) || IS_SKL_GT4(dev)) && \ - IS_SKL_REVID(dev, 0, SKL_REVID_F0))) + IS_SKL_REVID(dev, 0, SKL_REVID_E0)))/* * dp aux and gmbus irq on gen4 seems to be able to generate legacy interrupts * even when in MSI mode. This results in spurious interrupt warnings if the Signature · 6 lines
1.9.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 11 lines · Ville Syrjälä
Quoted 10 lines · Arun Siluvery
This WA is applied in two different places for SKL GT3, GT4 until E0. Previously we were applying until F0 at one place.
A macro was introduced in the below commit to replace both usages but now we apply this WA until F0 in both places, this patch correct this.
commit 06e668ac91c93eb10bd21dfcc8891493722db29a Author: Mika Kuoppala <[email protected]> Date: Wed Dec 16 19:18:37 2015 +0200
Quoted 6 lines
Quoted 1 line
drm/i915: Apply broader WaRsDisableCoarsePowerGating for guc also
So here you're essentially reverting
commit344df9809f45("drm/i915/skl: Disable coarse power gating up until F0") without any justification. Why is that the right thing to do?
Sorry I didn't check this, I was going through some other changes and found it is different.
commit 344df9809f45 ("drm/i915/skl: Disable coarse power gating up until F0") seems pretty important which explains the difference.
This patch can be ignored.
regards
Arun
Quoted 24 lines
Quoted 24 lines
Cc Sagar Arun Kamble <[email protected]>Cc Mika Kuoppala <[email protected]>Signed-off-by Arun Siluvery <[email protected]>--- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/gpu/drm/i915/i915_drv.h +1
-2@@ -2637,7 +2637,7 @@ struct drm_i915_cmd_table {/* WaRsDisableCoarsePowerGating:skl,bxt */ #define NEEDS_WaRsDisableCoarsePowerGating (dev) (IS_BXT_REVID(dev, 0, BXT_REVID_A1) || \ ((IS_SKL_GT3(dev) || IS_SKL_GT4(dev)) && \ - IS_SKL_REVID(dev, 0, SKL_REVID_F0))) + IS_SKL_REVID(dev, 0, SKL_REVID_E0)))/* * dp aux and gmbus irq on gen4 seems to be able to generate legacy interrupts * even when in MSI mode. This results in spurious interrupt warnings if the -- 1.9.1
Quoted 5 lines
Quoted 4 lines
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Correct stepping check for WaRsDisableCoarsePowerGating
In reply to Arun Siluvery== Series Details ==
== Series Details ==
Series: drm/i915: Correct stepping check for WaRsDisableCoarsePowerGating
URL : https://patchwork.freedesktop.org/series/5187/
State : success
== Summary ==
Series 5187v1 drm/i915: Correct stepping check for WaRsDisableCoarsePowerGating
http://patchwork.freedesktop.org/api/1.0/series/5187/revisions/1/mbox/
Test gem_exec_suspend:
Subgroup basic-s3:
incomplete -> PASS (hsw-gt2)
Test kms_flip:
Subgroup basic-flip-vs-modeset:
pass -> DMESG-WARN (ilk-hp8440p) UNSTABLE
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (ilk-hp8440p) UNSTABLEbdw-nuci7 total:196 pass:184 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:196 pass:175 dwarn:0 dfail:0 fail:0 skip:21 bsw-nuc-2 total:196 pass:159 dwarn:0 dfail:0 fail:0 skip:37 byt-nuc total:196 pass:161 dwarn:0 dfail:0 fail:0 skip:35 hsw-brixbox total:196 pass:174 dwarn:0 dfail:0 fail:0 skip:22 hsw-gt2 total:196 pass:179 dwarn:0 dfail:0 fail:0 skip:17 ilk-hp8440p total:196 pass:131 dwarn:1 dfail:0 fail:0 skip:64 ivb-t430s total:196 pass:171 dwarn:0 dfail:0 fail:0 skip:25 snb-dellxps total:196 pass:162 dwarn:0 dfail:0 fail:0 skip:34 snb-x220t total:196 pass:161 dwarn:0 dfail:0 fail:2 skip:33
Results at /archive/results/CI_IGT_test/Patchwork_1779/
ce3f49e2a53a54308ed171613c2567f04fab8228 drm-intel-nightly: 2016y-04m-01d-20h-30m-13s UTC integration manifest 7fac24d29c524c760f7532d842ae390943916fe2 drm/i915: Correct stepping check for WaRsDisableCoarsePowerGating
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx