Skip to contentSkip to conversation

common: env_sf: Add exclamation mark

PATCH In review Peng Fan 2 participants 3 messages Mar 28, 2016 – Apr 2, 2016

lore
Share & tools
lore

Peng Fan

author
#0 lore raw

PATCH 1/1 common: env_sf: Add exclamation mark

Add exclamation mark to the errmsg, when error and set_default_env.

Signed-off-by Peng Fan <[email protected]>
Cc Mario Schuknecht <[email protected]>
Cc Vignesh R <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Ravi Babu <[email protected]>
Cc York Sun <[email protected]>
Cc Tom Rini <[email protected]>
---
 common/env_sf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/env_sf.c +1 -1
index 892e6cb..273098c 100644
@@ -225,7 +225,7 @@ void env_relocate_spec(void)
 	ret = env_import((char *)ep, 0);
 	if (!ret) {
 		error("Cannot import environment: errno = %d\n", errno);
-		set_default_env("env_import failed");
+		set_default_env("!env_import failed");
 	}
 
 err_read:
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 common: env_sf: Add exclamation mark

Quoted 1 line · Peng Fan

Add exclamation mark to the errmsg, when error and set_default_env.

This is awkwardly worded. We aren't adding a literal ! to the errmsg itself, we're adding that as a flag. I'll try and re-word this when applying to be clearer.

Quoted 8 lines
Signed-off-by Peng Fan <[email protected]>
Cc Mario Schuknecht <[email protected]>
Cc Vignesh R <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Ravi Babu <[email protected]>
Cc York Sun <[email protected]>
Cc Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160328/f12c0349/attachment.sig>
#2 lore raw
In reply to Peng Fan
Quoted 10 lines · Peng Fan

Add exclamation mark to the errmsg, when error and set_default_env.

Signed-off-by Peng Fan <[email protected]>
Cc Mario Schuknecht <[email protected]>
Cc Vignesh R <[email protected]>
Cc Jagan Teki <[email protected]>
Cc Ravi Babu <[email protected]>
Cc York Sun <[email protected]>
Cc Tom Rini <[email protected]>
Reviewed-by Tom Rini <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160401/b76d39c6/attachment.sig>