Skip to contentSkip to conversation

intel-iommu: fix up comment

PATCH Applied Michael S. Tsirkin 2 participants 3 messages Mar 23, 2016 – Apr 5, 2016 IOMMU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 intel-iommu: fix up comment

dma_pte_free_pagetable no longer depends on last level ptes being clear, it clears them itself. Fix up the comment to match.

Cc Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/[email protected]>
---
 drivers/iommu/intel-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel-iommu.c +1 -1
index a2e1b7f..0100553 100644
@@ -1143,7 +1143,7 @@ next:
 	} while (!first_pte_in_page(++pte) && pfn <= last_pfn);
 }
 
-/* free page table pages. last level pte should already be cleared */
+/* clear last level (leaf) ptes and free page table pages. */
 static void dma_pte_free_pagetable(struct dmar_domain *domain,
 				   unsigned long start_pfn,
 				   unsigned long last_pfn)
Signature · 1 line
MST
#1 lore raw
Quoted 7 lines · Michael S. Tsirkin

dma_pte_free_pagetable no longer depends on last level ptes being clear, it clears them itself. Fix up the comment to match.

Cc Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/[email protected]>

Anyone?

Quoted 19 lines
---
 drivers/iommu/intel-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/iommu/intel-iommu.c +1 -1
index a2e1b7f..0100553 100644
@@ -1143,7 +1143,7 @@ next:
 	} while (!first_pte_in_page(++pte) && pfn <= last_pfn);
 }
 
-/* free page table pages. last level pte should already be cleared */
+/* clear last level (leaf) ptes and free page table pages. */
 static void dma_pte_free_pagetable(struct dmar_domain *domain,
 				   unsigned long start_pfn,
 				   unsigned long last_pfn)
Signature · 1 line
MST
maintainer Applied
#2 lore raw
In reply to Michael S. Tsirkin
Quoted 10 lines · Michael S. Tsirkin

dma_pte_free_pagetable no longer depends on last level ptes being clear, it clears them itself. Fix up the comment to match.

Cc Jiang Liu <jiang.liu-VuQAYsv1563Yd54FQh9/[email protected]>
---
 drivers/iommu/intel-iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied. I changed the subject to:

x86/vt-d: Fix comment for dma_pte_free_pagetable()

Please use similar format for iommu-patches in the future.

Thanks,

Joerg