staging: rts5208: ensure braces on all arms of if stmt
PATCH 1/1 staging: rts5208: ensure braces on all arms of if stmt
Added braces on if arm of if statement where else arm already needs braces as suggested for clarity in Documentation/CodingStyle
Signed-off-by Nicholas Sim <[email protected]>
--- drivers/staging/rts5208/ms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/rts5208/ms.c +2 -1
@@ -794,8 +794,9 @@ static int ms_confirm_cpu_startup(struct rtsx_chip *chip) }if (val &INT_REG_ERR ) { -if (val &INT_REG_CMDNK ) +if (val &INT_REG_CMDNK ) { chip->card_wp |= (MS_CARD ); + }else {rtsx_trace (chip);return STATUS_FAIL ;
Signature · 1 line
2.4.3
Quoted 13 lines · Nicholas Sim
Added braces on if arm of if statement where else arm already needs braces as suggested for clarity in
Documentation/CodingStyleSigned-off-by Nicholas Sim <[email protected]>--- drivers/staging/rts5208/ms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/rts5208/ms.c +0
-0
drivers/staging/rts5208/ms.c static int ms_confirm_cpu_startup(struct rtsx_chip *chip) · line 800
Quoted 8 lines
drivers/staging/rts5208/ms.c +2
-1@@ -794,8 +794,9 @@ static int ms_confirm_cpu_startup(struct rtsx_chip *chip) }if (val &INT_REG_ERR ) { -if (val &INT_REG_CMDNK ) +if (val &INT_REG_CMDNK ) { chip->card_wp |= (MS_CARD ); + }else {
It should be } else { on one line.
regards,
dan carpenter
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel