power: ipaq-micro-battery: freeing the wrong variable

PATCH In review Dan Carpenter 2 participants 2 messages Mar 18, 2016 – Apr 10, 2016 Kernel janitors

Share & tools

Dan Carpenter

author

2016-03-18 09:00 UTC #0 lore raw

PATCH 1/1 power: ipaq-micro-battery: freeing the wrong variable

We accidentally free "micro_ac_power" which is an error pointer and it leads to an oops. We intended to free "micro_batt_power".

Fixes a2c1d531854c ('power_supply: ipaq_micro_battery: Check return values in probe')

Signed-off-by Dan Carpenter <[email protected]>

drivers/power/ipaq_micro_battery.c +1 -1

index 3f314b1..35b01c7 100644
@@ -261,7 +261,7 @@ static int micro_batt_probe(struct platform_device *pdev)
 	return 0;
 
 ac_err:
-	power_supply_unregister(micro_ac_power);
+	power_supply_unregister(micro_batt_power);
 batt_err:
 	cancel_delayed_work_sync(&mb->update);
 	destroy_workqueue(mb->wq);

Sebastian Reichel

2016-04-10 16:27 UTC #1 lore raw

Hi,

Quoted 2 lines · Dan Carpenter

We accidentally free "micro_ac_power" which is an error pointer and it leads to an oops. We intended to free "micro_batt_power".

Thanks, queued.

-- Sebastian