Skip to contentSkip to conversation

ARM: dts: imx6qdl-sabresd: Pass the hannstar panel compatible string

PATCH New Fabio Estevam 2 participants 2 messages Mar 28, 2016 – Apr 11, 2016

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 ARM: dts: imx6qdl-sabresd: Pass the hannstar panel compatible string

From: Fabio Estevam <[email protected]>

It is preferred to use the panel compatible string rather than passing the LCD timings in the device tree.

So pass the "hannstar,hsd100pxn1" compatible string to describe the LVDS panel on this board.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +17 -13
index 0b5c4de..b78cd79 100644
@@ -115,7 +115,7 @@
 		mux-ext-port = <3>;
 	};
 
-	backlight {
+	backlight_lvds: backlight_lvds {
 		compatible = "pwm-backlight";
 		pwms = <&pwm1 0 5000000>;
 		brightness-levels = <0 4 8 16 32 64 128 255>;

@@ -133,6 +133,17 @@
 		        default-state = "on";
 		};
 	};
+
+	panel {
+		compatible = "hannstar,hsd100pxn1";
+		backlight = <&backlight_lvds>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&lvds0_out>;
+			};
+		};
+	};
 };
 
 &audmux {

@@ -509,18 +520,11 @@
 		fsl,data-width = <18>;
 		status = "okay";
 
-		display-timings {
-			native-mode = <&timing0>;
-			timing0: hsd100pxn1 {
-				clock-frequency = <65000000>;
-				hactive = <1024>;
-				vactive = <768>;
-				hback-porch = <220>;
-				hfront-porch = <40>;
-				vback-porch = <21>;
-				vfront-porch = <7>;
-				hsync-len = <60>;
-				vsync-len = <10>;
+		port at 4 {
+			reg = <4>;
+
+			lvds0_out: endpoint {
+				remote-endpoint = <&panel_in>;
 			};
 		};
 	};
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 ARM: dts: imx6qdl-sabresd: Pass the hannstar panel compatible string

Quoted 18 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

It is preferred to use the panel compatible string rather than passing the LCD timings in the device tree.

So pass the "hannstar,hsd100pxn1" compatible string to describe the LVDS panel on this board.

Signed-off-by Fabio Estevam <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +0 -0
index 0b5c4de..b78cd79 100644

arch/arm/boot/dts/imx6qdl-sabresd.dtsi line 118

Quoted 5 lines
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +1 -1
@@ -115,7 +115,7 @@
 		mux-ext-port = <3>;
 	};
 
-	backlight {
+	backlight_lvds: backlight_lvds {

Hyphen instead of underscore should be used in node names.

I fixed it up and applied patch.

Shawn

Quoted 49 lines
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +16 -12
 		compatible = "pwm-backlight";
 		pwms = <&pwm1 0 5000000>;
 		brightness-levels = <0 4 8 16 32 64 128 255>;

@@ -133,6 +133,17 @@
 		        default-state = "on";
 		};
 	};
+
+	panel {
+		compatible = "hannstar,hsd100pxn1";
+		backlight = <&backlight_lvds>;
+
+		port {
+			panel_in: endpoint {
+				remote-endpoint = <&lvds0_out>;
+			};
+		};
+	};
 };
 
 &audmux {

@@ -509,18 +520,11 @@
 		fsl,data-width = <18>;
 		status = "okay";
 
-		display-timings {
-			native-mode = <&timing0>;
-			timing0: hsd100pxn1 {
-				clock-frequency = <65000000>;
-				hactive = <1024>;
-				vactive = <768>;
-				hback-porch = <220>;
-				hfront-porch = <40>;
-				vback-porch = <21>;
-				vfront-porch = <7>;
-				hsync-len = <60>;
-				vsync-len = <10>;
+		port at 4 {
+			reg = <4>;
+
+			lvds0_out: endpoint {
+				remote-endpoint = <&panel_in>;
 			};
 		};
 	};
Signature · 1 line
1.9.1