dt-bindings: Add new platforms GPIO node description

PATCH New Liu Gang 4 participants 13 messages Mar 23, 2016 – Apr 13, 2016

Subsystems (3)

Device tree bindings Arm i.MX and Layerscape GPIO

lore

Share & tools

lore

Liu Gang

author

2016-03-23 09:47 UTC #0 lore raw

PATCH 1/1 dt-bindings: Add new platforms GPIO node description

Update the NXP GPIO node dt-binding file for QorIQ and Layerscape platforms, and add one more example with ls2080a GPIO node.

Signed-off-by Liu Gang <[email protected]>

---
 .../devicetree/bindings/gpio/gpio-mpc8xxx.txt        | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

Documentation/devicetree/bindings/gpio/gpio-mpc8xxx.txt +17 -3

index 120bc49..4b6cc63 100644
@@ -1,9 +1,10 @@
-* Freescale MPC512x/MPC8xxx/Layerscape GPIO controller
+* Freescale MPC512x/MPC8xxx/QorIQ/Layerscape GPIO controller
 
 Required properties:
 - compatible : Should be "fsl,<soc>-gpio"
   The following <soc>s are known to be supported:
-    mpc5121, mpc5125, mpc8349, mpc8572, mpc8610, pq3, qoriq.
+	mpc5121, mpc5125, mpc8349, mpc8572, mpc8610, pq3, qoriq,
+	ls1021a, ls1043a, ls2080a.
 - reg : Address and length of the register set for the device
 - interrupts : Should be the port interrupt shared by all 32 pins.
 - #gpio-cells : Should be two.  The first cell is the pin number and

@@ -15,7 +16,7 @@ Optional properties:
 - little-endian : GPIO registers are used as little endian. If not
                   present registers are used as big endian by default.
 
-Example:
+Example of gpio-controller node for a mpc5125 SoC:
 
 gpio0: gpio at 1100 {
 	compatible = "fsl,mpc5125-gpio";

@@ -24,3 +25,16 @@ gpio0: gpio at 1100 {
 	interrupts = <78 0x8>;
 	status = "okay";
 };
+
+Example of gpio-controller node for a ls2080a SoC:
+
+gpio0: gpio at 2300000 {
+	compatible = "fsl,ls2080a-gpio", "fsl,qoriq-gpio";
+	reg = <0x0 0x2300000 0x0 0x10000>;
+	interrupts = <0 36 0x4>; /* Level high type */
+	gpio-controller;
+	little-endian;
+	#gpio-cells = <2>;
+	interrupt-controller;
+	#interrupt-cells = <2>;
+};

Signature · 1 line

2.1.0.27.g96db324

Liu Gang

author

2016-03-23 09:47 UTC #1 lore raw

PATCH v2 1/1 gpio/ls1021a: Add gpio support for ls1021a platform

Add gpio nodes for ls1021a platform dts file. The gpio IP block of the ls1021a can be supported by the code drivers/gpio/gpio-mpc8xxx.c.

The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.

The chip-specific compatible "fsl,ls1021a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.

Signed-off-by Liu Gang <[email protected]>

---
v2 changes:
Add chip-specific compatible based on Scott's comment.

 arch/arm/boot/dts/ls1021a.dtsi | 40 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)

arch/arm/boot/dts/ls1021a.dtsi +40 -0

index ecf12dc..662b336 100644
@@ -332,6 +332,46 @@
 			status = "disabled";
 		};
 
+		gpio0: gpio at 2300000 {
+			compatible = "fsl,ls1021a-gpio", "fsl,qoriq-gpio";
+			reg = <0x0 0x2300000 0x0 0x10000>;
+			interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
+		gpio1: gpio at 2310000 {
+			compatible = "fsl,ls1021a-gpio", "fsl,qoriq-gpio";
+			reg = <0x0 0x2310000 0x0 0x10000>;
+			interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
+		gpio2: gpio at 2320000 {
+			compatible = "fsl,ls1021a-gpio", "fsl,qoriq-gpio";
+			reg = <0x0 0x2320000 0x0 0x10000>;
+			interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
+		gpio3: gpio at 2330000 {
+			compatible = "fsl,ls1021a-gpio", "fsl,qoriq-gpio";
+			reg = <0x0 0x2330000 0x0 0x10000>;
+			interrupts = <GIC_SPI 166 IRQ_TYPE_LEVEL_HIGH>;
+			gpio-controller;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+		};
+
 		lpuart0: serial at 2950000 {
 			compatible = "fsl,ls1021a-lpuart";
 			reg = <0x0 0x2950000 0x0 0x1000>;

Signature · 1 line

2.1.0.27.g96db324

Linus Walleij

2016-03-31 08:32 UTC #2 lore raw

PATCH v2 1/1 gpio/ls1021a: Add gpio support for ls1021a platform

The subject of this patch should be:

ARM: dts: ...

And it should be merged through the ARM SoC tree.

Quoted 8 lines · Liu Gang

Add gpio nodes for ls1021a platform dts file. The gpio IP block of the ls1021a can be supported by the code drivers/gpio/gpio-mpc8xxx.c.
The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.

Quoted 5 lines

The chip-specific compatible "fsl,ls1021a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.
Signed-off-by Liu Gang <[email protected]>

Apart from that it looks OK.

Yours,
Linus Walleij

Shawn Guo

2016-04-13 04:48 UTC #3 lore raw

PATCH v2 1/1 gpio/ls1021a: Add gpio support for ls1021a platform

In reply to Liu Gang

Quoted 8 lines · Liu Gang

Add gpio nodes for ls1021a platform dts file. The gpio IP block of the ls1021a can be supported by the code drivers/gpio/gpio-mpc8xxx.c.
The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.

Quoted 5 lines

The chip-specific compatible "fsl,ls1021a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.
Signed-off-by Liu Gang <[email protected]>

Changed subject prefix to 'ARM: dts: ls1021a: ...', and applied the patch.

Shawn

Liu Gang

author

2016-03-23 09:47 UTC #4 lore raw

PATCH v2 1/1 gpio/ls1043a: Add compatible "fsl, qoriq-gpio" for ls1043a gpio nodes

In reply to Liu Gang

The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.

The chip-specific compatible "fsl,ls1043a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.

Signed-off-by Liu Gang <[email protected]>

---
v2 changes:
Add chip-specific compatible based on Scott's comment.

 arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +4 -4

index be72bf5..bf70b27 100644
@@ -284,7 +284,7 @@
 		};
 
 		gpio1: gpio at 2300000 {
-			compatible = "fsl,ls1043a-gpio";
+			compatible = "fsl,ls1043a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2300000 0x0 0x10000>;
 			interrupts = <0 66 0x4>;
 			gpio-controller;

@@ -294,7 +294,7 @@
 		};
 
 		gpio2: gpio at 2310000 {
-			compatible = "fsl,ls1043a-gpio";
+			compatible = "fsl,ls1043a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2310000 0x0 0x10000>;
 			interrupts = <0 67 0x4>;
 			gpio-controller;

@@ -304,7 +304,7 @@
 		};
 
 		gpio3: gpio at 2320000 {
-			compatible = "fsl,ls1043a-gpio";
+			compatible = "fsl,ls1043a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2320000 0x0 0x10000>;
 			interrupts = <0 68 0x4>;
 			gpio-controller;

@@ -314,7 +314,7 @@
 		};
 
 		gpio4: gpio at 2330000 {
-			compatible = "fsl,ls1043a-gpio";
+			compatible = "fsl,ls1043a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2330000 0x0 0x10000>;
 			interrupts = <0 134 0x4>;
 			gpio-controller;

Signature · 1 line

2.1.0.27.g96db324

Gang Liu

author

2016-03-31 03:36 UTC #5 lore raw

PATCH v2 1/1 gpio/ls1043a: Add compatible "fsl,qoriq-gpio" for ls1043a gpio nodes

Hi, Linus Walleij,

Do you have some comments about this set of patches? Could you please help to ACK and apply those?

Thanks a lot!
Liu Gang

-----Original Message-----
From: Liu Gang [mailto:Gang.Liu at nxp.com]
Sent: Wednesday, March 23, 2016 5:47 PM
To: linus.walleij at linaro.org; linux-gpio at vger.kernel.org; linux-arm-kernel at lists.infradead.org; khilman at linaro.org
Cc: robh+dt at kernel.org; Scott Wood <[email protected]>; Yang-Leo Li <[email protected]>; Mingkai Hu <[email protected]>; Gang Liu <[email protected]>
Subject: [PATCH v2] gpio/ls1043a: Add compatible "fsl,qoriq-gpio" for ls1043a gpio nodes

The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.

The chip-specific compatible "fsl,ls1043a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.

Signed-off-by Liu Gang <[email protected]>

---
v2 changes:
Add chip-specific compatible based on Scott's comment.

 arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +4 -4

index be72bf5..bf70b27 100644
@@ -284,7 +284,7 @@
 		};
 
 		gpio1: gpio at 2300000 {
-			compatible = "fsl,ls1043a-gpio";
+			compatible = "fsl,ls1043a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2300000 0x0 0x10000>;
 			interrupts = <0 66 0x4>;
 			gpio-controller;

@@ -294,7 +294,7 @@
 		};
 
 		gpio2: gpio at 2310000 {
-			compatible = "fsl,ls1043a-gpio";
+			compatible = "fsl,ls1043a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2310000 0x0 0x10000>;
 			interrupts = <0 67 0x4>;
 			gpio-controller;

@@ -304,7 +304,7 @@
 		};
 
 		gpio3: gpio at 2320000 {
-			compatible = "fsl,ls1043a-gpio";
+			compatible = "fsl,ls1043a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2320000 0x0 0x10000>;
 			interrupts = <0 68 0x4>;
 			gpio-controller;

@@ -314,7 +314,7 @@
 		};
 
 		gpio4: gpio at 2330000 {
-			compatible = "fsl,ls1043a-gpio";
+			compatible = "fsl,ls1043a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2330000 0x0 0x10000>;
 			interrupts = <0 134 0x4>;
 			gpio-controller;

--
2.1.0.27.g96db324

Linus Walleij

2016-04-01 12:53 UTC #6 lore raw

PATCH v2 1/1 gpio/ls1043a: Add compatible "fsl,qoriq-gpio" for ls1043a gpio nodes

In reply to Liu Gang

On Wed, Mar 23, 2016 at 10:47 AM, Liu Gang <[email protected]> wrote:

The subject of the patch should be

ARM64: dts: ...

Apart from that it looks OK, DTS files are not really my business.

Yoursm
Linus Walleij

Shawn Guo

2016-04-13 05:03 UTC #7 lore raw

PATCH v2 1/1 gpio/ls1043a: Add compatible "fsl, qoriq-gpio" for ls1043a gpio nodes

In reply to Liu Gang

Quoted 9 lines · Liu Gang

The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.
The chip-specific compatible "fsl,ls1043a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.
Signed-off-by Liu Gang <[email protected]>

Changed subject prefix to 'arm64: dts: ls1043a: ...', dropped the space after 'fsl,', adn then applied the patch.

Yes, arm and arm64 use different prefix style, uppercase vs lowercase.

Shawn

Liu Gang

author

2016-03-23 09:47 UTC #8 lore raw

PATCH 1/1 gpio/ls2080a: Add compatible "fsl, ls2080a-gpio" for ls2080a gpio nodes

In reply to Liu Gang

The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.

The chip-specific compatible "fsl,ls2080a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.

Signed-off-by Liu Gang <[email protected]>

---
 arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi +4 -4

index 9d746c6..24b4330 100644
@@ -342,7 +342,7 @@
 		};
 
 		gpio0: gpio at 2300000 {
-			compatible = "fsl,qoriq-gpio";
+			compatible = "fsl,ls2080a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2300000 0x0 0x10000>;
 			interrupts = <0 36 0x4>; /* Level high type */
 			gpio-controller;

@@ -353,7 +353,7 @@
 		};
 
 		gpio1: gpio at 2310000 {
-			compatible = "fsl,qoriq-gpio";
+			compatible = "fsl,ls2080a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2310000 0x0 0x10000>;
 			interrupts = <0 36 0x4>; /* Level high type */
 			gpio-controller;

@@ -364,7 +364,7 @@
 		};
 
 		gpio2: gpio at 2320000 {
-			compatible = "fsl,qoriq-gpio";
+			compatible = "fsl,ls2080a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2320000 0x0 0x10000>;
 			interrupts = <0 37 0x4>; /* Level high type */
 			gpio-controller;

@@ -375,7 +375,7 @@
 		};
 
 		gpio3: gpio at 2330000 {
-			compatible = "fsl,qoriq-gpio";
+			compatible = "fsl,ls2080a-gpio", "fsl,qoriq-gpio";
 			reg = <0x0 0x2330000 0x0 0x10000>;
 			interrupts = <0 37 0x4>; /* Level high type */
 			gpio-controller;

Signature · 1 line

2.1.0.27.g96db324

Linus Walleij

2016-03-31 08:29 UTC #9 lore raw

PATCH 1/1 gpio/ls2080a: Add compatible "fsl,ls2080a-gpio" for ls2080a gpio nodes

The subject of this patch should be:

ARM64: dts: ...

And it should be merged into the ARM SoC tree, not the GPIO tree.

Quoted 9 lines · Liu Gang

The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.
The chip-specific compatible "fsl,ls2080a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.
Signed-off-by Liu Gang <[email protected]>

Apart from that it looks good.

Yours,
Linus Walleij

Li Yang

2016-03-31 19:40 UTC #10 lore raw

PATCH 1/1 gpio/ls2080a: Add compatible "fsl,ls2080a-gpio" for ls2080a gpio nodes

Quoted 5 lines · Linus Walleij

The subject of this patch should be:
ARM64: dts: ...
And it should be merged into the ARM SoC tree, not the GPIO tree.

Thanks for the comment. I will help to fix the title issues for the dts patches and push for acceptance in arm-soc tree.

Regards,
Leo

Shawn Guo

2016-04-13 05:04 UTC #11 lore raw

PATCH 1/1 gpio/ls2080a: Add compatible "fsl, ls2080a-gpio" for ls2080a gpio nodes

In reply to Liu Gang

Quoted 9 lines · Liu Gang

The compatible "fsl,qoriq-gpio" is used by gpio driver:
drivers/gpio/gpio-mpc8xxx.c to implement general gpio functionalities.
The chip-specific compatible "fsl,ls2080a-gpio" may be used to fix potential gpio IP block errata or other chip-specific gpio issues.
Signed-off-by Liu Gang <[email protected]>

Updated patch subject as below and then applied it.

arm64: dts: ls2080a: Add compatible "fsl,ls2080a-gpio" for ls2080a gpio nodes

Shawn

Linus Walleij

2016-03-31 08:30 UTC #12 lore raw

PATCH 1/1 dt-bindings: Add new platforms GPIO node description

In reply to Liu Gang

Quoted 5 lines · Liu Gang

Update the NXP GPIO node dt-binding file for QorIQ and Layerscape platforms, and add one more example with ls2080a GPIO node.
Signed-off-by Liu Gang <[email protected]>

Patch applied.

Yours,
Linus Walleij