UBI: clean up return in ubi_remove_volume()

PATCH New Dan Carpenter 1 participant 1 message Apr 13, 2016

Subsystems (3)

Kernel janitors Memory technology devices (MTD) Unsorted block images (UBI)

lore

Share & tools

lore

Dan Carpenter

author

2016-04-13 06:41 UTC #0 lore raw

PATCH 1/1 UBI: clean up return in ubi_remove_volume()

My static checker says that "err" can be uninitialized if "vol->reserved_pebs" is <= 0. I don't think that can happen but returning a literal is cleaner anyway.

Signed-off-by Dan Carpenter <[email protected]>

drivers/mtd/ubi/vmt.c +1 -1

index 1ae17bb..10059df 100644
@@ -405,7 +405,7 @@ int ubi_remove_volume(struct ubi_volume_desc *desc, int no_vtbl)
 	if (!no_vtbl)
 		self_check_volumes(ubi);
 
-	return err;
+	return 0;
 
 out_err:
 	ubi_err(ubi, "cannot remove volume %d, error %d", vol_id, err);