tty: hvc_console: silence unintialized variable warning

PATCH New Dan Carpenter 1 participant 1 message Apr 13, 2016

Subsystems (3)

Kernel janitors TTY layer and serial drivers Hypervisor virtual console driver

lore

Share & tools

lore

Dan Carpenter

author

2016-04-13 06:44 UTC #0 lore raw

PATCH 1/1 tty: hvc_console: silence unintialized variable warning

If ->get_char() returns a negative error code and that can mean that "ch" is uninitialized. The callers of this function expect NO_POLL_CHAR on error so let's return that.

Signed-off-by Dan Carpenter <[email protected]>

drivers/tty/hvc/hvc_console.c +1 -1

index e46d628..325747a 100644
@@ -814,7 +814,7 @@ static int hvc_poll_get_char(struct tty_driver *driver, int line)
 
 	n = hp->ops->get_chars(hp->vtermno, &ch, 1);
 
-	if (n = 0)
+	if (n <= 0)
 		return NO_POLL_CHAR;
 
 	return ch;