Skip to contentSkip to conversation

PyMySQL: new package

PATCH New Steve Calfee 3 participants 3 messages Apr 12, 2016 – Apr 13, 2016

lore
Share & tools
lore

Steve Calfee

author
#0 lore raw

PATCH v6 1/1 PyMySQL: new package

add python to MySQL connection software, written in pure python

Signed-off-by Steve Calfee <[email protected]>

---
v4 fix git commit per review

---
v5 fixup missed review request for Capitalization of MySQL

---
 package/Config.in                          |  1 +
 package/python-pymysql/Config.in           |  7 +++++++
 package/python-pymysql/python-pymysql.hash |  4 ++++
 package/python-pymysql/python-pymysql.mk   | 14 ++++++++++++++
 4 files changed, 26 insertions(+)
 create mode 100644 package/python-pymysql/Config.in
 create mode 100644 package/python-pymysql/python-pymysql.hash
 create mode 100644 package/python-pymysql/python-pymysql.mk
package/Config.in +1 -0
index 529ad33..2543195 100644
@@ -683,6 +683,7 @@ menu "External python modules"
 	source "package/python-pyftpdlib/Config.in"
 	source "package/python-pygame/Config.in"
 	source "package/python-pyinotify/Config.in"
+	source "package/python-pymysql/Config.in"
 	source "package/python-pyparsing/Config.in"
 	source "package/python-pyparted/Config.in"
 	source "package/python-pypcap/Config.in"
package/python-pymysql/Config.in new file +7 -0
new file mode 100644
index 0000000..d0db376
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PYTHON_PYMYSQL
+	bool "python-pymysql"
+	help
+	  PyMySQL is a pure-Python MySQL client library. 
+	  It follows the DB-API 2.0.
+
+	  https://pypi.python.org/pypi/PyMySQL/
package/python-pymysql/python-pymysql.hash new file +4 -0
new file mode 100644
index 0000000..fc7e5e3
@@ -0,0 +1,4 @@
+#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=6d757cda8bfbd312714207f7c0bef5c7
+md5     6d757cda8bfbd312714207f7c0bef5c7 PyMySQL-0.7.2.tar.gz
+# Locally calculated:
+sha256 bd7acb4990dbf097fae3417641f93e25c690e01ed25c3ed32ea638d6c3ac04ba  PyMySQL-0.7.2.tar.gz
package/python-pymysql/python-pymysql.mk new file +14 -0
new file mode 100644
index 0000000..e58ff7e
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-pymysql
+#
+################################################################################
+
+PYTHON_PYMYSQL_VERSION = 0.7.2
+PYTHON_PYMYSQL_SOURCE = PyMySQL-$(PYTHON_PYMYSQL_VERSION).tar.gz
+PYTHON_PYMYSQL_SITE = https://pypi.python.org/packages/source/P/PyMySQL
+PYTHON_PYMYSQL_LICENSE = MIT
+PYTHON_PYMYSQL_LICENSE_FILES = LICENSE
+PYTHON_PYMYSQL_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
Signature · 1 line
2.5.0
#1 lore raw

PATCH v6 1/1 PyMySQL: new package

Quoted 3 lines · Steve Calfee

add python to MySQL connection software, written in pure python

Signed-off-by Steve Calfee <[email protected]>

As said:

Reviewed-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Regards,
Arnout

Quoted 72 lines

---
v4 fix git commit per review

---
v5 fixup missed review request for Capitalization of MySQL

---
  package/Config.in                          |  1 +
  package/python-pymysql/Config.in           |  7 +++++++
  package/python-pymysql/python-pymysql.hash |  4 ++++
  package/python-pymysql/python-pymysql.mk   | 14 ++++++++++++++
  4 files changed, 26 insertions(+)

create mode 100644 package/python-pymysql/Config.in create mode 100644 package/python-pymysql/python-pymysql.hash create mode 100644 package/python-pymysql/python-pymysql.mk

package/Config.in +1 -0
index 529ad33..2543195 100644
@@ -683,6 +683,7 @@ menu "External python modules"
  	source "package/python-pyftpdlib/Config.in"
  	source "package/python-pygame/Config.in"
  	source "package/python-pyinotify/Config.in"
+	source "package/python-pymysql/Config.in"
  	source "package/python-pyparsing/Config.in"
  	source "package/python-pyparted/Config.in"
  	source "package/python-pypcap/Config.in"
package/python-pymysql/Config.in new file +7 -0
new file mode 100644
index 0000000..d0db376
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PYTHON_PYMYSQL
+	bool "python-pymysql"
+	help
+	  PyMySQL is a pure-Python MySQL client library.
+	  It follows the DB-API 2.0.
+
+	  https://pypi.python.org/pypi/PyMySQL/
package/python-pymysql/python-pymysql.hash new file +4 -0
new file mode 100644
index 0000000..fc7e5e3
@@ -0,0 +1,4 @@
+#md5 from https://pypi.python.org/pypi?:action=show_md5&digest=6d757cda8bfbd312714207f7c0bef5c7
+md5     6d757cda8bfbd312714207f7c0bef5c7 PyMySQL-0.7.2.tar.gz
+# Locally calculated:
+sha256 bd7acb4990dbf097fae3417641f93e25c690e01ed25c3ed32ea638d6c3ac04ba  PyMySQL-0.7.2.tar.gz
package/python-pymysql/python-pymysql.mk new file +14 -0
new file mode 100644
index 0000000..e58ff7e
@@ -0,0 +1,14 @@
+################################################################################
+#
+# python-pymysql
+#
+################################################################################
+
+PYTHON_PYMYSQL_VERSION = 0.7.2
+PYTHON_PYMYSQL_SOURCE = PyMySQL-$(PYTHON_PYMYSQL_VERSION).tar.gz
+PYTHON_PYMYSQL_SITE = https://pypi.python.org/packages/source/P/PyMySQL
+PYTHON_PYMYSQL_LICENSE = MIT
+PYTHON_PYMYSQL_LICENSE_FILES = LICENSE
+PYTHON_PYMYSQL_SETUP_TYPE = setuptools
+
+$(eval $(python-package))
Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
Applied
#2 lore raw

PATCH v6 1/1 PyMySQL: new package

In reply to Steve Calfee

Hello,

Quoted 3 lines · Steve Calfee

add python to MySQL connection software, written in pure python

Signed-off-by Steve Calfee <[email protected]>

The title of the commit should have used the package name:

python-pymysql: new package

package/python-pymysql/Config.in line 4

Quoted 10 lines
package/python-pymysql/Config.in new file +4 -0
new file mode 100644
index 0000000..d0db376
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_PYTHON_PYMYSQL
+	bool "python-pymysql"
+	help
+	  PyMySQL is a pure-Python MySQL client library.

There was a trailing whitespace on this line.

Also, your patch did not apply due to a conflict in package/Config.in, caused by packages that were added quite some time ago in Buildroot. This seems to indicate that you are not working on top of the latest master. Please submit patches that are based and tested on top of the latest master.

I've applied after fixing the minor issues mentioned above. Thanks a lot!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com